This CL addresses an issue with CSS system colors where the values of
`Field` and `FieldText` were shared with `Canvas` and `CanvasText`
respectively. This occurred after switching to retrieve system colors
from color providers instead of the NativeTheme in Blink
(http://crrev.com/c/5322440).
Previously, for Windows, `Field` and `FieldText` were retrieved using
the NativeTheme in light mode and forced colors mode, sharing the same
colors as `Canvas` and `CanvasText`. However, for Dark mode on Windows
and non-forced colors scenarios for other OSs, we used
`LayoutTheme::DefaultSystemColor()`, which treated these colors
separately.
To fix this discrepancy, new color ids have been added to the color
pipeline for these system colors, allowing them to share the same colors
when appropriate and have distinct colors when necessary.
Bug: 400746852
Change-Id: I47f7c8dd56bbd66bdde04c70847a5274cc431cec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6349557
Reviewed-by: Alison Maher <almaher@microsoft.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Sam Davis Omekara <samomekarajr@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1432463}
Add `safe_inline_edge` and `safe_block_edge` to LogicalStaticPosition
and `safe_horizontal_edge` and `safe_vertical_edge` to
PhysicalStaticPosition to track the edge if overflow alignment is set
to 'safe' [1].
A future change will propagate the correct values up when OOFs are
added to the tree, converting them as they are propagated.
These edges will be used in OOF layout to properly handle safe
overflow alignment when an OOF is statically positioned.
[1] https://drafts.csswg.org/css-align/#valdef-overflow-position-safe
Bug: 40206357
Change-Id: I54d3c53a68e970e41cba6815e803fc60f5802669
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6345454
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432460}
Eliminate some JSONStringValue[De]Serializer
usages in the //ios directory and replace them
with slightly more concise equivalents.
Along with some other changes that may be
necessary.
Bug: 40912727,40258809
Change-Id: I80e3c51a08eddb04f9a1c62b6dc30fa18da99757
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6348000
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Ho Cheung <hocheung@chromium.org>
Reviewed-by: Andrew Paseltiner <apaseltiner@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432459}
Implement the AXBlockFlowIterator algorithm as an
alternative method for generating
AXInlineTextBoxes. The output produced matches the
current algorithm exactly, as confirmed by a
successful CQ run. This new algorithm is activated
via a feature flag to facilitate performance
studies.
Change-Id: I0cc29963e9c02828a058eb8f42b45213caf09a86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6283522
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Commit-Queue: Lucas Radaelli <lucasradaelli@google.com>
Cr-Commit-Position: refs/heads/main@{#1432457}
A recent refactoring of ExtensionService means this target is no longer
dependent on //chrome/browser/extensions. However, it was getting one of
its dependencies transitively from there.
This CL removes the unneeded dependency and adds the missing one. This
helps break up cyclical dependencies between this target and some
extension API targets.
Bug: 40593486
Change-Id: I4b64ae3f20f59d1091ab5b128d775e92d558f2ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6354180
Commit-Queue: Theresa Sullivan <twellington@chromium.org>
Auto-Submit: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432453}
Currently, the title is not updated correctly for multi IDP. We fix this
by computing whether multiple IDPs are being shown in updateSheet() and
by setting the idp for display and icon in showAccountsInternal()
instead of showAccounts() since the former is the one which is invoked
when the back button is pressed.
Demo: https://issues.chromium.org/issues/392142580#comment16
Bug: 392142580
Change-Id: I3b07e023007e85f78b8b32a3a0b5eece8fe1b4c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6352821
Commit-Queue: Nicolás Peña <npm@chromium.org>
Reviewed-by: Zachary Tan <tanzachary@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432452}
The problem fixed here is that we try to call notifyPanelWillOpen
synthetically when chrome://glic is opened from a tab. This check
wasn't done correctly.
Bug: 402286424
Change-Id: I2593e19dbdf3fd805d3f5f222b34e7dde17641fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6354728
Reviewed-by: Nick Birnie <birnie@google.com>
Commit-Queue: Dan Harrington <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432450}
This CL changes the Toast Params API to accept a full string
as an alternative to providing string resource ID and replacement
strings.
Bug: 403139390
Change-Id: I3004c80241a5820edd4738d886ec63778ff61e0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6349928
Reviewed-by: Alison Gale <agale@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432445}
It is possible for `ScannerController::CanShowUi` to be true, and
therefore allowing Sunfish-capture-sessions to be started, while
`ScannerController::CanStartSession` is false. This is specifically when
the user has not consented to the feature yet.
If this is the case when a Sunfish-session is started, and the user
accepts consent during the session, actions will not appear despite
`ScannerController::CanStartSession` now being true - as a Scanner
session is only started on Sunfish-capture-session start.
Fix this by moving the Scanner session start from
Sunfish-capture-session start to once the consent disclaimer has been
accepted, which is instant if the consent disclaimer has already been
accepted.
Fixed: b:401980665
Change-Id: I6a6a2100a1e635054dc632129df8383f797132dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6338426
Commit-Queue: Michael Cui <mlcui@google.com>
Auto-Submit: Michael Cui <mlcui@google.com>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432444}
e8b91a8b85..02d0fad2c5
$ git log e8b91a8b8..02d0fad2c --date=short --no-merges --format='%ad %ae %s'
2025-03-13 vigneshv decode: Fix alpha premultiplied
2025-03-13 vigneshv decode: Add option to ignore xmp and exif
2025-03-12 vigneshv aom: Add aom-sys crate
2025-03-12 vigneshv Move Fraction structs out of internal_utils
2025-03-11 vigneshv Move some structs out of the decoder module
2025-03-10 maryla Handle animation with audio track.
2025-03-06 maryla Check the auxiliary track type. Previously, all auxiliary tracks were treated as being alpha regardless of their type. Assume alpha if no type is present.
Created with:
roll-dep src/third_party/crabbyavif/src
R=jzern@google.com
Bug: 402547568
Change-Id: Ic7fc72a3efe363d6463b0c610a1a4ebc3cc787cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6352898
Auto-Submit: Vignesh Venkat <vigneshv@google.com>
Commit-Queue: James Zern <jzern@google.com>
Reviewed-by: James Zern <jzern@google.com>
Cr-Commit-Position: refs/heads/main@{#1432441}
This CL has been created semi-automatically. The expected review
process and other details can be found at
//tools/crates/create_update_cl.md
Updated crates:
* quote: 1.0.39 => 1.0.40
Chromium `supply-chain/config.toml` policy requires that the following
audit criteria are met (note that these are the *minimum* required
criteria and `supply-chain/audits.toml` can and should record a stricter
certification if possible; see also //docs/rust-unsafe.md):
* quote@1.0.40: crypto-safe, safe-to-deploy, ub-risk-2
Bug: None
Change-Id: Iab0eef40f8c3fda1630d978dfe88f3b6cd8373ca
Cq-Include-Trybots: chromium/try:android-rust-arm32-rel
Cq-Include-Trybots: chromium/try:android-rust-arm64-dbg
Cq-Include-Trybots: chromium/try:android-rust-arm64-rel
Cq-Include-Trybots: chromium/try:linux-rust-x64-dbg
Cq-Include-Trybots: chromium/try:linux-rust-x64-rel
Cq-Include-Trybots: chromium/try:win-rust-x64-dbg
Cq-Include-Trybots: chromium/try:win-rust-x64-rel
Disable-Rts: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6352976
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432436}
This CL has been created semi-automatically. The expected review
process and other details can be found at
//tools/crates/create_update_cl.md
Updated crates:
* libc: 0.2.170 => 0.2.171
Chromium `supply-chain/config.toml` policy requires that the following
audit criteria are met (note that these are the *minimum* required
criteria and `supply-chain/audits.toml` can and should record a stricter
certification if possible; see also //docs/rust-unsafe.md):
* libc@0.2.171: crypto-safe, safe-to-deploy, ub-risk-2
Bug: None
Change-Id: Iddf9376714d16e3b33c4a67e11502026e48ca25a
Cq-Include-Trybots: chromium/try:android-rust-arm32-rel
Cq-Include-Trybots: chromium/try:android-rust-arm64-dbg
Cq-Include-Trybots: chromium/try:android-rust-arm64-rel
Cq-Include-Trybots: chromium/try:linux-rust-x64-dbg
Cq-Include-Trybots: chromium/try:linux-rust-x64-rel
Cq-Include-Trybots: chromium/try:win-rust-x64-dbg
Cq-Include-Trybots: chromium/try:win-rust-x64-rel
Disable-Rts: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6352956
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432435}
These currently don't conflict because they're in anonymous namespaces.
In preparation for moving them out of those namespaces (so they can be
forward-declared elsewhere), give them unique names.
Bug: 403313552
Change-Id: I7fc3a9d659bf1f2d8991dfd022bcd8ff51c393dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6354727
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: David Yeung <dayeung@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432431}
This CL allows the webm muxer to properly set rotation and horizontal
flipping on the VideoTrack. While the VideoParameters type will have a
VideoTransformation, actually writing the VideoTransformation into
VideoParameters will be done in a later CL as it involves adding
Transformation related methods to EncodedFrame and other classes.
Bug: 391786486
Change-Id: I50c69f363879569b0269e6d9c64dbdaa59241d9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6309559
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Syed AbuTalib <lowkey@google.com>
Cr-Commit-Position: refs/heads/main@{#1432430}
If a page has an optional CropBox which has a different offset compared
to its required MediaBox, then this can impact the positioning for Ink
strokes applied to the page.
Update the transform generation used when applying Ink strokes into the
PDF page to account for any offset from the intersection of these two
boxes.
Fixed: 402043701
Change-Id: I4126dc52ddf3533580a94d2f186a46b043f0985b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6346007
Commit-Queue: Alan Screen <awscreen@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Andy Phan <andyphan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432426}
https://crrev.com/c/6297343 overrides the long press home button
shortcut when the Sunfish or Scanner features are enabled. Update the
hotseat widget tests to accommodate for this in preparation for enabling
Scanner by default.
Bug: b:391909810, b:397538442
Change-Id: I6a6a2100b1352fb1a5d7e4ff6530977bc5206909
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6347538
Commit-Queue: Michael Cui <mlcui@google.com>
Reviewed-by: Toni Barzic <tbarzic@google.com>
Cr-Commit-Position: refs/heads/main@{#1432422}
Temporarily disable kWebAuthnPasskeyUpgrade by default for a cherry-pick
to M135. Once the cherry pick is complete, this change will be reverted
on main (i.e., re-enabling the flag by default for M136).
Include-Ci-Only-Tests: chromium.mac:mac14-tests|browser_tests
Bug: 403343688
Change-Id: I3eeaa87d6b6713b940feb1b3e989a021f61babbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6354943
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Auto-Submit: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Nina Satragno <nsatragno@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432418}
This fixes a bug where clicking on icons from the overflow menu did not
open the correct menu. This was because we were using the
`onTextStyleMenuButtonClick_` callback from the overflow menu, which
opened the index of the item based on the `textStyleOptions_` array, not
based on the `moreOptionsButtons_` array.
I added a test to replicate this scenario, and confirmed that it
previously failed and now succeeds.
Bug: 403292140
Change-Id: I5907362a6a5f508ca010a4dd24e877ca03d055f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6351778
Reviewed-by: Xiang Xiao <xiangxiao@google.com>
Commit-Queue: Eitan Goldberger <eitang@google.com>
Cr-Commit-Position: refs/heads/main@{#1432415}
