This makes it possible for the Annotator to only use a model compatible
with the Finch configured taxonomy (or return error if it cannot find
one), rather than potentially being inconsistent.
Bug: 1310951
Change-Id: I52c8bb17f3d2968ee8b4006264009192de02c588
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615000
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1158477}
Instead of relying on a specific method on a specific class, use a
OnceClosure instead to be more generic and in order to support different
task libraries.
Also has the benefit of no longer being templated so moves the impl to
its own cc file.
Bug: b/283522287
Change-Id: I6b3faa470b06330ac985a57d256a4dbd277e81ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615354
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1157836}
Avoid a spurious dangling ptr warning about an out-of-scope local by
ensuring that the SimpleTestClock, when used, outlives the HintsFetcher
which has an unowned reference back to it.
Bug: 1401495
Change-Id: I65e1193411bb53a2932cc2eea5218fa05e93cf8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4581155
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1152548}
The DanglingPointerDetector is configured only when the test enters the
ContentMain function. See https://crbug.com/1400059
I would like to configure it no matter the kind of test. For this to
happen, we need to annotate every pre-existing dangling pointers.
This patch annotates the ones you can find by running targets depending
on the GoogleTest library.
Statistic:
This adds 1776 new DanglingUntriaged. Among them:
- 1288 are in unittests.
- 488 are in implementation.
To produce those numbers, I used the command:
```bash
git diff annotate-linux origin/main -- "*test*" | grep "DanglingUntriaged" | wc -l
```
This patch has been generated by:
1. Apply the "auto-annotator" patch:
https://chromium-review.googlesource.com/c/chromium/src/+/4474553
2. Compile the compiler again:
```bash
./tools/clang/scripts/build.py
```
3. List and run all the targets. You can use a bash script like:
https://docs.google.com/document/d/1AMMERcqy0eafFWopUCHYsIKIKEp3J8DFxqW9UIbzIHo
4. Concatenate output, filter by "Found dangling ptr", sort, remove
duplicate.
5. Apply the rewriter script from:
https://github.com/ArthurSonzogni/chrome-dangling-ptr-apply-edit
6. Revert the "auto-annotate" patch.
7. Apply `git cl format`
AX-Relnotes: n/a.
Bug: chromium:1400059
Change-Id: I217d5c0b925da5176fc53baf95919a3690f1e9a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4570424
Reviewed-by: danakj <danakj@chromium.org>
Owners-Override: danakj <danakj@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1151859}
Segmentation server-side models need to be loaded from disk or
network before they can be executed. Right now RequestDispatcher
doesn't take this into consideration when enqueueing requests, so they
may get dispatched before their model is ready.
This CL modifies RequestDispatcher to keep a list of models that
are yet to be loaded, and enqueues all requests that involve
those models. It also adds an OnModelUpdated listener to RequestDispatcher, this gets called when a model gets loaded or
updated and it's used to dispatch all requests for the model that is
ready.
There's also a timeout in case a model takes too long to load, or
when there's no model available.
Bug: 1443066
Change-Id: Ic551b6af61bfb946db09698b4485bb516de6ee42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4467213
Reviewed-by: Ritika Gupta <ritikagup@google.com>
Auto-Submit: Salvador Guerrero Ramos <salg@google.com>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Commit-Queue: Salvador Guerrero Ramos <salg@google.com>
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1140923}
Makes a separate function for the batch functionality, doing so most of
the way down the call stack, so that all the calling code does not need
to be changed.
Bug: b/280623337
Change-Id: Ica0bdc665dd7f18aaa4d038551fe962e16ca5f21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4504748
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1140271}
We are currently merging a CL that checks for dangling ptrs at exit, and
those pointers were detected to be dangling at exit
(crrev.com/c/4345458).
This new dangling ptrs check will help diagnose PartitionAlloc
quarantine memory bloat.
Bug: 1291138
Change-Id: Ic2f4be013e1e944c8211effa9ee745755661948f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4501235
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Owners-Override: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Paul Semel <paulsemel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1139622}
`base::GUID` has been renamed, and is set to be removed. This CL is
part of a batch of changes replacing all uses of `base::GUID`, with
`base::Uuid`, and its associated counterparts.
Additionally, deprecated functions in `base/uuid.h` are also also having
their uses removed wherever they occur.
Changes for path: /components/optimization_guide/core
This CL was uploaded by git cl split.
Bug: 1428566
Change-Id: Idd6978e8262f6ce461b6c62dfe95c291728424dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4430101
Auto-Submit: Claudio DeSouza <cdesouza@igalia.com>
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1132533}
`base::GUID` has been renamed, and is set to be removed. This CL is
part of a batch of changes replacing all uses of `base::GUID`, with
`base::Uuid`, and its associated counterparts.
Changes for path: /components/optimization_guide/core
This CL was uploaded by git cl split.
R=rajendrant@chromium.org
Bug: 1428566
Change-Id: I5cb2ecf92f93f015fecbd3b4bfa77c3b7da1f84d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4396047
Reviewed-by: Raj T <rajendrant@chromium.org>
Auto-Submit: Claudio DeSouza <cdesouza@igalia.com>
Commit-Queue: Raj T <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1125662}
We started with `image_service` but multiple reviewers have complained
that this is too generic of a name.
We settled on `page_image_service` to clarify that this provides an
image relevant to a specific page.
We rejected a bunch of other names so please let's not relitigate it.
This CL is a pure directory and namespace rename. I didn't even rename
the C++ classes yet, because my goal was to keep this as mechanical and
easily reviewable as possible.
Bug: b/244507194, 1367485, b/248367751
Change-Id: I52126f24c12757225a01c0ad0cee24b2f6435226
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4376804
Owners-Override: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1123921}
Add RAW_PTR_EXCLUSION to files in components/ where the rewriter could not automatically rewrite.
Change was generated by processing the output of the rewriter.
Bug: 1273182
Change-Id: I4d75a27f1f634f9ed7636abb113ca9e6a8b0fb49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4170101
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Owners-Override: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Bartek Nowierski <bartekn@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1121633}
