Lukasz Anforowicz
8174ee0645
[rust] Add more UNSAFE_RUST_OWNERS + tweak related documentation.
...
Bug: 393410747
Change-Id: I10f8c71f40f001d25a4a1a3c746d112da5ba22b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6279505
Reviewed-by: Liza Burakova <liza@chromium.org >
Reviewed-by: Dustin Mitchell <djmitche@chromium.org >
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org >
Reviewed-by: Jonathan Hao <phao@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1422092}
2025-02-19 11:07:58 -08:00
Lukasz Anforowicz
4a54ad01b7
Add Chromium side of chrome-unsafe-rust-reviews@google.com gwsw setup.
...
Bug: 393410747
Change-Id: I7bbbc5ec81116004f05cf6979b6b96e4d4afd0b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6219726
Reviewed-by: Daniel Cheng <dcheng@chromium.org >
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1415239}
2025-02-03 15:25:45 -08:00
Lukasz Anforowicz
a80ca4b98c
Introduce tools/crates/create_draft_comments.py to streamline reviews.
...
The new script looks at all files touched by the current git branch and
for all occurrences of the `unsafe` keyword it automatically creates a
draft code review comment on Gerrit saying: "TODO: `unsafe` review".
Fixed: 328789397
Change-Id: I19c09a3453fd634b6f87e697a9e5eec211c8f9cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5836753
Reviewed-by: danakj <danakj@chromium.org >
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1352314}
2024-09-06 21:55:09 +00:00
Lukasz Anforowicz
3f6638ccf3
Link to docs/rust-unsafe.md from third_party/rust/PRESUBMIT.py failures.
...
Bug: None
Change-Id: I1b990742a5ca42efac297a98661e09da504fb6f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5812206
Reviewed-by: Adrian Taylor <adetaylor@chromium.org >
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1347456}
2024-08-27 17:17:48 +00:00
Lukasz Anforowicz
85e0a3580f
Clarify that supply-chain/config.toml provides *minimum* requirements.
...
Bug: 40221377
Change-Id: I8e7bc7f94a614ec6672e41c7cf351d9abd1d0116
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5459984
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org >
Reviewed-by: danakj <danakj@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1290013}
2024-04-19 17:07:48 +00:00
Lukasz Anforowicz
786b43924b
Verify cargo vet cleaniness in third_party/rust/PRESUBMIT.py.
...
Example presubmit failure (after manually, temporarily deleting parts of
`//third_party/rust/chromium_crates_io/supply-chain/audits.toml`):
```
$ git cl presubmit --force
Running Python 3 presubmit commit checks ...
checking owners took a long time: 0.6s
checking for commit objects in tree took a long time: 0.6s
** Presubmit Warnings: 1 **
//tools/crates/run_cargo_vet.py check
vpython3 /usr/local/google/home/lukasza/src/chromium2/src/third_party/rust/../../tools/crates/run_cargo_vet.py check --locked --frozen --no-minimize-exemptions (0.30s) failed
Vetting Failed!
2 unvetted dependencies:
unicode-width:0.1.11 missing ["safe-to-run", "does-not-implement-crypto"]
wycheproof:0.4.0 missing ["safe-to-run", "does-not-implement-crypto"]
Running cargo -Zunstable-options -C /usr/local/google/home/lukasza/src/chromium2/src/tools/crates/../../third_party/rust/chromium_crates_io vet check --locked --frozen --no-minimize-exemptions --cargo-arg=-Zbindeps --no-registry-suggestions
Failed.
Presubmit checks took 5.3s to calculate.
There were Python 3 presubmit warnings.
```
Bug: 326234536
Change-Id: I09040d6dce8900b43a7002cad11439572432feae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5388131
Reviewed-by: danakj <danakj@chromium.org >
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1277673}
2024-03-25 15:41:36 +00:00
Lukasz Anforowicz
0aa1dcf440
Tweak docs to no longer ask for manual installation of cargo vet.
...
I tested that after https://crrev.com/c/5366668 landed
`//tools/crates/run_cargo_vet.py` works (using
`//third_party/rust-toolchain/bin/cargo-vet`) without requiring an
explicit installation step (I've verified that `locate` doesn't find any
other `cargo-vet` binaries on my machine).
Based on the above, this CL removes docs that ask for a separate
installation step for `cargo vet`.
Bug: 326234536
Change-Id: I8015fe700c5cc477d340e9205031b0bd533c1e10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5387733
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org >
Reviewed-by: danakj <danakj@chromium.org >
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org >
Commit-Queue: danakj <danakj@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1276978}
2024-03-22 17:54:44 +00:00
Lukasz Anforowicz
df3d5af149
Fix links and anchors related to rust-unsafe.md
...
Bug: 326234536
Change-Id: Iabd2a11981d8181869981842d1cc9281d70112ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5383667
Reviewed-by: danakj <danakj@chromium.org >
Commit-Queue: danakj <danakj@chromium.org >
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1275727}
2024-03-20 18:21:16 +00:00
Lukasz Anforowicz
652bf4a4a1
Adding docs/rust-unsafe.md.
...
Bug: 326234536
Change-Id: If63b1530bfc6b56a45dd58411e2f4f12c8b09b1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5380787
Reviewed-by: Adrian Taylor <adetaylor@chromium.org >
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org >
Reviewed-by: danakj <danakj@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1275651}
2024-03-20 16:48:29 +00:00
