0
Commit Graph

33560 Commits

Author SHA1 Message Date
Dave Tapuska
d9e8555fbc [ios blink] Skip AutofillAcrossIframesTest
AutofillAcrossIframesTest.SubmitMultiFrameForm_XHR was constantly
failing. Mark it in the filter as such.

Change-Id: I434e4933156f73b6efd5a771b57e4dbd355a999c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6382461
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1436266}
2025-03-21 13:46:51 -07:00
Pier-Alexandre Bouchard
37a24ce6a6 [iOS] - Field trial testing for Tailored Non Modal DB Promo
Field trial testing for Tailored NON Modal DB Promo.

Bug: 401276624
Change-Id: I0578cc60d2c61eb3e1ddf1da9a26b49c4bf7ace6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6383179
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Pier-Alexandre Bouchard <pabouchard@google.com>
Cr-Commit-Position: refs/heads/main@{#1436251}
2025-03-21 13:25:49 -07:00
Kevin Graney
18a8b1c914 Remove launched field trial testing config
Bug: 389115996
Change-Id: I548cdefd0fea90176a5da07313ced444096f8358
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6381653
Reviewed-by: Alvin Lam <alvingo@google.com>
Auto-Submit: Kevin Graney <kmg@google.com>
Commit-Queue: Alvin Lam <alvingo@google.com>
Cr-Commit-Position: refs/heads/main@{#1436222}
2025-03-21 12:14:06 -07:00
Orko Garai
a0ae7c7339 [ozone/wayland] mutter: Fix crash in pointer lock tests
Update mutter to include fix for
`FullscreenControllerInteractiveTest.*PointerLock*` tests:
https://crrev.com/c/6378328

Bug: 391903220
Change-Id: I7cfd28cdf54c00f1fdc39e6aee06f43896408a3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6378227
Reviewed-by: Nick Yamane <nickdiego@igalia.com>
Commit-Queue: Orko Garai <orko@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1436218}
2025-03-21 12:11:38 -07:00
Anthi Orfanou
1c284a8906 Enable Local approval experiment in field trial config for iOS
Update EG tests for the new default configuration.

Bug: 390351579
Change-Id: Ifc4853803e477917f57005bb2fb600cd357b3318
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6377485
Auto-Submit: Anthi Orfanou <anthie@google.com>
Commit-Queue: Anthi Orfanou <anthie@google.com>
Reviewed-by: Duong Dac <ddac@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1436171}
2025-03-21 11:21:26 -07:00
Tim Judkins
2e9db067e7 [Extensions] Delete Webstore inlineinstall JSON API usage
The replacement for this (the item snippets API) was rolled out behind a
feature (UseItemSnippetsAPI) which was made default in M132:
https://chromiumdash.appspot.com/commit/9af72732bc3b5c63f2d815ac152ff68079988dce

At this point we can remove the feature along with the entire alternate
code path and all the related code.

Bug: 325314721
Change-Id: Ib18f934f51bc2fae588b145060fc226564056efa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6363316
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
Commit-Queue: Tim <tjudkins@chromium.org>
Reviewed-by: Edman Anjos <edman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1436145}
2025-03-21 10:43:15 -07:00
Nafis Abedin
cd2c66d013 Remove fieldtrial for
BatteryStatusAndPowerSavingBroadcastReceiversInBackground.

Bug: 376251730
Change-Id: I1a9d2716befb9d56d8edbfeb88545e0940254729
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6362814
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Nafis Abedin <nafisabedin@google.com>
Cr-Commit-Position: refs/heads/main@{#1436140}
2025-03-21 10:36:55 -07:00
Orko Garai
b902e8d890 CrActionMenu [auto-reposition] test: Fix for 1920x1200 resolution
Prevent text wrapping in menu item and failing the test on display
resolution of 1920x1200.

Fixed: 405130218
Bug: 391903220
Change-Id: Ib05d167119273f0531e0cf99418e0f9845eb0a4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6377703
Reviewed-by: John Lee <johntlee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Orko Garai <orko@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1436131}
2025-03-21 10:26:58 -07:00
Orko Garai
30975045b7 ozone/wayland: Tab drag interactive ui test fixes for mutter
Update mutter to include fixes made on the compositor side:
https://crrev.com/c/6318620 https://crrev.com/c/6371819

Add a couple fixes to tab_drag_controller_interactive_uitest.cc:
- Prevent `BrowserChangeWaiter` from not running the closure in case
quit is called another time before the closure gets to run.
- In `DragAllToSeparateWindow` add a similar step as
`DragToSeparateWindow` to ensure the tabs are dragged to the end of the
tab strip.

Use 1920x1200 display size in xvfb.py when running tests with mutter.
This ensures the tab drag tests request a valid size which is more than
the minimum size of a chrome window.

Update the test filter based on tests that are now passing with the
mutter changes, and add 2 new exclusions for tests that are flaky or
broken on mutter.

See the attached bug for more details.

Bug: 391907155

Change-Id: Ieb46a7209adfcd2a11ff04e8cb738b71b6c3e34a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6310437
Reviewed-by: David Pennington <dpenning@chromium.org>
Reviewed-by: Max Ihlenfeldt <max@igalia.com>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Orko Garai <orko@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1436130}
2025-03-21 10:26:42 -07:00
Brian Sheedy
b10e844730 Support full wildcards in UPF code
Updates the unexpected finder code and all of its users to support
full wildcards in expectations. Whether this or the older, trailing-only
wildcards are used is determined by the typ code being added in
crrev.com/c/6340368.

This should not result in any functional changes unless an
expectation file specifies full_wildcard_support: true.

Bug: 377660080
Change-Id: Iad2646a2afca8aeb7a56aa8b6060cc372495562a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6349402
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1436119}
2025-03-21 10:03:34 -07:00
Christian Xu
5c8619c567 [iOS][LO] Add fieldtrial config for escape hatch
Bug: None
Change-Id: Ic31cb90417423fa7a48a7ad4c1ab0d1d3b8bc157
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6382079
Commit-Queue: Christian Xu <christianxu@chromium.org>
Reviewed-by: Ameur Hosni <ameurhosni@google.com>
Commit-Queue: Ameur Hosni <ameurhosni@google.com>
Auto-Submit: Christian Xu <christianxu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1436043}
2025-03-21 07:58:47 -07:00
Marc Treib
59cf27800b Update fieldtrial config for IdentityDiscAccountMenu2
Specifically, remove a feature param that we've decided not to go with
after all.

Bug: 331781927
Change-Id: I9e2e36b279d6af4dbdbe5fa7654b89bcc2f32678
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6382097
Auto-Submit: Marc Treib <treib@chromium.org>
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/main@{#1436036}
2025-03-21 07:51:48 -07:00
Zauri Meshveliani
94b8a91bf9 cros-geo-apikey: Create a feature flag
Create a new feature flag - `CrosGeoApiKey`. Behind this flag will be
developed the changes to migrate ChromeOS system services and
Chrome-on-ChromeOS to use a different GCP endpoint for location
resolution.

For more details go/new-api-keys-for-cros-geo.

Bug: 403537535
Change-Id: I0fac327f97ee47f5e97669144c6bab75e88e2d65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6355829
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Zauri Meshveliani <zauri@chromium.org>
Auto-Submit: Zauri Meshveliani <zauri@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1436027}
2025-03-21 07:34:48 -07:00
Andreas Haas
f1e6e47f85 [fuzzilli] Generate profile code for fast codes
This CL adds ProgramTemplates to the generated `ChromiumProfile.swift`
for fuzzilli to test specifically APIs called with the V8 fast API.

Bug: 41492790
Change-Id: Ia0e34e526ea679eac7c3e60109f8300ef35e03c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6366774
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Reviewed-by: Paul Semel <paulsemel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1435940}
2025-03-21 03:55:06 -07:00
Christian Xu
14b576f32a [iOS] Add fieldtrial testing config for dense text
Bug: None
Change-Id: I4d0dfc419908ac40cf812baf6690332e2e6b0125
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6377345
Auto-Submit: Christian Xu <christianxu@chromium.org>
Reviewed-by: Ameur Hosni <ameurhosni@google.com>
Commit-Queue: Ameur Hosni <ameurhosni@google.com>
Cr-Commit-Position: refs/heads/main@{#1435915}
2025-03-21 02:15:53 -07:00
Darren Shen
68fc9192d6 Revert "Add field trial testing config for Pinweaver Passwords"
This reverts commit 775d40a9e7.

Reason for revert: Causing some cryptohome Tast test failures

Original change's description:
> Add field trial testing config for Pinweaver Passwords
>
> Bug=b:391427550
>
> Change-Id: I13081d456ba33e6970f23c0a7f65052c7348c1d4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6349775
> Commit-Queue: John Admanski <jadmanski@chromium.org>
> Reviewed-by: Hardik Goyal <hardikgoyal@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1435657}

Bug: b:391427550,b:405223352
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I4b1983cab66a7ef50cf0290fd829ddb0fda2bd7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6379583
Auto-Submit: Darren Shen <shend@chromium.org>
Owners-Override: Darren Shen <shend@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Darren Shen <shend@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1435829}
2025-03-20 19:41:19 -07:00
Lauren Winston
b04d44d0b1 Fix fieldtrial typo
Bug:401364337

Change-Id: I7b086e9388f1331859075c0998ccb789cc807eea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6378585
Auto-Submit: Lauren Winston <lwinston@google.com>
Reviewed-by: Kristi Saney <kristislee@google.com>
Commit-Queue: Lauren Winston <lwinston@google.com>
Commit-Queue: Kristi Saney <kristislee@google.com>
Cr-Commit-Position: refs/heads/main@{#1435764}
2025-03-20 16:36:59 -07:00
Xianzhu Wang
cad4283ec0 Enable RasterInducingScroll on Linux and Windows by default
Bug: 40517276
Change-Id: I5abcbb84bce2be309a9fd1a8e1b5baa21646a172
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6378785
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1435757}
2025-03-20 16:26:37 -07:00
Orko Garai
4429a1aef6 [ozone/wayland] mutter: Enable tests failing due to local env
Re-enable tests that can fail only if run locally on gnome shell which
triggers the dark mode listener that can interfere with these tests.
These should pass if running mutter in an isolated environment, e.g. on
CI bots.

More details: https://issues.chromium.org/issues/391903220#comment3

Bug: 391903220
Change-Id: I862e2ac8ff9e53736c1b1eb7cd0c8023f8940d72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6378225
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Reviewed-by: Nick Yamane <nickdiego@igalia.com>
Auto-Submit: Orko Garai <orko@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1435754}
2025-03-20 16:19:13 -07:00
Lauren Winston
f40d5548a0 [Read aloud] Add field trial testing config for migration.
This will include the component updater migration and
necessary migrations on the TTS engine side.

Bug: 401364337
Change-Id: I336c2935b980cb8ddc5f7d0d64ffd8792d220389
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6376832
Commit-Queue: Lauren Winston <lwinston@google.com>
Reviewed-by: Xiang Xiao <xiangxiao@google.com>
Cr-Commit-Position: refs/heads/main@{#1435725}
2025-03-20 15:26:14 -07:00
luci-bisection@appspot.gserviceaccount.com
bebf8fc465 Revert "Add RendererSideContentDecoding in fieldtrial_testing_config.json"
This reverts commit ec7050fae5.

Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5769937554505728

Sample build with failed test: https://ci.chromium.org/b/8719899067407447905
Affected test(s):
[ninja://chrome/test:telemetry_gpu_integration_test/gpu_tests.webgpu_cts_integration_test.WebGpuCtsIntegrationTest.webgpu:web_platform,worker,worker:service_worker:](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchrome%2Ftest:telemetry_gpu_integration_test%2Fgpu_tests.webgpu_cts_integration_test.WebGpuCtsIntegrationTest.webgpu:web_platform%2Cworker%2Cworker:service_worker:?q=VHash%3A20fed57c3b37d1cc)

If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5769937554505728&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6367559&type=BUG

Original change's description:
> Add RendererSideContentDecoding in fieldtrial_testing_config.json
>
> Bug: 391950057
> Change-Id: Ief86f51efa3c9c0e292615260f0526d4e07d5834
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6367559
> Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
> Reviewed-by: Adam Rice <ricea@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1435252}
>

Bug: 391950057
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I6e4679d2a1038aa721c31228d608a35fdf233f4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6375343
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Renato Silva <rrsilva@google.com>
Cr-Commit-Position: refs/heads/main@{#1435716}
2025-03-20 15:07:51 -07:00
John Admanski
775d40a9e7 Add field trial testing config for Pinweaver Passwords
Bug=b:391427550

Change-Id: I13081d456ba33e6970f23c0a7f65052c7348c1d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6349775
Commit-Queue: John Admanski <jadmanski@chromium.org>
Reviewed-by: Hardik Goyal <hardikgoyal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1435657}
2025-03-20 13:38:25 -07:00
Peilin Wang
ae5f434d18 [BCIV] Enable AndroidBCIVBottomControls in fieldtrials
Bug: 399466654
Change-Id: If3485cd647ae14fae726292532279357dab56fc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6349056
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Peilin Wang <peilinwang@google.com>
Cr-Commit-Position: refs/heads/main@{#1435644}
2025-03-20 13:21:01 -07:00
Jack Hsieh
c7b347fe44 Update field trial testing config for WinPlatformLocationProvider
Update the field trial testing config for WinPlatformLocationProvider to
include enabling feature WinSystemLocationPermission and remove config
for WinSystemLocationPermission study.

Change-Id: Ie0befcedc199f91a77db37666983adb62f17d674
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6377982
Commit-Queue: Jack Hsieh <chengweih@chromium.org>
Reviewed-by: Alvin Ji <alvinji@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1435619}
2025-03-20 12:42:59 -07:00
Xianzhu Wang
5427e1b2a9 Update fieldtrail testing config for ExpandCompositedCullRect
To prepare for:
- stopping LargeChangedEnough experiment;
- expanding 2333 experiment on Android stable.

Bug: 361344221
Change-Id: Ica482ea27ab3016389a0d33d51be027c54dcdf30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6378123
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1435604}
2025-03-20 12:24:24 -07:00
Hira Mahmood
e2e8bfb967 [iOS] Enable Set Up List features by default
This CL enables kSetUpListShortenedDuration and
kSetUpListWithoutSignInItem by default, removes the fieldtrial configs,
and removes/fixes no longer relevant unit tests.

Bug: 383567901, 383566934
Change-Id: Idb299eab3c525be34e15f3824d06437265c21a79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6373544
Reviewed-by: Scott Yoder <scottyoder@google.com>
Commit-Queue: Hira Mahmood <hiramahmood@google.com>
Cr-Commit-Position: refs/heads/main@{#1435568}
2025-03-20 11:21:28 -07:00
Zhenyao Mo
a1f99081a5 [TreesInViz] Send LayerTreeHostImpl::viewport_damage_rect_ to viz.
Without this, HasDamage() may return false and a frame may be
incorrectly skipped for drawing.

This fixed ~60 failing content_browsertests.

TEST=trees_in_viz bot

Bug: 404335731
Change-Id: Ic2d49ecc1c033cd02863f21a0f4700a16a9c5eb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6369927
Reviewed-by: Alex Gough <ajgo@chromium.org>
Auto-Submit: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Alex Gough <ajgo@chromium.org>
Reviewed-by: Victor Miura <vmiura@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1435567}
2025-03-20 11:20:26 -07:00
Norge Vizcay
2344d1fadb Remove unused feature AutofillGivePrecedenceToEmailOverUsername.
Change-Id: I18eb2217ee63b793f8801e1f1f5bc507181b0b90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6375212
Commit-Queue: Norge Vizcay <vizcay@google.com>
Reviewed-by: Karol Sygiet <sygiet@google.com>
Cr-Commit-Position: refs/heads/main@{#1435494}
2025-03-20 09:41:16 -07:00
Struan Shrimpton
def11e9193 autosharder: set limits on the calculated overhead
android_browsertests on android-x64-rel was not sharded enough due to a
bad overhead calculation. It looks like the suite was just stuck in an
unforunate set of shardings which made the overhead look far worse than
it really was (~10mins). To address cases like this, clamp the overhead
calculation to approximately the current min and max overheads. In the
long term we should use more than 1 shard configuration.

Bug: None
Change-Id: I5470efc7afcd6aeaa8a9cc28c09ec207cb3bb57c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6374266
Reviewed-by: Benjamin Joyce (Ben) <bjoyce@chromium.org>
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
Cr-Commit-Position: refs/heads/main@{#1435477}
2025-03-20 09:22:21 -07:00
Jan Keitel
4cde01bb24 Default enable select option and maxlength crowdsourcing
Permission was given in today's feature sync.

Bug: 393995180, 393999140
Change-Id: Ia44cdbe4353ae6c10bd090501351d462e089b94d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6375289
Reviewed-by: Christoph Schwering <schwering@google.com>
Commit-Queue: Christoph Schwering <schwering@google.com>
Auto-Submit: Jan Keitel <jkeitel@google.com>
Cr-Commit-Position: refs/heads/main@{#1435446}
2025-03-20 08:49:42 -07:00
Stacy Gaikovaia
03e8778564 Adding fyibot failing test to filter.
FYIbot flagged crrev.com/c/6362878 as
the culprit for this test.

Bug: 338977417
Change-Id: I366b76a6036f1255f2d7055cae93a121a7e776ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6376027
Commit-Queue: Stacy Gaikovaia <gaiko@google.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1435442}
2025-03-20 08:38:47 -07:00
Christian Xu
5a0cc6325f [iOS] Update chromnient fieldtrial
Bug: None
Change-Id: Ieb390a2c4851cc088c64302b57bd165310069a8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6376384
Commit-Queue: Ameur Hosni <ameurhosni@google.com>
Commit-Queue: Christian Xu <christianxu@chromium.org>
Reviewed-by: Ameur Hosni <ameurhosni@google.com>
Auto-Submit: Christian Xu <christianxu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1435430}
2025-03-20 08:26:17 -07:00
Amelie Schneider
4e467c54ac [B4B] Add tests for BookmarkEditorViewBrowserTestWithAccountBookmarks
Bug: 354892429
Change-Id: I2de9138ebab977c3245419edee97264748c647c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6367094
Reviewed-by: Ryan Sultanem <rsult@google.com>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Amelie Schneider <amelies@google.com>
Cr-Commit-Position: refs/heads/main@{#1435398}
2025-03-20 07:42:24 -07:00
anthie@google.com
8adab35730 Add field trial entry for Local approvals on Desktop
Bug: 390351579
Change-Id: I49e68c2f2a2916ecafef6aa27091673d4db78014
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6372682
Commit-Queue: Anthi Orfanou <anthie@google.com>
Reviewed-by: James Lee <ljjlee@google.com>
Cr-Commit-Position: refs/heads/main@{#1435330}
2025-03-20 04:31:30 -07:00
Christian Xu
c85cdbd929 [iOS] Update GRPC fieldtrial config
Update GRPC fieldtrial config for upcoming experiment.

Bug: None
Change-Id: I4467eebf22bd3185d11934ddc6b700828c04a56f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6375483
Reviewed-by: Ameur Hosni <ameurhosni@google.com>
Commit-Queue: Christian Xu <christianxu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1435326}
2025-03-20 04:11:21 -07:00
Victor Miura
5eb2cb8a7a [TreesInViz] Signal DisplayReceivedCompositorFrame from frame sink support
This change enables several cc_unittests that rely on
DisplayReceivedCompositorFrame to pass, and also exposes a few tests that
fail because of missing data in the produced frame. Issues have been
filed for the remaining failures.

Bug: 404941414
Change-Id: I804ab79fcafecf64dba8bc775167d6d804a43c7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6369932
Auto-Submit: Victor Miura <vmiura@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1435284}
2025-03-20 01:36:09 -07:00
Fiona Macintosh
63048f5e8a [RWS] Enable MVP UX feature in fieldtrial_testing_config
Setting the feature explicitly to true in the browsertest to prevent any
test failures in the event of a rollback

Bug: b:404860465
Change-Id: Ia8bcd2dbfa885c75cd006dd2619b2b338d428a56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6373889
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Auto-Submit: Fiona Macintosh <fmacintosh@google.com>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1435280}
2025-03-20 01:15:37 -07:00
Tsuyoshi Horo
ec7050fae5 Add RendererSideContentDecoding in fieldtrial_testing_config.json
Bug: 391950057
Change-Id: Ief86f51efa3c9c0e292615260f0526d4e07d5834
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6367559
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1435252}
2025-03-19 22:44:31 -07:00
Chengwei Hsieh
0beea42cd3 Add field trial testing config for WinPlatformLocationProvider
Add field trial testing config for enabling WinPlatformLocationProvider that is to use a new geolocation backend backed by the platform location provider on Windows.

Change-Id: Ide3005af1f83b62fda5f3e70db6580c4bd3a2295
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5891631
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Commit-Queue: Jack Hsieh <chengweih@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1435231}
2025-03-19 20:23:23 -07:00
Jacob Stanley
91b0062e67 Revert "[Ads API UX Enhancements] Enable feature by default"
This reverts commit 7e69a90263.

Reason for revert: We decided to let the experiment ramp up longer so our activations stabilize. Since there is still a default group in Stable, we don't want some users to have the default enabled feature until we are ready to fully launch.

Original change's description:
> [Ads API UX Enhancements] Enable feature by default
>
> Approved for 100% full launch
> https://launch.corp.google.com/launch/4353810
>
> Bug: 374098737
> Change-Id: Ic06beff006f68339b1f30bd12e348a939a9da6dc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6361976
> Auto-Submit: Jacob Stanley <jacobstanley@google.com>
> Reviewed-by: Abe Boujane <boujane@google.com>
> Commit-Queue: Abe Boujane <boujane@google.com>
> Cr-Commit-Position: refs/heads/main@{#1434117}

Bug: 374098737
Change-Id: I3d8beb89ab32fe78d8a93cafe49378171347a847
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6372703
Reviewed-by: Abe Boujane <boujane@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Jacob Stanley <jacobstanley@google.com>
Cr-Commit-Position: refs/heads/main@{#1435176}
2025-03-19 17:06:22 -07:00
Victor Miura
f1dc2fd849 [TreesInViz] Filter other failing cc_unittests
LayerTreeHostFiltersPixelTest.BackdropFilterBlurOutsets tests are failing
on some bots. Filter them for now.

Bug: 404813701
Change-Id: I2fa1761d78a73c4a87f0bc20ae180d1ef1b13e4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6371893
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Auto-Submit: Victor Miura <vmiura@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1435154}
2025-03-19 16:28:08 -07:00
Petr Cermak
a41e721a2d Add field trial config for UseFirstCoalescedFrameAsFlingGenerationTimestamp
Bug: 404464598
Change-Id: Id21b973cdef6aa8e18a2e82db58a5125da4ee7c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6372559
Auto-Submit: Petr Cermak <petrcermak@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1435085}
2025-03-19 14:11:53 -07:00
Victor Miura
78966ae049 [TreesInViz] Enable TreesInViz for unit tests that don't use layer lists
We were disabling TreesInViz mode for trees that don't use
'use_layer_lists' mode. The real intent was to disable TreesInViz for
UI.

This change enables TreesInViz for '!use_layer_lists' and excludes
'is_layer_tree_for_ui' instead.

Bug: 404813701
Change-Id: I45b4a1e2c65fa7bca503a86c1a48f50fca562227
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6371884
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Victor Miura <vmiura@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1435032}
2025-03-19 12:48:26 -07:00
Vishwas Uppoor
1f4ab6af32 [Offers] Remove flaky tests - 2
Offer notification flaky tests were filtered out in failing builds.
Remove the filters since the tests have been removed.

Bug: b/402163619
Change-Id: I15f55923c0146ff3786f177d4ab68514dde3dddd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6370984
Commit-Queue: Vishwas Uppoor <vishwasuppoor@google.com>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1435017}
2025-03-19 12:31:02 -07:00
Joe Mason
890090bdfc Pre-create DirectReceiver transports on Windows
Windows sandbox restrictions cause DirectReceiver's ThreadLocalNode to
crash in Transport::CreatePair. As a workaround create a transport for
the thread that's expected to use DirectReceiver before the sandbox
is locked down (which is still in single threaded context), and pass
it to ThreadLocalNode when it's assigned to the thread.

Bug: 40266729
Change-Id: Ic881eac9cf570d023a362b2cfc12f8234d706eb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6332336
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@google.com>
Cr-Commit-Position: refs/heads/main@{#1434954}
2025-03-19 11:14:08 -07:00
Ming-Ying Chung
1fea6037a2 Add owner for translatekit CI builder config
Bug: 394439535
Change-Id: I031bf9042753db769160356cd22425160b1a0d00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6367561
Auto-Submit: Ming-Ying Chung <mych@chromium.org>
Reviewed-by: Wanda Mora <morawand@google.com>
Commit-Queue: Wanda Mora <morawand@google.com>
Cr-Commit-Position: refs/heads/main@{#1434883}
2025-03-19 09:45:41 -07:00
Dominique Fauteux-Chapleau
44b41710e2 Clean up "EnableScreenshotProtection"
This CL cleans up EnableScreenshotProtection and also addresses
crbug.com/378132592 by cleaning up `IsDataProtectionEnabled()`.

The `SkipUrl()` call in `ApplyDataProtectionSettings()` is kept since
it's a static function that might be called even if a
`DataProtectionNavigationController` hasn't been initialized.

The `IsInPrimaryMainFrame()` call in `DidFinishNavigation()` is kept,
see the comment in that function for details.

Bug: 378132592
Change-Id: Iec133a4179ab27d58e09a2e1ae9d092bef72bba9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6361985
Reviewed-by: Caroline Rising <corising@chromium.org>
Reviewed-by: Nasser Al-shawwa <alshawwa@chromium.org>
Auto-Submit: Dominique Fauteux-Chapleau <domfc@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1434872}
2025-03-19 09:37:43 -07:00
Darryl Pogue
16fc10c12b [WebView] Include system bars in safe-area insets
For the Android WebView to properly handle edge-to-edge mode, the
safe-area-inset values need to account for not only the display cutout
but also the system bars.

Bug: 40699457
Change-Id: I68f6e541b55ff0909f690511e6ac80409ed9faf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6295663
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Richard (Torne) Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1434844}
2025-03-19 08:58:20 -07:00
Keita Suzuki
454f545845 Update fieldtrial_testing_config for PreconnectfromKeyedService
This CL adds the config for `PreconnectfromKeyedService` feature in the
fieldtrial_testing_config.

Bug: 394204688
Change-Id: Ib079e3f1689d03894813e3ed7a7a550a38aa6595
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6367896
Commit-Queue: Keita Suzuki <suzukikeita@chromium.org>
Reviewed-by: Shunya Shishido <sisidovski@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1434823}
2025-03-19 08:29:10 -07:00
Christine Ying
d13a1a0c5e Reland "[N&C] Add field trial config for the schema v2 migration"
This is a reland of commit 9f87836336

Fixed the issue with https://chromium-review.googlesource.com/c/chromium/src/+/6369376

https://ci.chromium.org/ui/inv/u-chrstne-2025-03-18-19-22-00-b9bde8c906e2bb94 <- successful new run.

Original change's description:
> [N&C] Add field trial config for the schema v2 migration
>
> Change-Id: I979b1d5266e30a96b686c219a7a8e68288f939db
> Bug: 392088228
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6368014
> Reviewed-by: Abe Boujane <boujane@google.com>
> Commit-Queue: Christine Ying <chrstne@google.com>
> Cr-Commit-Position: refs/heads/main@{#1434135}

Bug: 392088228
Change-Id: I39dbb2d8dfc049480e371babbdb1c6dba7c0e4d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6372939
Reviewed-by: Abe Boujane <boujane@google.com>
Commit-Queue: Christine Ying <chrstne@google.com>
Cr-Commit-Position: refs/heads/main@{#1434811}
2025-03-19 08:19:43 -07:00