Makes new "unit_tests" targets for core and modules, reference these from webkit_unit_tests and delete the associated .gypi and .gni machinery.
Move all web file lists from .gypis to the GN build and remove web.gypi
Review-Url: https://codereview.chromium.org/2294893002
Cr-Commit-Position: refs/heads/master@{#415403}
Previously the views unit tests duplicated sources between views_unittests and views_mus_unittests. This puts the sources in one target and shares the compiles between both test suites.
Review-Url: https://codereview.chromium.org/2291803002
Cr-Commit-Position: refs/heads/master@{#415402}
This speeds up seek and suspend significantly in the case of a hung
read; on slow networks this may shave hundreds of milliseconds or more
off the seek and suspend times.
Notably this also resolves a CHECK() crash for overlapping reads
by aborting any existing reads when a new read comes in.
Note: Also removes some log spam from canceled reads / tests.
BUG=165762,638018
TEST=manual, new unittests
Review-Url: https://codereview.chromium.org/2267963002
Cr-Commit-Position: refs/heads/master@{#415401}
This change removes the top level android directory from dom_distiller
and splits it into content/browser/android and core/android. The two
directories now each have their own JNI registrar that allows them to
depend on appropriate parts of the component.
BUG=562769
TBR=yfriedman@chromium.org
Review-Url: https://codereview.chromium.org/2252963004
Cr-Commit-Position: refs/heads/master@{#415400}
This CL adds a member to FeedbackInfo which instructs the feedback dialog
to use native window controls and implements support for it in the
feedback dialog's JS.
BUG=553991
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2295793002
Cr-Commit-Position: refs/heads/master@{#415396}
To permit reusing portions of ash/display in both mus and ash, we need
to move some code to ui. Start this process by relocating
ash/common/display/display_info.* as it is the root of the inclusion
dependency tree.
BUG=581462
Review-Url: https://codereview.chromium.org/2270553002
Cr-Commit-Position: refs/heads/master@{#415395}
Also updates a bunch of strings.
BUG=622922
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2280233002
Cr-Commit-Position: refs/heads/master@{#415394}
SVGSMILElement adds a reference to its target, and any instances of the
target should never be mutated, so the registration of reference to the
extended target element set in SVGAnimateElement::resetAnimatedType does
not add any value.
BUG=640676
Review-Url: https://codereview.chromium.org/2292983002
Cr-Commit-Position: refs/heads/master@{#415393}
This picks up a change that will help address flaky telemetry failures.
This includes the following changes (v0.9.5..v0.9.7):
79fe79db Change typ's interpretation of a test that first fails
and is then skipped.
101acd31 Bump version to 0.9.6, clean up Python 3 failures
2f8787b8 rework run script to remove python3 log
d5023636 rework sharding tests
TBR=rnephew@chromium.org, nednguyen@google.com
BUG=618330
Review-Url: https://codereview.chromium.org/2289303002
Cr-Commit-Position: refs/heads/master@{#415392}
Instead of guessing what *would* have been the OS X version constant for
a version our SDK doesn't even support and then asserting when we're
wrong, just skip the check when it doesn't matter.
BUG=636093
Review-Url: https://codereview.chromium.org/2289173002
Cr-Commit-Position: refs/heads/master@{#415391}
skia::GetTopDevice() gets removed from our public API.
SK_API also removed from a couple of classes we don't want used.
R=fmalita@chromium.org
BUG=543755
Review-Url: https://codereview.chromium.org/2294813002
Cr-Commit-Position: refs/heads/master@{#415387}
The browser process used to record subresources that were loaded with
certificate errors as mixed content. This meant that DevTools wasn't
able to distinguish mixed content (subresources loaded over HTTP) from
subresources loaded with certificate errors. On a page that loaded
subresources with certificate errors, DevTools would show the mixed
content explanation, which was confusing/inaccurate because it described
"HTTP resources".
The commits in https://crbug.com/634171 created separate plumbing in the
browser process for subresources with certificate errors. This CL uses
that plumbing to distinguish these two cases for DevTools, and adds
separate bullets to the security panel when there are subresources with
cert errors on the page.
I have also renamed various instances of "insecure content" to "mixed
content" to be more precise: trying to use "insecure content" to mean
any type of insecure content, and "mixed content" to mean specifically
content loaded over HTTP on an HTTPS page. (There are still some more
places throughout Chrome that need to be cleaned up with this
terminology.)
(For subresources with cert errors, there is no link to the Network
panel with a filter like there is for mixed content; we can perhaps add
that later.)
BUG=587172
Review-Url: https://codereview.chromium.org/2286553002
Cr-Commit-Position: refs/heads/master@{#415383}
We only want to record this reason if it's the only scroll reason (as it
obscures others).
BUG=None
Review-Url: https://codereview.chromium.org/2289593006
Cr-Commit-Position: refs/heads/master@{#415382}
I move creation to RootWindowControllerCommon, but I think
RootWindowControllerCommon should go away. I'm going to do that next,
which will result in some additional cleanup.
BUG=624173
TEST=covered by tests
R=msw@chromium.org
Review-Url: https://codereview.chromium.org/2292183003
Cr-Commit-Position: refs/heads/master@{#415374}
Currently when screen is off (or Chrome goes to background) for more than 1 min,
peerconnection will be stoppted by PowerMonitor to save battery power. This is
not necesary now since we'll suspend video call when the tab is background. And
users prefer that audio call can continue while they are doing something else.
BUG=513633
Review-Url: https://codereview.chromium.org/2263373003
Cr-Commit-Position: refs/heads/master@{#415372}
ViewMsg_ThemeChanged was never sent, and even if it was, the only code
path that did anything was
#if USE_AURA
// nothing
#elif OS_WIN
// do stuff
...
so it was never going to run. Noticed while trying to clean up
NativeThemeWin usage from Blink, which also makes little-to-no sense and
causes the linked bug.
R=jam@chromium.org
BUG=258201
Review-Url: https://codereview.chromium.org/2287813002
Cr-Commit-Position: refs/heads/master@{#415371}
When the sizes attribute changes, that has the potential of modifying the
image's intrinsic dimensions. However, the LayoutImage object was not
notified of that explicitly. While the intrinsic dimensions were changed
when a new resource was downloaded as a result of the sizes attribute
change, that wasn't the case when such the resource was not changed.
This CL fixes that, by explicitly notifying the LayoutImage of the change.
BUG=639845
Review-Url: https://codereview.chromium.org/2292013002
Cr-Commit-Position: refs/heads/master@{#415369}
The Blimp browser tests now cover every action of NavigationFeature.
GoForward is an additional step in the existing GoBack test, rather than a new test, because you can't test GoForward without GoBack.
Also adds no-op behavior on the engine for when the client requests GoBack or GoForward but those operations aren't valid, and tests for those cases.
Tested log output for the invalid GoBack and GoForward cases with the following:
blimp_browsertests --single_process --gtest_filter=EngineBrowserTest.InvalidGoBack | grep Ignoring
blimp_browsertests --single_process --gtest_filter=EngineBrowserTest.InvalidGoForward | grep Ignoring
BUG=
Review-Url: https://codereview.chromium.org/2295543002
Cr-Commit-Position: refs/heads/master@{#415368}
Use methods which returns id instead of deprecated methods which return
NSString. JS execution API returned NSString because that was the only
supported option from UIWebView. Now WKWebView returns id which should
be used everywhere.
BUG=None
Review-Url: https://codereview.chromium.org/2286773002
Cr-Commit-Position: refs/heads/master@{#415367}
The goal is to let Blimp reuse this logic on browser process, since
Blimp client doesn't have renderer process.
BUG=577985
Review-Url: https://codereview.chromium.org/2285083004
Cr-Commit-Position: refs/heads/master@{#415366}
On UI, the text for installing a WebAPK in the App Banner is:
1) "Add to Homescreen" -> "Adding" -> "Open" for a sucessful
installation
2) "Add to Homescreen" -> "Adding" -> "Unable to save" toast
for an unsucessful installation.
WebAPK-specific logic is added to AppBannerInfobarDelegateAndroid
to show the above text. Besides, checking whether a site is WebAPK
Compattive is based on 1) installable check + 2) url is over
"https" + 3) WebAPK is enabled on command line.
Currently, WebAPK is installed as an untrusted source with Android
installation dialog pops up. User could choose cancel the installation
even after the WebAPK has been downloaded locally. To detect the
cancel behavior, AppBannerInfobarDelegateAndroid checks whether the
WebAPK has been installed or not after Chrome is resumed. This isn't an
ideal way, but it seems we can't find a better way to detect the cancel
event. This logic will be removed when WebAPK is installed by Play soon.
This CL disables creating WebAPKs by selecting add-to-homescreen from
the app menu. Instead, in a follow up CL, selecting from the app menu
will make the app banner info bar shown to install WebAPKs.
BUG=627250
Review-Url: https://codereview.chromium.org/2259553002
Cr-Commit-Position: refs/heads/master@{#415365}
This patch adds a new (currently failing) filter repaint test to show
how we improperly repaint turbulence filters. In addition, the existing
test for 640264 has been unskipped and rebaselined with a failing
result. These two changes should help catch progressions in the future.
BUG=598051,640264
Review-Url: https://codereview.chromium.org/2294633002
Cr-Commit-Position: refs/heads/master@{#415363}
This directory has not been touched since 2008, appears to be from the very
early history of tracing, and contains only some very primitive trace examples.
The frontend tracing code lives in Catapult, so let's remove this dir.
Review-Url: https://codereview.chromium.org/2290393002
Cr-Commit-Position: refs/heads/master@{#415360}
