The canonical bug format is TODO(crbug.com/<id>). TODOs of the
following forms will all be migrated to the new format:
- TODO(crbug.com/<old id>)
- TODO(https://crbug.com/<old id>)
- TODO(crbug/<old id>)
- TODO(crbug/monorail/<old id>)
- TODO(<old id>)
- TODO(issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/u/1/issues/<old id>)
- TODO(bugs.chromium.org/<old id>)
Bug id mapping is sourced from go/chrome-on-buganizer-prod-issues.
See go/crbug-todo-migration for details.
#crbug-todo-migration
Bug: b/321899722
Change-Id: Iee14d10d544e9f0ec046117cc4ec8a55c427adc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5469947
Reviewed-by: Darryl James <dljames@chromium.org>
Owners-Override: Alison Gale <agale@chromium.org>
Commit-Queue: Alison Gale <agale@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290838}
The canonical bug format is TODO(crbug.com/<id>). TODOs of the
following forms will all be migrated to the new format:
- TODO(crbug.com/<old id>)
- TODO(https://crbug.com/<old id>)
- TODO(crbug/<old id>)
- TODO(crbug/monorail/<old id>)
- TODO(<old id>)
- TODO(issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/u/1/issues/<old id>)
- TODO(bugs.chromium.org/<old id>)
Bug id mapping is sourced from go/chrome-on-buganizer-prod-issues.
See go/crbug-todo-migration for details.
#crbug-todo-migration
Bug: b/321899722
Change-Id: Iabdfea2fd5393d6bbc54390ca0c995eb2c55bbaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5469882
Reviewed-by: Darryl James <dljames@chromium.org>
Owners-Override: Alison Gale <agale@chromium.org>
Commit-Queue: Alison Gale <agale@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290673}
This class is not a browsertest, and is also not related to
WebAppBrowserController, and web_app_controller doesn't exist, so its
name was misleading. The class is actually a base class for many web_app
browsertests, so the new name is more accurate and clear.
Purely mechanical rename. No functional changes.
POC for this CL: dmurph@ if glenrob@ is unavailable.
Change-Id: Iab371d751f59cb699b2211882b38f7aaa125d667
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5451671
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Auto-Submit: Glen Robertson <glenrob@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1287926}
The default behavior is not changed, but now developers have the option
to disable the chrome://web-app-internals logging on PWA browser tests
using the new flag.
Change-Id: I861450c60bed342eff2c3b6107b027c46fd1b73f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4781796
Commit-Queue: Zelin Liu <zelin@chromium.org>
Reviewed-by: Dibyajyoti Pal <dibyapal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1184238}
This CL restructures the flow of manifest update checking into the
following stages:
- Download new manifest data.
- Load existing manifest data.
- Compute manifest diffs.
- Resolve any identity updates (allow/confirm/revert).
Fine details of the restructuring are captured as inline comments
on the old code:
https://chromium-review.googlesource.com/c/chromium/src/+/4190417/21/chrome/browser/web_applications/commands/manifest_update_data_fetch_command.cc
This restructuring was motivated by:
- A bug in OEM apps not able to update their icons (but could if
other parts of the manifest changed as well).
- The organic growth that this code has been undergoing for the last
couple of years.
- The difficulty in following where identity update decisions were
being made.
- More identity updating logic to be added regarding icon URLs and
generated icon bitmaps during failed sync installation.
Bug: 1409710, 1402886
Change-Id: I6aaf5dd7b4101b2a15b81a0e05c7208275fbddd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4190417
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Dibyajyoti Pal <dibyapal@chromium.org>
Reviewed-by: Glen Robertson <glenrob@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1111395}
This change greatly increases the debugability of command code & tests
in the WebAppProvider by adding 'scheduled locations' to the command,
which stores the location the command was scheduled from, and
'requested location' to the lock manager, allowing us to print out when
other lock requesters are holding a lock we are trying to acquire.
This information is added to the chrome://web-app-internals page
through the debug output of the commands, as well as in DVLOGs from
the web_app_command_manager.cc and the web_app_lock_manager.cc.
Finally, the README.md is updated to include more information about
debugging and these DVLOGs.
Screenshot of chrome://web-app-internals:
https://screenshot.googleplex.com/Bs8zKeDvMMnXHwh.png
Change-Id: Ie1db59487edded65a1f5427b5b7f58746a0a6f92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4278664
Reviewed-by: Dibyajyoti Pal <dibyapal@chromium.org>
Reviewed-by: Camden King <camdenking@google.com>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1109093}
This is essentially a revert of crrev.com/4051065. The explicit check
during installation landed in https://crrev.com/c/4173793.
For reference, as documented in the design doc [1], we only want to
check signatures during installation on ChromeOS, and not during every
Chrome session.
[1]: go/isolated-apps-when-to-verify-signatures
Bug: 1366309
Change-Id: I7c55a10cebd08105ea858f9f48d9df828400cf5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4180724
Commit-Queue: Sonja Laurila <laurila@google.com>
Auto-Submit: Christian Flach <cmfcmf@chromium.org>
Reviewed-by: Sonja Laurila <laurila@google.com>
Cr-Commit-Position: refs/heads/main@{#1097892}
Web apps coming from WebUIs should have a narrow scope limited to
app's functionality. They should not open other "chrome://" pages
in app windows, even in CCTs.
To enforce this, this CL adds a navigation throttle that opens such
navigations in new Chrome browser tab.
Bug: 1358448
Change-Id: I5c9b4ee17acc93c49ef2b158ff51eb34bfd28f47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4180677
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Maria Kazinova <kazinova@google.com>
Cr-Commit-Position: refs/heads/main@{#1097099}
This CL moves the validation and verification code for Isolated Web Apps
out of the `IsolatedWebAppReaderRegistry` and into a newly introduced
`IsolatedWebAppResponseReaderFactory`. This will allow us to re-use the
code for an explicit validation and verification step during
installation.
Bug: 1366309
Change-Id: I929ef7c1c7df44c2e7913ff6f5d1287e0189053d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4166956
Commit-Queue: Christian Flach <cmfcmf@chromium.org>
Reviewed-by: Sonja Laurila <laurila@google.com>
Reviewed-by: Oleksandr Peletskyi <peletskyi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1095631}
This change:
* Changes the site names to be more specific. For example,
SiteA -> Standalone.
* Updates some test actions to take advantage of the new wildcard
feature.
* Updates other tests to use new actions, deleting unnecessary ones.
* Other misc cleanup.
* Shortening names now that the test names are too long.
Bug: b/242063423
Change-Id: Iaf80d30ca6ea0653cca382d9d4f91ed58f9cd07c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828313
Reviewed-by: Phillis Tang <phillis@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Reviewed-by: Dibyajyoti Pal <dibyapal@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1036815}
This change allows critical user journey to specify a wildcard like
"EnumType::All", which will cause the script to expand that single test
into multiple tests for every combination of argument expansion.
This allows us to continue to simplify our test list and implementation.
Bug: b/240571429
Change-Id: I4c45cea08048ab817d246c4208ac428c797e8ff6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827079
Commit-Queue: Dibyajyoti Pal <dibyapal@chromium.org>
Reviewed-by: Dibyajyoti Pal <dibyapal@chromium.org>
Auto-Submit: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1035189}
Draft message to update all tests with:
// Test contents are generated by script. Please do not modify!
// See `docs/webapps/why-is-this-test-failing.md` or
// `docs/webaps/integration-testing-framework` for more info.
// Sheriffs: Disabling this test is supported.
Bug: 1342424
Change-Id: I9c09822c66a4e704a7b789bb60580e756d189c85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3750044
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Glen Robertson <glenrob@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1027444}
Added the 2 builders with the same configs as mac 11 version, except for
specified machine versions. mac12-arm64-rel will replace the mac 11
equivalent in CQ in a follow up CL.
Bug: 1334005
Change-Id: I8de42744410652a57685edd2c60d01afd26cf770
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3699392
Reviewed-by: Sven Zheng <svenzheng@chromium.org>
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1013557}
This patch updates the dPWA testing framework script to allow for
multiple arguments in the CUJ actions.
Behavior changes:
* Actions not specify a list of argument (or enumeration) types.
* These types are defined in a new sheet titled "Enums" with values.
* Parameterized actions have a new format to specify the output action,
where it uses bash argument syntax ($1 for the first arg, $2 for the
second, etc) to forward arguments of the parameterized action to the
output actions.
This change does not affect the tests themselves or coverage, and
should be a no-op for test generation.
Future changes:
* After this change has landed, the current cpp method call of
MethodName("Argument") can change to be MethodName(ArgType::kArg),
providing a much better coding interface to work with.
Bug: 1310428
Change-Id: I2d6271e08ad2d19b2d4c2dd6ac87df9fe4c8b02d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3553829
Reviewed-by: Phillis Tang <phillis@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/main@{#986982}