0
Commit Graph

115442 Commits

Author SHA1 Message Date
d037e46c96 Split out PST metrics for per-site limits.
Change-Id: I0583ab4f2f50bad454d3662473a84bc9898de243
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6133673
Reviewed-by: Bo Liu <boliu@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org>
Reviewed-by: Aykut Bulut <aykutb@google.com>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1402392}
2025-01-06 08:21:55 -08:00
fbea136819 [views-ax] Implement BrowserAccessibility::IsWebContent
BrowserAccessibility::IsWebContent used to always return true. This had
to change since we'll soon have a BrowserAccessibility tree of views.

Bug: 325137417
Change-Id: Ic7592a608725e01a32301a9f28c5febfcab2dac9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6135342
Reviewed-by: Jacques Newman <janewman@microsoft.com>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1402373}
2025-01-06 07:48:38 -08:00
d0e8670e14 Remove attribution scopes feature flag
This has been enabled by default since M130.

Change-Id: Ib99063a69bc3d352e87d69db9a3e48f3fa98aa84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6147814
Reviewed-by: Thomas Quintanilla <tquintanilla@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org>
Reviewed-by: Nan Lin <linnan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1402367}
2025-01-06 07:30:07 -08:00
a4f9be41fd Handle transfer state received from Browser and process input events.
In this change we are introducing logic to handle input events received
on Viz.
- Input events received on Viz before state transfer are queued.
- Upon receiving state transfer input events in queue for the given
  sequence are flushed and forwarded to "correct"
  RenderInputRouterSupportAndroid.
- Any out of order state transfer received are being ignored. This can
  happen since the states can come over different pipes from different
  web contents.

Bug: 370506271
Change-Id: I4c7aa7da0ccc17c4a9c52882e54686d491a743ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6073287
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Aman Verma <amanvr@google.com>
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Stephen Nusko <nuskos@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Kartar Singh <kartarsingh@google.com>
Cr-Commit-Position: refs/heads/main@{#1402336}
2025-01-06 05:43:49 -08:00
d3f480aa1d Revert "MediaSession: Add WebAudio players as ambient players"
This reverts commit 30ffd2c53d.

Reason for revert: Suspected to break 
All/RenderProcessHostTest.KillProcessZerosAudioStreams/Default
All/RenderProcessHostTest.KillProcessZerosAudioStreams/KeepAliveInBrowserMigration
on https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20TSan%20Tests/93486/overview

Original change's description:
> MediaSession: Add WebAudio players as ambient players
>
> When the AudioFocusManager ducks a MediaSessionImpl, it lowers the
> volume of its underlying players. This does not currently lower the
> volume of WebAudio playback, as AudioContexts are not registered to
> the MediaSessionImpl as media players.
>
> WebAudio has not been registered before as we have not wanted
> WebAudio playback to affect audio focus. However, there's an "ambient"
> audio focus type that accomplishes just that (currently unused by
> MediaSessionImpl). This CL adds "ambient" players to the
> MediaSessionImpl which will request ambient focus if there are no other
> players requesting a stronger type of audio focus, and makes
> AudioContexts register as ambient players. This allows the
> AudioFocusManager to know about WebAudio playback so it can force it
> to duck when needed.
>
> On the AudioContext side, it ducks the output volume by scaling the
> output audio bus according to the volume multiplier given by the
> browser side.
>
> Bug: 382316461
> Change-Id: Iffdb572d8c999177b35e17c76717460665bcfbbb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6098352
> Reviewed-by: Hongchan Choi <hongchan@chromium.org>
> Commit-Queue: Tommy Steimel <steimel@chromium.org>
> Reviewed-by: Mark Foltz <mfoltz@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1402262}

Bug: 382316461, 387915329
Change-Id: I55a57b64e544874b3973019640474846921b77dd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6147027
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Christian Dullweber <dullweber@chromium.org>
Auto-Submit: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1402279}
2025-01-05 23:42:22 -08:00
30ffd2c53d MediaSession: Add WebAudio players as ambient players
When the AudioFocusManager ducks a MediaSessionImpl, it lowers the
volume of its underlying players. This does not currently lower the
volume of WebAudio playback, as AudioContexts are not registered to
the MediaSessionImpl as media players.

WebAudio has not been registered before as we have not wanted
WebAudio playback to affect audio focus. However, there's an "ambient"
audio focus type that accomplishes just that (currently unused by
MediaSessionImpl). This CL adds "ambient" players to the
MediaSessionImpl which will request ambient focus if there are no other
players requesting a stronger type of audio focus, and makes
AudioContexts register as ambient players. This allows the
AudioFocusManager to know about WebAudio playback so it can force it
to duck when needed.

On the AudioContext side, it ducks the output volume by scaling the
output audio bus according to the volume multiplier given by the
browser side.

Bug: 382316461
Change-Id: Iffdb572d8c999177b35e17c76717460665bcfbbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6098352
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Mark Foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1402262}
2025-01-05 20:15:22 -08:00
b27d4748eb Fix TODOs to use crbug.com.
Change-Id: I7cd08af1b2b9162889d1b042cf19c75deec3866a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6140897
Commit-Queue: Joshua Hood <jdh@chromium.org>
Auto-Submit: Ryan Tarpine <rtarpine@chromium.org>
Reviewed-by: Joshua Hood <jdh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1402033}
2025-01-03 19:39:02 -08:00
1179bde65a Add Finch-configured limits on selectableBuyerAndSellerReportingIds.
Each ad in an interest group may have a list of
`selectableBuyerAndSellerReportingIds`, each a string. This implements a
potential Finch-configured limit on the number of elements in that list
that may be allowed. In actuality, this implements two separate limits,
a soft limit on interest groups being joined or updated, and a separate
hard limit on interest groups previously joined or updated that might
exceed the soft limit during a change in the limit. This allows for
potentially reducing that limit without invalidating any interest group
joined with the previous higher limit, by allowing the soft limit to be
reduced, waiting for all IGs joined with the previous limit to expire,
and only then reducing the hard limit to match the new soft limit.

Change-Id: Ib8855f85998517da9d5c6eee5e2bf8d056edcad4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6139105
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Orr Bernstein <orrb@google.com>
Owners-Override: Orr Bernstein <orrb@google.com>
Cr-Commit-Position: refs/heads/main@{#1402025}
2025-01-03 18:23:30 -08:00
dd81ed9ceb Use SafeAreaInsetsHostImpl#active_render_frame_host()
active_rfh_ should only be used in MaybeActiveRenderFrameHostChanged()
per code comments in the header file.

Also inlines the getter and rename it as |active_render_frame_host|.

Bug: N/A
Change-Id: Ibc57c8565c762be34cdf407fb570349e1925dcc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6143335
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401991}
2025-01-03 16:02:55 -08:00
3e355357bb Integrate ComplexSafeAreaConstraintChanged signal
Bug: 385221500
Change-Id: I1c2c4e8a0d919f2caf10a42ef50cca99104103c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6143053
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401961}
2025-01-03 14:07:50 -08:00
7d726cbb3d [Android] Migrate usages of FeatureList#setTestValues()
Migrate to using FeatureOverrides.

This is the largest part of the migration.

Bug: 345483590
Change-Id: I7edd1bb57d6246eeed24e1872e5e44bbd8ec850a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6143095
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Owners-Override: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401957}
2025-01-03 13:45:56 -08:00
fead5233d7 Notify Browser when CSS safe-area-inset-bottom is used in Paint inducing styles
Bug: 385215539
Change-Id: I91161018d11e8b185b482c27467821c9750685c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6107457
Commit-Queue: Victor Miura <vmiura@chromium.org>
Owners-Override: Victor Miura <vmiura@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401947}
2025-01-03 13:31:01 -08:00
50fb252d20 Android: Add @NullMarked to content_main_dex_java
Bug: 40657579
Change-Id: I9fdd190fb72e35d86f01f8d0c1eb589cee6043fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6129856
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Owners-Override: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401932}
2025-01-03 12:37:35 -08:00
72bfa2e660 Remove redundant bounds() method.
Bug: 40234130

Change-Id: Ib9ac94c82766f48177363ae41bcb8e93a913c982
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6142554
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401929}
2025-01-03 12:26:02 -08:00
63a7fde9bf [CodeHealth] Clean up FileSystemAccessDragAndDropCheckBlocklist flag.
Bug: 356623919
Change-Id: I308d433470bc1947d6d72c970c58dd8ef37ee3bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6130556
Reviewed-by: Nathan Memmott <memmott@chromium.org>
Commit-Queue: Daseul Lee <dslee@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401921}
2025-01-03 12:03:29 -08:00
f212c8e7f4 Add setCookieControls to CDP
This CL adds the command which stores cookie controls.

Tests and general functionality will be added in this follow-up CL:
https://crrev.com/c/6068107

Bug: 375352611
Change-Id: Iaa77b0ce973869213016932553a906e804e8ebb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6050194
Reviewed-by: Shuran Huang <shuuran@chromium.org>
Commit-Queue: Joshua Thomas <masnoble@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401917}
2025-01-03 11:57:12 -08:00
54fc40dafc [FedCM] Show filtered accounts by default
launch/4338516

Bug: 40945672
Change-Id: I9e8c30a9962d45a6a5a520c64695620b0d2152e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6137732
Commit-Queue: Nicolás Peña <npm@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401885}
2025-01-03 10:43:20 -08:00
15b2696dea [FedCM] Introduce boolean is_registered_config_url
The existing boolean in IdentityProviderConfig is pretty much unneeded,
so it is replaced with this. The boolean means whether the IDP it
represents corresponds to one related to IDP registration or not. It
will be used to relax the well-known checks for registered IdPs, as per
https://github.com/w3c-fedid/idp-registration/issues/4#issuecomment-2334800148

Bug: 346572117
Change-Id: I61655cebac98f26939f6e3621adb1c18fd607445
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6138067
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Nicolás Peña <npm@chromium.org>
Owners-Override: Nicolás Peña <npm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401880}
2025-01-03 10:36:56 -08:00
1c9524c5d3 Reapply "IDB: direct reads for blobs"
This relands commit 60632268ea.

Difference to original: added support for AsDataPipeGetter and
extended blob-contenttype.any.js WPT to cover this case.

Original change's description:
> IDB: direct reads for blobs
>
> For the standard case of a page reading IDB data from the blob store,
> don't go through the blob registry on the i/o thread and instead
> connect the IDB bucket thread directly to the renderer.
>
> In some other (rarer) cases the blob registry is still used. This
> is accomplished by *additionally* registering a blob with
> BlobStorageContext using the same UUID, which is necessary for:
>
> * WriteBlobToFile(), which does lookup by UUID
> * loading data for a blob:// URL, i.e. mojom::Blob::Load, which is
>   thunked through to the registry blob because implementation is non-
>   trivial
>
> Bug: 373684390
> Change-Id: I9235f23303e4e6a05bf12a8acff32a5fb4e2a565
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6113789
> Commit-Queue: Evan Stade <estade@chromium.org>
> Reviewed-by: Steve Becker <stevebe@microsoft.com>
> Cr-Commit-Position: refs/heads/main@{#1400627}

Bug: 373684390
Change-Id: Ie555cf4b583b862d306c43e3e4be76e957ea6c5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6138579
Reviewed-by: Steve Becker <stevebe@microsoft.com>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401872}
2025-01-03 10:11:28 -08:00
f1126dcbff [TEST ONLY] Add missing aggregateWinSignals check in bidder worklet's
unittest

Change-Id: Ifaf4ee8211cc2e2478b8354f4c31976d12301dab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6119682
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Youssef Bourouphael <ybourouphael@google.com>
Reviewed-by: Orr Bernstein <orrb@google.com>
Cr-Commit-Position: refs/heads/main@{#1401860}
2025-01-03 09:35:13 -08:00
58df9f6bcd Cleanup MainThreadCompositingPriority
R=etiennep@chromium.org

Fixed: 259954298, 362247428
Change-Id: Ia849e5a12779b2eea3baf558f12f2487ec80ee5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6115536
Reviewed-by: Charlie Reis <creis@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Commit-Queue: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401849}
2025-01-03 09:05:50 -08:00
436bb8084c Cleanup AboveNormalCompositingBrowserWin
There is a remaining use case of `pump_type_hint` in
platform_thread_android.cc and it will therefore not be
cleaned up in this pass.

R=etiennep@chromium.org

Fixed: 40226692, 362246655
Change-Id: I706c7c1726d50c5cb170af3b2aba05e0b32daa4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6139009
Owners-Override: Etienne Pierre-Doray <etiennep@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401807}
2025-01-03 07:00:53 -08:00
8563c8983b [tracing] Consider a trace uploaded only after running serialize_log_callback
This should make metrics reporting more accurate, and allow
retry uploading if chrome shuts down before serialize_log_callback
finishes.

Change-Id: Id0413f166c35eb307730abce1788ca743c354c91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6132289
Owners-Override: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401799}
2025-01-03 06:27:05 -08:00
aaa8627166 Revert "[shared storage] Implement sharedStorage.batchUpdate() for PA worklet"
This reverts commit f0cab8e234.

Reason for revert: New tests are failing on linux-chromeos-dbg:

https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/38480/test-results

Original change's description:
> [shared storage] Implement sharedStorage.batchUpdate() for PA worklet
>
> Add sharedStorage.batchUpdate() function. Parse arguments into
> the 'methods' sequence and a 'with_lock' optional flag, and
> propagate the result to the browser process to invoke the
> `SharedStorageLockManager::SharedStorageBatchUpdate()` API.
>
> This allows developers to perform multiple Shared Storage operations atomically within a single lock, as part of the Web
> Lock integration proposal:
> - https://github.com/WICG/shared-storage/pull/199
> - https://github.com/WICG/shared-storage/pull/205
>
> Fuchsia-Binary-Size: Size increase is unavoidable.
> Bug: 373899210
> Change-Id: Ic6e9f794d78523ec9f6b87f37fb5e91f17635c58
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6072850
> Commit-Queue: Yao Xiao <yaoxia@chromium.org>
> Reviewed-by: Maks Orlovich <morlovich@chromium.org>
> Reviewed-by: Cammie Smith Barnes <cammie@chromium.org>
> Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1401673}

Bug: 373899210
Change-Id: I46c27d924dae0684a07ec081095d8dbde970b6ca
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6123546
Owners-Override: Tim Sergeant <tsergeant@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401696}
2025-01-02 21:34:03 -08:00
4a662dce4a Add UMA to track number of selectableBuyerAndSellerReportingIds.
This metric records the number of `selectableBuyerAndSellerReportingIds`
on each ad. This is recorded once per ad for each ad in an interest group
at the point at which that interest group is joined, and once per ad for
each ad in an interest group that updates its ads as part of an interest
group update. This metric records the size of the
`selectableBuyerAndSellerReportingIds` field on each ad, even if
`selectableBuyerAndSellerReportingIds` is empty (size=0), but not
if the `selectableBuyerAndSellerReportingIds` field is omitted.

Bug: 356654297
Change-Id: Id01cf93eeca0dc83d66ff74f3c8c399315783784
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6126220
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Orr Bernstein <orrb@google.com>
Cr-Commit-Position: refs/heads/main@{#1401694}
2025-01-02 21:19:13 -08:00
f0cab8e234 [shared storage] Implement sharedStorage.batchUpdate() for PA worklet
Add sharedStorage.batchUpdate() function. Parse arguments into
the 'methods' sequence and a 'with_lock' optional flag, and
propagate the result to the browser process to invoke the
`SharedStorageLockManager::SharedStorageBatchUpdate()` API.

This allows developers to perform multiple Shared Storage operations atomically within a single lock, as part of the Web
Lock integration proposal:
- https://github.com/WICG/shared-storage/pull/199
- https://github.com/WICG/shared-storage/pull/205

Fuchsia-Binary-Size: Size increase is unavoidable.
Bug: 373899210
Change-Id: Ic6e9f794d78523ec9f6b87f37fb5e91f17635c58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6072850
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Cammie Smith Barnes <cammie@chromium.org>
Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401673}
2025-01-02 18:31:45 -08:00
4945b31056 Revert "Topics: Sending Topics with image requests"
This reverts commit 072152ec38.

Reason for revert: See https://issues.chromium.org/u/1/issues/387306732

Original change's description:
> Topics: Sending Topics with image requests
>
> Send the Topics request header on image requests that specify the "browsingTopics" attribute.
>
> Use much of the existing plumbing work from the fetch() API. Adapt many
> of the tests for the fetch() API to also run for <img> attribute.
>
> PR: https://github.com/patcg-individual-drafts/topics/pull/357
>
> Bug: 382532794
>
> Change-Id: Id5975006a0c842df8765c49470c5f30bca7586c0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6067268
> Commit-Queue: Abigail Katcoff <abigailkatcoff@chromium.org>
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Reviewed-by: Robert Ogden <robertogden@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1401483}

Bug: 382532794
Change-Id: Ia0403c388a639a0ff0a77dce9497108f2056aefd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6138635
Owners-Override: Tim Sergeant <tsergeant@chromium.org>
Commit-Queue: David Yeung <dayeung@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Tim Sergeant <tsergeant@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401650}
2025-01-02 16:58:52 -08:00
58bff150ba media: Handle invalid key system in MediaInterfaceProxy::GetCdmFactory()
The key system is passed from the render process which
cannot be trusted. Hence, handle invalid key systems
properly instead of NOTREACHED().

Fixed: 384549089
Change-Id: If5d61e2e8cbd2e02140308bf8d033a2bb0cd601b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6137733
Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401593}
2025-01-02 14:03:11 -08:00
b3bb9c5ca1 Remove js-webui bindings test for content/test
We are deprecating the closure-webui bindings. The ts test already
coveres everything that the closure-webui tests covered.

  on CrOS targets.

Bug: 384098175
Change-Id: I660094b951229e150b5e6ca81dd854cd10950e86
Tested: manually verified that the ts webui bindings are still running
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6119189
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Fred Shih <ffred@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401575}
2025-01-02 13:17:42 -08:00
6d37ed5178 [Android] Remove FeatureList#setTestFeatures() and usages.
Use either @Enable/DisableFeatures instead, or when necessary in
parameterized tests, FeatureList#setTestValues() or
FeatureList#setTestFeature().

Downstream migration: https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/7921738

Bug: 386813115
Change-Id: I002b09ebd96d83c85e5c0a4878312776fec6412b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6114359
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Owners-Override: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Owners-Override: Henrique Nakashima <hnakashima@chromium.org>
Auto-Submit: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401571}
2025-01-02 13:14:40 -08:00
92631c890f Remove StrongAlias::Hasher
Since std::hash has been implemented for StrongAlias, we can remove the
redundant Hasher struct. Mostly this is trivial, although in once case
(AxPlatformNodeId) the type system wasn't able to deduce the correct
hasher automatically, so we provide an explicit specialization.

Bug: 380246463
Change-Id: I299623b8cc8193415cb8771dd455a3cddfa27e1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6132291
Commit-Queue: Devon Loehr <dloehr@google.com>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Abigail Klein <abigailbklein@google.com>
Owners-Override: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401545}
2025-01-02 12:15:15 -08:00
9e20dd1307 Reland: Record metrics and trace events for navigation start adjustments.
This reverts commit c33526f6ae.

Record metrics and trace events for navigation start adjustments.

These metrics will indicate how large the adjustments are in practice,
and how consistently they are made.

The previous attempt did not account for negative time adjustments,
which unfortunately can occur in practice. This CL allows us to gather
metrics for negative adjustments as well (diff from PS1).

Bug: 385170155
Change-Id: Id10060ae8ef6e225c09442aa8c72784ef56c2898
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6120967
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Charlie Reis <creis@chromium.org>
Reviewed-by: Sharon Yang <yangsharon@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401543}
2025-01-02 12:11:53 -08:00
b12a527371 [CodeHealth] Remove unneeded unsafe buffer annotation
Bug: 342213636
Change-Id: Ice66b0af48cca5e5d4dc263d27b8dcb64031e624
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6130364
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401534}
2025-01-02 11:46:27 -08:00
e5a4aba6d6 [Android] Create FeatureList#removeAllTestOverrides()
Disallow #setTestValues(null) and #setTestFeatures(null). Clean up many
calls that are unnecessary since the test runners themselves clear reset
test values.

Bug: 386813115
Change-Id: I5c1bf1d6616b639c6f987668f54dcbee3b9f25cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6123040
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Owners-Override: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1401528}
2025-01-02 11:34:19 -08:00
a0385ea15a FLEDGE: Measure the cost of trusted signals URL splitting.
It is quadratic, but it's probably a good idea to see if it's a problem
in practice before making it more complicated.

Change-Id: I6616a846180a6e7cafb1308619a26c5e23e8c204
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6134170
Reviewed-by: Orr Bernstein <orrb@google.com>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401509}
2025-01-02 10:56:08 -08:00
24e7429c35 Move frame test helpers from content-internal to public
Change-Id: Iedaa31539eb6c8b653f268592f2d3b718003ef74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111465
Owners-Override: Ian Wells <iwells@chromium.org>
Reviewed-by: Ian Wells <iwells@chromium.org>
Commit-Queue: Ian Wells <iwells@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401493}
2025-01-02 10:17:09 -08:00
072152ec38 Topics: Sending Topics with image requests
Send the Topics request header on image requests that specify the "browsingTopics" attribute.

Use much of the existing plumbing work from the fetch() API. Adapt many
of the tests for the fetch() API to also run for <img> attribute.

PR: https://github.com/patcg-individual-drafts/topics/pull/357

Bug: 382532794

Change-Id: Id5975006a0c842df8765c49470c5f30bca7586c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6067268
Commit-Queue: Abigail Katcoff <abigailkatcoff@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401483}
2025-01-02 10:02:26 -08:00
6ae05123ce [FedCM] Pass the type to the ID assertion endpoint
Fixed: 347742955
Change-Id: Ic02f366b9df884d6f1dd6b6b988f1d8e658faa99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6132541
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Nicolás Peña <npm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401469}
2025-01-02 09:31:17 -08:00
77b6625609 [DIPS] Mark some metrics as singular and clarify summaries
DIPS.SuspectedTrackerFlow* and some DIPS.TrustIndicator* are singular events, but were not marked with `singular="True"` when they were added. Simply marking them as singular now is unsafe, so this CL creates V2s of these metrics.

The <summary>s for many of the DIPS.SuspectedTrackerFlow* and DIPS.TrustIndicator* events were also formatted and/or ordered confusingly; this CL hopefully makes them easier to read.

Change-Id: I463c45e3a6b7f033982e66e5d1a3bd745af71177
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6115181
Commit-Queue: Svend Larsen <svend@chromium.org>
Reviewed-by: Sun Yueru <yrsun@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401468}
2025-01-02 09:30:13 -08:00
48de5faf6a FLEDGE: Add send_creative_scanning_metadata to AuctionConfig
Since this is used to configure trusted signals fetching, it needs to
be consistent per SellerWorklet, so it's passed to that layer a
part of worklet config/worklet key, and not as NonSharedParams.

See https://github.com/WICG/turtledove/issues/792#issuecomment-2402992572 for more context.

Bug: 383513677
Change-Id: Ie2ef2b95ab8d11a5c6707fcf6170a0975f96bd21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6091988
Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Caleb Raitto <caraitto@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401466}
2025-01-02 09:20:51 -08:00
70da710859 Protected Audience: fix HttpCachedTrustedBiddingSignalsAge metric
The request time on the response head corresponds with the original
request time (for the validated and cached entries), not the new
request time, so this metric wasn't being recorded as expected. Do not
record for the "updated" case because we do not appear to have the
relevant fields for it.

OBSOLETE_HISTOGRAM[Ads.InterestGroup.Auction.HttpCachedTrustedBiddingSignalsAge]=replaced by HttpCachedTrustedBiddingSignalsAge2

Bug: 383579272
Change-Id: I223c3c666f12662b13dc32fcc228f238f42778ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6116043
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Orr Bernstein <orrb@google.com>
Commit-Queue: Abigail Katcoff <abigailkatcoff@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401463}
2025-01-02 09:15:09 -08:00
e4f2934140 Re-enable StylusGestureEndToEndTests
This test was originally disabled as it was failing on
android-14-x64-rel but the failures were unrelated to the test itself
and seem to have since been resolved.

Bug: 343810189
Cq-Include-Trybots: luci.chromium.try:android-14-x64-rel
Change-Id: Iba98802624c783cb35db5426179615540f4d06db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6120420
Auto-Submit: Alex Mitra <alexmitra@chromium.org>
Commit-Queue: Ziad Youssef <ziadyoussef@chromium.org>
Owners-Override: Alex Mitra <alexmitra@chromium.org>
Reviewed-by: Ziad Youssef <ziadyoussef@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401458}
2025-01-02 09:03:57 -08:00
a81a99ac07 FLEDGE: Add InterestGroup::Ad::creative_scanning_metadata
See https://github.com/WICG/turtledove/issues/792#issuecomment-2402992572 for more context.

Bug: 383513677

Change-Id: I0fb23266c12a20046976c7a1b723136499a59a44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6084483
Reviewed-by: Caleb Raitto <caraitto@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Cammie Smith Barnes <cammie@chromium.org>
Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401439}
2025-01-02 08:16:46 -08:00
daf40c5b9e macOS: Fix a CHECK failure in setMarkedText
According to crash/0c6d95b50030868b, a CHECK_LE in setMarkedText fails.
This CL converts it to an `if` condition.

Bug: 40060200
Change-Id: Ifefad1e12e5469f1818853cb49bf7faa31123242
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6126238
Auto-Submit: Kent Tamura <tkent@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401419}
2025-01-02 07:22:26 -08:00
3cad9cf243 Load the browser bound key on secure payment confirmation.
When creating a payment assertion, load the stored browser bound key id
for the relevant credential and relying party. Before this change secure
payment confirmation would create a new browser bound key. After this
change secure payment confirmation uses the browser bound key that was
previously created (e.g. the browser bound key from credential creation).

This change is behind the flag,
chrome://flags/#enable-secure-payment-confirmation-browser-bound-key

Bug: 377278827, b:378708356
Change-Id: Ia902e9256e4c86de3b2878cfb1c8047df772f7cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6101779
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Slobodan Pejic <slobodan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401411}
2025-01-02 06:58:17 -08:00
3de24d549a [CodeHealth] Clean up WebContentsCaptureHiDPI feature
The feature was launched in M114, cleaning up the code.
Note: the cleanup was attempted in the past in crrev.com/c/4977161,
but was reverted due to MSAN failures. Some tests were reworked or
removed in the past year, and now there are no failures when I run
the same linux_chromium_chromeos_msan_rel_ng bot, so the cleanup
can be landed again.

Bug: 356624220
Change-Id: Ie8c22105eea8a8f6d5e87cee7daba14f3f324fc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6120408
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Maria Kazinova <kazinova@google.com>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Jordan Bayles <jophba@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401376}
2025-01-02 04:40:25 -08:00
0b0d7f274d Remove stale WebGL 1 expectations
Autogenerated CL from running:

//content/test/gpu/unexpected_pass_finder.py --project chrome-unexpected-pass-data --include-internal-builders --remove-stale-expectations --narrow-semi-stale-expectation-scope --num-samples 300 --suite webgl1_conformance

Affected bugs for CL description:

R=rubber-stamper@appspot.gserviceaccount.com

Bug: 1490427
Change-Id: I0f8d8b875b9607fbc12a20e2c8b08f29326ffa14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6136175
Auto-Submit: chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com <chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1401203}
2024-12-31 22:49:03 -08:00
f5837fe9d2 Remove stale expected_color expectations
Autogenerated CL from running:

//content/test/gpu/unexpected_pass_finder.py --project chrome-unexpected-pass-data --include-internal-builders --remove-stale-expectations --narrow-semi-stale-expectation-scope --num-samples 300 --suite expected_color

Affected bugs for CL description:

R=rubber-stamper@appspot.gserviceaccount.com

Bug: 377724727
Change-Id: I02c96ad761425a5cbd30f4002498c77fbf74536b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6136174
Auto-Submit: chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com <chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1401201}
2024-12-31 22:45:05 -08:00
56c4e0f31d Remove stale webcodecs expectations
Autogenerated CL from running:

//content/test/gpu/unexpected_pass_finder.py --project chrome-unexpected-pass-data --include-internal-builders --remove-stale-expectations --narrow-semi-stale-expectation-scope --num-samples 300 --suite webcodecs

Affected bugs for CL description:

R=rubber-stamper@appspot.gserviceaccount.com

Bug: 1466102
Change-Id: I3bf3b24fcbba30fec821bd0dfc41cf61115887f0
Fixed: 337665165
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6135369
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com <chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1401200}
2024-12-31 22:44:30 -08:00
376ce1c4a8 Remove stale trace_test expectations
Autogenerated CL from running:

//content/test/gpu/unexpected_pass_finder.py --project chrome-unexpected-pass-data --include-internal-builders --remove-stale-expectations --narrow-semi-stale-expectation-scope --num-samples 300 --suite trace_test

Affected bugs for CL description:

R=rubber-stamper@appspot.gserviceaccount.com

Bug: 371949935
Change-Id: Id44b8b147cf8e68788d0ec565b136628b9c947a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6136092
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com <chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1401199}
2024-12-31 22:43:56 -08:00