0
Commit Graph

115392 Commits

Author SHA1 Message Date
d1dd9bcb7c Disable flaky DumpAccessibilityTreeTest.ReloadSelectionCrash/uia
DumpAccessibilityTreeTest.ReloadSelectionCrash has been timing out on
UIA regularly:
https://ci.chromium.org/ui/test/chromium/ninja%3A%2F%2Fcontent%2Ftest%3Acontent_browsertests%2FDumpAccessibilityTreeTest.ReloadSelectionCrash%2FAll.uia

We are seeing this on Edge as well.

This CL disables the test for Windows.

Bug: 386918219
Change-Id: I7ab60987c247b2b69f27bb29b2fe5891c56d9389
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6125436
Reviewed-by: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Commit-Queue: Evelynn Kaplan <evelynn.kaplan@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1401161}
2024-12-31 13:02:14 -08:00
a09921666c [DIPS] Fix crashes on WebView.
RedirectHeuristicTabHelper is CHECK-failing when there's no DIPS
service. Just return early instead.

Bug: 386255684, 386339545
Change-Id: Ic6112d35ec05314565e4b980c31cf56082bbe9e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6122244
Reviewed-by: Svend Larsen <svend@chromium.org>
Commit-Queue: Ryan Tarpine <rtarpine@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1400998}
2024-12-30 13:18:22 -08:00
64ff3634b7 Revert "IDB: direct reads for blobs"
This reverts commit 60632268ea.

Reason for revert: causing crashes (see crbug.com/386615753)

Original change's description:
> IDB: direct reads for blobs
>
> For the standard case of a page reading IDB data from the blob store,
> don't go through the blob registry on the i/o thread and instead
> connect the IDB bucket thread directly to the renderer.
>
> In some other (rarer) cases the blob registry is still used. This
> is accomplished by *additionally* registering a blob with
> BlobStorageContext using the same UUID, which is necessary for:
>
> * WriteBlobToFile(), which does lookup by UUID
> * loading data for a blob:// URL, i.e. mojom::Blob::Load, which is
>   thunked through to the registry blob because implementation is non-
>   trivial
>
> Bug: 373684390
> Change-Id: I9235f23303e4e6a05bf12a8acff32a5fb4e2a565
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6113789
> Commit-Queue: Evan Stade <estade@chromium.org>
> Reviewed-by: Steve Becker <stevebe@microsoft.com>
> Cr-Commit-Position: refs/heads/main@{#1400627}

Bug: 373684390,386615753
Change-Id: I8e7460b58c175d9cbd62e99845dd68c71ef6dd06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6132793
Auto-Submit: Evan Stade <estade@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1400977}
2024-12-30 11:41:28 -08:00
333cc8694c Move sandbox_support_mac.mojom to sandbox_support.mojom
Rename this file and related interfaces as they will support
some non-mac use-cases.

A following CL will use the same mojom interface to proxy some
locale related system calls on Windows. This CL should cause no
functional changes.

Bug: 40408399
Change-Id: Ied9d4fbd851b4822c90d51d831f71bb0b47e7558
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102591
Commit-Queue: Alex Gough <ajgo@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1400636}
2024-12-27 20:15:58 -08:00
60632268ea IDB: direct reads for blobs
For the standard case of a page reading IDB data from the blob store,
don't go through the blob registry on the i/o thread and instead
connect the IDB bucket thread directly to the renderer.

In some other (rarer) cases the blob registry is still used. This
is accomplished by *additionally* registering a blob with
BlobStorageContext using the same UUID, which is necessary for:

* WriteBlobToFile(), which does lookup by UUID
* loading data for a blob:// URL, i.e. mojom::Blob::Load, which is
  thunked through to the registry blob because implementation is non-
  trivial

Bug: 373684390
Change-Id: I9235f23303e4e6a05bf12a8acff32a5fb4e2a565
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6113789
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Steve Becker <stevebe@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1400627}
2024-12-27 19:12:42 -08:00
808b71229c [FedCM] Add a test
Makes sure that we send did_show_ui=true if active mode is used and
the user closed the login dialog.

Bug: 40230413
Change-Id: Iee64c411e56415fab373f9df01c8cdf175818321
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6098551
Reviewed-by: Nicolás Peña <npm@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1400560}
2024-12-27 12:12:29 -08:00
0571ed0164 IDB: refactor blob reading code
This CL moves the wrapper that reads files from disk on behalf of the
blob registry into its own file. No behavioral change is intended.

Bug: 373684390
Change-Id: Ib486c5c5cab180edc3ccb0d0df5d45c483352401
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5942488
Auto-Submit: Evan Stade <estade@chromium.org>
Reviewed-by: Steve Becker <stevebe@microsoft.com>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1400548}
2024-12-27 11:22:26 -08:00
29b3bb7aaf Add WebContentObserver::SafeAreaConstraintChanged
Add the method to be integrated once crrev.com/c/6107457 lands.

Bug: 385221500
Change-Id: I879c765e9835bda414be2fbb3b8e0f6ed0c50e7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6115531
Reviewed-by: Charles Hager <clhager@google.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1400528}
2024-12-27 09:48:04 -08:00
93b2018e7a Protected Audience: eagerly compile JS
Bug: 385384684
Change-Id: I43e4a2380db3f7f5b9eee89b3cbdbf62085956a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6115153
Reviewed-by: Russ Hamilton <behamilton@google.com>
Commit-Queue: Abigail Katcoff <abigailkatcoff@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1400495}
2024-12-27 07:19:44 -08:00
6e4f317ad9 [tracing] Update TracingEndToEndBrowserTest.ThreadAndProcessName
To unblock perfetto roll
https://chromium-review.googlesource.com/c/chromium/src/+/6120448?attempt=1&checksRunsSelected=linux-chromeos-rel

Change-Id: Ie06b6fb6e7219db15f0d04cd169f43d37d217558
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108111
Reviewed-by: Petr Cermak <petrcermak@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1400487}
2024-12-27 06:42:19 -08:00
2d59b38ce9 Deprecate and remove web bundle directFromSellerSignals
The header-based version of directFromSellerSignals
(directFromSellerSignalsHeaderAdSlot) is unaffected.

Also, adds a WPT negative test, and uses a feature flag to control the
removal.

Usage metrics for web-bundle directFromSellerSignals are extremely low [0].

I2D&R thread [1].

[0] https://chromestatus.com/metrics/feature/timeline/popularity/5034

[1] https://groups.google.com/a/chromium.org/g/blink-dev/c/t9gHiTwV370

Bug: 384481095
Change-Id: I36d6ba9dbbeef4c434d00f5ba61cb1696bfbe11d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6096602
Reviewed-by: Mike Taylor <miketaylr@chromium.org>
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1400484}
2024-12-27 06:31:30 -08:00
681283ef46 [headless] Add window origin specification to Target.createTarget()
With headless screen configuration and window positioning options
recently added to headless shell it is convenient to be able to
create targets at the specific location.

Change-Id: I91aebaa80c15b448e22c87f428c9cb62762f8407
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6125752
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Auto-Submit: Peter Kvitek <kvitekp@chromium.org>
Commit-Queue: Peter Kvitek <kvitekp@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1400401}
2024-12-26 17:45:34 -08:00
35c4db2b9a Reland "[DIPS] Move from //chrome to //content."
This reverts commit 5783b19dd0.

Reason for revert: Fix failing bot.

Original change's description:
> Revert "[DIPS] Move from //chrome to //content."
>
> This reverts commit 8915d9509c.
>
> Reason for revert:
> https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-x64-rel/6859/overview
>
> Original change's description:
> > [DIPS] Move from //chrome to //content.
> >
> > By moving DIPS (Bounce Tracking Mitigations) into //content, it will be
> > available for all content embedders, such as Android WebView.
> >
> > Aside from the obvious file moves, the main changes are:
> > - DIPS-related WebContentsObservers are created in
> >   WebContentsImpl::Init() instead of TabHelpers::AttachTabHelpers()
> > - No more DIPSServiceFactory: BrowserContextImpl creates and owns the
> >   DIPSServiceImpl directly
> > - No more DIPSCleanupService (nor its factory): BrowserContextImpl
> >   deletes the DIPS database file if necessary
> > - The logic to trigger DIPS data deletion moved from
> >   ChromeBrowsingDataRemoverDelegate to BrowsingDataRemoverImpl
> > - Tests have to override the ContentBrowserClient instead of setting
> >   prefs and modifying the HostContentSettingsMap to test 3PC behavior
> > - The OpenerHeuristicService was split into two pieces: the part that
> >   creates cookie grants was moved into //content as the new method
> >   BrowserContext::BackfillPopupHeuristicGrants(); and the part that
> >   observes the tracking protection settings stays in //chrome and calls
> >   that method.
> > - Many FeatureParams were moved from tpcd_experiment_features.h in
> >   //chrome to //components/content_settings/core/common/features.h
> > - components/content_settings/core/common was added to content/DEPS
> > - Renamed SiteDataAccessType to DIPSDataAccessType
> >
> > In followup CLs, we will
> > (1) Put all of the DIPS classes, functions, etc into the content namespace (crrev.com/c/6039087)
> > (2) Rename DIPS prefixes to Dips to comply with the style guide
> > (3) Change b/ bug references to crbug.com/
> > (4) Delete DipsDelegate, moving its methods to ContentBrowserClient
> >
> > Bug: 40883201
> > Change-Id: I3c07e867ae00e6817ff286a71722473c08ead624
> > Fuchsia-Binary-Size: Size increase is unavoidable - moving feature from //chrome to //content
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6000406
> > Reviewed-by: Avi Drissman <avi@chromium.org>
> > Reviewed-by: Joshua Hood <jdh@chromium.org>
> > Commit-Queue: Ryan Tarpine <rtarpine@chromium.org>
> > Reviewed-by: Adam Langley <agl@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1399855}
>
> Bug: 40883201
> Change-Id: I7c74ccf088a40075dd2134d855dc4ad5ea08ae58
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6117354
> Owners-Override: Owen Min <zmin@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Auto-Submit: Owen Min <zmin@chromium.org>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1399859}

Bug: 40883201
Change-Id: If191568901b803a8c4d1daebab27a295cbe38a0e
Fuchsia-Binary-Size: Size increase is unavoidable - moving feature from //chrome to //content
Cq-Include-Trybots: luci.chromium.try:linux-cast-x64-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6121689
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Joshua Hood <jdh@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Owners-Override: Ryan Tarpine <rtarpine@chromium.org>
Reviewed-by: Mike Wasserman <msw@chromium.org>
Commit-Queue: Ryan Tarpine <rtarpine@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1400362}
2024-12-26 13:56:02 -08:00
ec0c191978 Add customizable select a11y test for <label>
Fixed: 40234101
Change-Id: I605d391077e4242267fa9e83427fda47a3ceca20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6092610
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1400341}
2024-12-26 12:21:22 -08:00
eb3867c475 Introduce CreateNavigationRequestCommon
- To centralize the ResourceRequest creation logic common to
  the non-prefetch navigation requests and speculation-rules
  prefetch requests.
- As a preparation for
  https://chromium-review.googlesource.com/c/chromium/src/+/6024664.

This CL doesn't change the behavior.

Bug: 379263818
Change-Id: I1bae8c4a557d0b406925de99b29c835ebbaba308
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6024663
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1400241}
2024-12-25 23:30:30 -08:00
de1709f549 Remove stale webcodecs expectations
Autogenerated CL from running:

//content/test/gpu/unexpected_pass_finder.py --project chrome-unexpected-pass-data --include-internal-builders --remove-stale-expectations --narrow-semi-stale-expectation-scope --num-samples 300 --suite webcodecs

Affected bugs for CL description:

R=rubber-stamper@appspot.gserviceaccount.com

Bug: 337665165
Change-Id: Ie497527748bfadcd5595c38249086c931a08a843
Fixed: 1517101
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6123033
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com <chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1400142}
2024-12-24 23:52:09 -08:00
17d5f0159c Remove stale WebGL 1 expectations
Autogenerated CL from running:

//content/test/gpu/unexpected_pass_finder.py --project chrome-unexpected-pass-data --include-internal-builders --remove-stale-expectations --narrow-semi-stale-expectation-scope --num-samples 300 --suite webgl1_conformance

Affected bugs for CL description:

R=rubber-stamper@appspot.gserviceaccount.com

Bug: 1488973, 1488978, 1488979, 1518007, 40285462
Change-Id: I778dfe1d3754c608547d4927cde874eab20df6f0
Fixed: 1492234
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6120219
Auto-Submit: chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com <chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1400141}
2024-12-24 23:50:44 -08:00
87b1d6bf45 Remove stale WebGL 2 expectations
Autogenerated CL from running:

//content/test/gpu/unexpected_pass_finder.py --project chrome-unexpected-pass-data --include-internal-builders --remove-stale-expectations --narrow-semi-stale-expectation-scope --num-samples 300 --suite webgl2_conformance

Affected bugs for CL description:

R=rubber-stamper@appspot.gserviceaccount.com

Bug: 1488973, 1488978, 1488979, 1518007, 40285462
Change-Id: I28a7f9b4033061e63d73f12a36da2143d5de556f
Fixed: 1492242, 1492245, 1492248, 1492250, 1492256
Fixed: 1492257, 1492258, 1492270, 1499516, 1499523
Fixed: 1499534, 1499536
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6123055
Auto-Submit: chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com <chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1400139}
2024-12-24 23:46:56 -08:00
7126e4d230 Remove stale pixel expectations
Autogenerated CL from running:

//content/test/gpu/unexpected_pass_finder.py --project chrome-unexpected-pass-data --include-internal-builders --remove-stale-expectations --narrow-semi-stale-expectation-scope --num-samples 300 --suite pixel

Affected bugs for CL description:

R=rubber-stamper@appspot.gserviceaccount.com

Bug: 1518007, 331488870
Change-Id: I66d1b6b5fff4886e0366163241aed502d1509d45
Fixed: 1392806, 354152172
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6122865
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com <chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1400138}
2024-12-24 23:42:29 -08:00
57004b3883 Remove stale trace_test expectations
Autogenerated CL from running:

//content/test/gpu/unexpected_pass_finder.py --project chrome-unexpected-pass-data --include-internal-builders --remove-stale-expectations --narrow-semi-stale-expectation-scope --num-samples 300 --suite trace_test

Affected bugs for CL description:

R=rubber-stamper@appspot.gserviceaccount.com

Bug: 331488870, 371949935
Change-Id: I28dac95b1aeb7cfb5b856836e79b375ebb7268c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6120218
Auto-Submit: chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com <chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1400137}
2024-12-24 23:38:03 -08:00
c4427686f6 IDB: clean up some details of BackingStore declarations
* remove unused `virtual` modifier
* tighten access modifiers

Bug: none
Change-Id: I1f432ef7fabd905b47c11031fc8ca7cad92640e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6110166
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Steve Becker <stevebe@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1400068}
2024-12-24 10:01:15 -08:00
22e7091615 IDB - log metrics to track down shutdown hangs
These metrics are intended to shed more light on some operations
that could be executing slowly, based on observed shutdown hangs.

Low-Coverage-Reason: temporary metrics for debugging
Bug: 384476946

Change-Id: I80f5227f320ba3652978e43aab51400b47ad756e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6120590
Reviewed-by: Brad Triebwasser <btriebw@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Owners-Override: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1399966}
2024-12-23 18:59:39 -08:00
dd37f2c7ec [DevTools] Don't report issues with invalid network request IDs.
This fixes the DevTools instrumentation such that the `AffectedRequest`s
for inspector issues always contains a valid URL, and optionally the ID
of the network request.

This way the Issues panel no longer shows the network request as pending
for early CORS errors, and in particular will no longer suggest that the
developer can reload the page in order for the network request to show
up (which will never happen for these CORS issues).

The meat of the change is in the `browser_protocol.pdl`, for the
`AffectedRequest` type, where the `url` is now required, while the
`requestId` is now optional. The rest of the changes are just plumbing.

The DevTools front-end was previously prepared for these changes with
https://crrev.com/c/6111100, and works with both types of `AffectRequest`
now.

Bug: 385693302
Change-Id: I2c6c7b7ecfa5a4638d0f15ba292ad406b433bad6
Screenshot: https://i.imgur.com/lS1Orx8.png
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6110121
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Owners-Override: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Andrew Paseltiner <apaseltiner@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1399906}
2024-12-23 14:22:57 -08:00
5783b19dd0 Revert "[DIPS] Move from //chrome to //content."
This reverts commit 8915d9509c.

Reason for revert: 
https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-x64-rel/6859/overview

Original change's description:
> [DIPS] Move from //chrome to //content.
>
> By moving DIPS (Bounce Tracking Mitigations) into //content, it will be
> available for all content embedders, such as Android WebView.
>
> Aside from the obvious file moves, the main changes are:
> - DIPS-related WebContentsObservers are created in
>   WebContentsImpl::Init() instead of TabHelpers::AttachTabHelpers()
> - No more DIPSServiceFactory: BrowserContextImpl creates and owns the
>   DIPSServiceImpl directly
> - No more DIPSCleanupService (nor its factory): BrowserContextImpl
>   deletes the DIPS database file if necessary
> - The logic to trigger DIPS data deletion moved from
>   ChromeBrowsingDataRemoverDelegate to BrowsingDataRemoverImpl
> - Tests have to override the ContentBrowserClient instead of setting
>   prefs and modifying the HostContentSettingsMap to test 3PC behavior
> - The OpenerHeuristicService was split into two pieces: the part that
>   creates cookie grants was moved into //content as the new method
>   BrowserContext::BackfillPopupHeuristicGrants(); and the part that
>   observes the tracking protection settings stays in //chrome and calls
>   that method.
> - Many FeatureParams were moved from tpcd_experiment_features.h in
>   //chrome to //components/content_settings/core/common/features.h
> - components/content_settings/core/common was added to content/DEPS
> - Renamed SiteDataAccessType to DIPSDataAccessType
>
> In followup CLs, we will
> (1) Put all of the DIPS classes, functions, etc into the content namespace (crrev.com/c/6039087)
> (2) Rename DIPS prefixes to Dips to comply with the style guide
> (3) Change b/ bug references to crbug.com/
> (4) Delete DipsDelegate, moving its methods to ContentBrowserClient
>
> Bug: 40883201
> Change-Id: I3c07e867ae00e6817ff286a71722473c08ead624
> Fuchsia-Binary-Size: Size increase is unavoidable - moving feature from //chrome to //content
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6000406
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Joshua Hood <jdh@chromium.org>
> Commit-Queue: Ryan Tarpine <rtarpine@chromium.org>
> Reviewed-by: Adam Langley <agl@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1399855}

Bug: 40883201
Change-Id: I7c74ccf088a40075dd2134d855dc4ad5ea08ae58
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6117354
Owners-Override: Owen Min <zmin@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Owen Min <zmin@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1399859}
2024-12-23 11:47:39 -08:00
8915d9509c [DIPS] Move from //chrome to //content.
By moving DIPS (Bounce Tracking Mitigations) into //content, it will be
available for all content embedders, such as Android WebView.

Aside from the obvious file moves, the main changes are:
- DIPS-related WebContentsObservers are created in
  WebContentsImpl::Init() instead of TabHelpers::AttachTabHelpers()
- No more DIPSServiceFactory: BrowserContextImpl creates and owns the
  DIPSServiceImpl directly
- No more DIPSCleanupService (nor its factory): BrowserContextImpl
  deletes the DIPS database file if necessary
- The logic to trigger DIPS data deletion moved from
  ChromeBrowsingDataRemoverDelegate to BrowsingDataRemoverImpl
- Tests have to override the ContentBrowserClient instead of setting
  prefs and modifying the HostContentSettingsMap to test 3PC behavior
- The OpenerHeuristicService was split into two pieces: the part that
  creates cookie grants was moved into //content as the new method
  BrowserContext::BackfillPopupHeuristicGrants(); and the part that
  observes the tracking protection settings stays in //chrome and calls
  that method.
- Many FeatureParams were moved from tpcd_experiment_features.h in
  //chrome to //components/content_settings/core/common/features.h
- components/content_settings/core/common was added to content/DEPS
- Renamed SiteDataAccessType to DIPSDataAccessType

In followup CLs, we will
(1) Put all of the DIPS classes, functions, etc into the content namespace (crrev.com/c/6039087)
(2) Rename DIPS prefixes to Dips to comply with the style guide
(3) Change b/ bug references to crbug.com/
(4) Delete DipsDelegate, moving its methods to ContentBrowserClient

Bug: 40883201
Change-Id: I3c07e867ae00e6817ff286a71722473c08ead624
Fuchsia-Binary-Size: Size increase is unavoidable - moving feature from //chrome to //content
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6000406
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Joshua Hood <jdh@chromium.org>
Commit-Queue: Ryan Tarpine <rtarpine@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1399855}
2024-12-23 11:37:31 -08:00
fbe2c6f826 [tracing] Simplify TraceLog
This CL removes unused code in TraceLog and related, including
- function overrides
- Trace buffer
- some AddTraceEvent* variants
- legacy macros
- TraceEventMemoryOverhead

Bug: 343404899
Change-Id: I30ab81c82e835c3a43ae1d9075681a07301b022e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108078
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Owners-Override: Gabriel Charette <gab@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Mikhail Khokhlov <khokhlov@google.com>
Cr-Commit-Position: refs/heads/main@{#1399836}
2024-12-23 10:34:02 -08:00
9f9c0fd204 Revert "Try FROM_HERE without function names"
This reverts commit db43379c0d.

Reason for revert: A bunch of tests are failing and need to be updated https://ci.chromium.org/ui/p/chrome/builders/ci/linux-chromeos-chrome/47535/overview

Original change's description:
> Try FROM_HERE without function names
>
> Looks like this saves ~140k on android-binary-size. Let's give it a go
> on official builds?
>
> Bug: 41342136
> Change-Id: Ia565619b91fff9e8fdd3efdf376dbb0cdd236b78
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6099092
> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
> Owners-Override: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Commit-Queue: Peter Boström <pbos@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1399770}

Bug: 41342136
Change-Id: Ib6c5eccd920fed006eddd0bddad5f5be55b5365d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6120196
Owners-Override: Phillis Tang <phillis@chromium.org>
Commit-Queue: Phillis Tang <phillis@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1399832}
2024-12-23 10:01:57 -08:00
0e76c654e0 [A11y] Fixes for IAccessibleTextSelectionContainer
Addresses a couple of logic errors preventing selection from working in
rich subtrees, as opposed to plain text inputs.

Fixed: 40822761
Change-Id: I3542d35f3896f70a40f0b4e0c90662e636399fad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102407
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Auto-Submit: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1399777}
2024-12-23 06:11:13 -08:00
db43379c0d Try FROM_HERE without function names
Looks like this saves ~140k on android-binary-size. Let's give it a go
on official builds?

Bug: 41342136
Change-Id: Ia565619b91fff9e8fdd3efdf376dbb0cdd236b78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6099092
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Owners-Override: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1399770}
2024-12-23 05:57:14 -08:00
c33526f6ae Revert "Record metrics and trace events for navigation start adjustments."
This reverts commit c7593abc58.

Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5752743777009664

Sample build with failed test: https://ci.chromium.org/b/8727981549420340657
Affected test(s):
[ninja://chrome/test:browser_tests/ReferrerPolicyTest.History](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchrome%2Ftest:browser_tests%2FReferrerPolicyTest.History?q=VHash%3A5a9885bd2bc5b6c9)
[ninja://chrome/test:browser_tests/SupervisedUserPendingStateNavigationTest.TestBlockedSiteMainFrameReauthInterstitial/WithThrottleClassifyUrlNavigationThrottle](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchrome%2Ftest:browser_tests%2FSupervisedUserPendingStateNavigationTest.TestBlockedSiteMainFrameReauthInterstitial%2FWithThrottleClassifyUrlNavigationThrottle?q=VHash%3A5a9885bd2bc5b6c9)
[ninja://chrome/test:browser_tests/SupervisedUserPendingStateNavigationTest.TestBlockedSiteMainFrameReauthInterstitial/WithThrottleSupervisedUserNavigationThrottle](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchrome%2Ftest:browser_tests%2FSupervisedUserPendingStateNavigationTest.TestBlockedSiteMainFrameReauthInterstitial%2FWithThrottleSupervisedUserNavigationThrottle?q=VHash%3A5a9885bd2bc5b6c9)
[ninja://chrome/test:browser_tests/SupervisedUserPendingStateNavigationTest.TestReauthInterstitialClosesSignInTabsAndReloads/WithThrottleSupervisedUserNavigationThrottle](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchrome%2Ftest:browser_tests%2FSupervisedUserPendingStateNavigationTest.TestReauthInterstitialClosesSignInTabsAndReloads%2FWithThrottleSupervisedUserNavigationThrottle?q=VHash%3A5a9885bd2bc5b6c9)

If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5752743777009664&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6112083&type=BUG

Original change's description:
> Record metrics and trace events for navigation start adjustments.
>
> These metrics will indicate how large the adjustments are in practice,
> and how consistently they are made.
>
> Bug: 385170155
> Change-Id: Ibb3e36730213f054e71f216331edb0c6bce5d5b8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6112083
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Reviewed-by: Chris Thompson <cthomp@chromium.org>
> Commit-Queue: Charlie Reis <creis@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1399424}
>

Bug: 385170155
Change-Id: If1af921a942d88459cc29b9bbf4ca9fce0a8aa54
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6115121
Reviewed-by: Lingqi Chi <lingqi@chromium.org>
Commit-Queue: Lingqi Chi <lingqi@chromium.org>
Owners-Override: Lingqi Chi <lingqi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1399691}
2024-12-22 18:37:14 -08:00
e61719e94c Add metric to track element type navigation in Android accessibility
This CL adds a new metric to track the type of elements that a user
navigates a page by when using the next/previous html element navigation
type (e.g. link, heading, paragraph, etc). We split the metric with
TalkBack running alone, not running, or running with a different unknown
accessibility service. The metric should give us an indication of the
types of navigations most commonly used, where we need to optimize for
upcoming AXMode projects, and if apps besides TalkBack are using this
API.

NO_IFTTT=Initial commit/addition, seems to be a false positive.

AX-Relnotes: N/A
Bug: 385186714
Change-Id: I7fa8e324be547cfbfc92cb08f23256f07d5e1542
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6112433
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Mark Schillaci <mschillaci@google.com>
Cr-Commit-Position: refs/heads/main@{#1399462}
2024-12-20 18:00:57 -08:00
72ac2d1d0a Update predicate map to use a local static getter Android accessibility
This CL updates the lazily initialized singleton map that stores the
pairings of string keys to predicates in the Android accessibility code
to be a local static variable with a getter. This does the same for
the string that contains a comma-separated list of all the possible
supported predicate types, which is provided to the Android framework.

AX-Relnotes: N/A
Bug: 385185714
Change-Id: I2af5f95be4b0ea8f5146df8abc7b5efaa323fff8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6114921
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Mark Schillaci <mschillaci@google.com>
Cr-Commit-Position: refs/heads/main@{#1399455}
2024-12-20 17:57:13 -08:00
e7956a7f61 WebUI: Sort list attributes in several build_webui() invocations.
The diff is produced by building a modified gn binary locally and then
invoking `gn format` over several BUILD.gn files that use build_webui() or build_webui_tests() (everything except CrOS-only WebUIs). See [1] for
the local gn patch.

This is in preparation of updating `gn format` (and therefore also `git cl format`) to sort these by default in the near future.

[1] https://issues.chromium.org/issues/385341232#comment2

Bug: 385341232
Change-Id: I0c904f85385698e181d05ee845662041e9a4cd9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6114856
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1399439}
2024-12-20 16:42:30 -08:00
94c5903a38 [Protected Audience] Stop disabling a feature in browser tests.
In particular, stop disabling
LocalNetworkAccessAllowPotentiallyTrustworthySameOrigin, so it can
be removed.

The InterestGroupPrivateNetworkBrowserTests expected updates to fail
when the updateURL was on a private IP, and an update was
triggered by a page on a public IP. The flag was needed to ensure
the requests failed. However, the new private network access behavior
is to allow same-origin requests, even when making public
network-initiated calls to private networks. Since updateURLs are same-
origin to the owner, which is used as the initiator, that means
when the feature enabled, update requests cannot fail due to
private networking requests.

This is pretty analogous to a cached main frame URL from a public
network making a same-origin request on a private network later, when
retrieving the network from the cache, so it makes sense the behavior
is the same.

This CL modifies the browser tests so that they now expect the
update requests to succeed. They also test that the correct
IPAddressSpace is used for the requests. Plumbing it through
correctly currently has no observable effect, other than in the
values sent to the network service, but it will matter if the
same-origin exemption logic is ever removed.

Bug: 356624834
Change-Id: Ie241e2bc2a2ff62c02c948759cec0319a591f9f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108176
Reviewed-by: Caleb Raitto <caraitto@chromium.org>
Commit-Queue: mmenke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1399437}
2024-12-20 16:36:32 -08:00
a8ee54aed3 [Code Health] Remove stale feature FledgePassRecencyToGenerateBid
Fixed: 356624807
Change-Id: I875d0639295165027c9b7e6a8f685bb412dcada5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6097927
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Caleb Raitto <caraitto@chromium.org>
Commit-Queue: Nan Lin <linnan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1399425}
2024-12-20 16:11:01 -08:00
c7593abc58 Record metrics and trace events for navigation start adjustments.
These metrics will indicate how large the adjustments are in practice,
and how consistently they are made.

Bug: 385170155
Change-Id: Ibb3e36730213f054e71f216331edb0c6bce5d5b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6112083
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Chris Thompson <cthomp@chromium.org>
Commit-Queue: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1399424}
2024-12-20 16:10:45 -08:00
fa797b48fe [Code Health] Remove stale feature ForwardMemoryPressureEventsToGpuProcess
Bug: 356623740
Change-Id: I8f13650e61ac1f06683e4e877524f2397ff410dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6114497
Commit-Queue: Nan Lin <linnan@chromium.org>
Reviewed-by: Kyle Charbonneau <kylechar@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1399334}
2024-12-20 12:47:07 -08:00
7e784bcc68 android: Deflake ChildProcessLauncherHelperTest
Test was relying on Debug.waitForDebugger to hang child service, which
turns out to not always work on bots. Instead, just add a new command
line switch to get the desired behavior.

Bug: 354765949
Change-Id: I8ec11b228f1955a8ddee80b2cc160c3a61113093
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6113740
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Bo Liu <boliu@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1399312}
2024-12-20 11:58:21 -08:00
266fb3313d WebUI: extend InternalWebUIConfig from more UIs
Specifically extending from chrome://tracing and
chrome://webrtc-internals. These UIs were identified by OWNERS in a
recent Chromium WebUI survey as targeted at Chromium developers and
as UIs that could be placed behind a pref.

The pref behavior is currently behind the InternalOnlyUisPref
feature flag.

Bug: 379889249
Change-Id: I05eae03748661e58d7dcf994e0c5a0d97cfe8c1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6107298
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1399306}
2024-12-20 11:39:18 -08:00
581f2f512f Add payment to clientDataJson on payment credential creation.
Include the payment options (including the browser bound key) in the
clientDataJson, when a payment credential is being created.

PaymentOptions are set on payment credential creation only when browser
bound keys are enabled with the following flag:
chrome://flags/#enable-secure-payment-confirmation-browser-bound-key

Bug: 377278827, b:378708356
Change-Id: I0eab67e278d81b7d7e9eb86d3cb29072a79907a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6098330
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Slobodan Pejic <slobodan@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1399305}
2024-12-20 11:37:48 -08:00
de9e0a7713 Re-enable ImeTests
These tests should be fixed now that the target sdk has been updated.

Bug: 343821701
Cq-Include-Trybots: luci.chromium.try:android-14-x64-rel,android-14-arm64-rel,android-15-x64-rel,android-15-tablet-x64-dbg,android-16-x64-fyi-rel
Change-Id: I3fccbc5fddb4035bec22be3d06bdb70bb972ba7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6105390
Owners-Override: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Alex Mitra <alexmitra@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1399300}
2024-12-20 11:35:06 -08:00
2313906f2c Remove display:block!important from customizable_select.css
1. Call UpdateStyleAndLayoutTree from IsAppearanceBaseButton and
   IsAppearanceBasePicker, unless no_update is set for cases which are
   calling from within a style/layout recalc.
2. Call EnsureComputedStyle when checking IsAppearanceBasePicker in
   order to get an appearance value despite the element being
   display:none due to it being a closed popover.

Since the picker might no longer have a computed style all the time,
this requires rewriting some accessibility code which was depending on
always having a computed style for the picker. I rewrote the
accessibility code to be more consistent across appearance:base-select
mode and appearance:auto mode by consistently using the UA popover
element as the MenuListPopup mapped element.

Bug: 364348901
Fixed: 364924715
Change-Id: I3fec57f2e02ce4200c95c256e5c1072b5c21ef8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5953628
Reviewed-by: David Baron <dbaron@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1399296}
2024-12-20 11:31:50 -08:00
aaac8a0611 WebUI: Reveal hidden deps to ui/webui/resources.
The //ui/resources:webui_resources_grd target does not belong under
ui/resources/, since its input file as well as all of its dependencies
are under ui/webui/resources/, which resides in a sibling folder.

Moving it under its proper ui/webui/resources/ folder, makes explicit
what other folders are already depending on ui/webui/resources/, instead
of having such dependencies disguised as pointing to ui/resources/, for
example from sereval ash/webui/ or ios/ targets.

Bug: 385086925
Change-Id: I998fb0ae31a33cd8f09d2af4bd7abf23707aaba6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6096291
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Owners-Override: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1399284}
2024-12-20 11:10:37 -08:00
8827cc0b10 Reland "Remove target_sdk_version from content shell"
This reverts commit 2b04837b64.

Reason for revert: Only a single test failing so disable that test

Original change's description:
> Revert "Remove target_sdk_version from content shell"
>
> This reverts commit 65839523cc.
>
> Reason for revert: breaks an upstream bot https://crbug.com/385155403
>
> Original change's description:
> > Remove target_sdk_version from content shell
> >
> > This CL also fixes the WebContentsAccessibilityTests that were failing
> > with the new SDK version.
> >
> > Bug: 40137544,355208071,343808767
> > Change-Id: I05d482af7a3c02d3032408acd5a0ae7958cc2f31
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5769775
> > Reviewed-by: Mark Schillaci <mschillaci@google.com>
> > Commit-Queue: Alex Mitra <alexmitra@chromium.org>
> > Reviewed-by: Peter Beverloo <peter@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1397838}
>
> Bug: 40137544,355208071,343808767,385155403
> Change-Id: I5962d1d611a2064136819c22fa121fa58ec0d422
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108773
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Owners-Override: Alex Ilin <alexilin@chromium.org>
> Auto-Submit: Alex Ilin <alexilin@chromium.org>
> Commit-Queue: Alex Ilin <alexilin@chromium.org>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1399100}

Bug: 40137544,355208071,343808767,385155403
Change-Id: I03b7968a623d90c7d1504cd528332a508af64acb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108775
Commit-Queue: Alex Mitra <alexmitra@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Owners-Override: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1399274}
2024-12-20 10:51:30 -08:00
bceab686c6 Fix missing deps in content/browser/tracing/trace_report
trace_report.mojom includes
content/browser/tracing/trace_report/trace_report_database.h which
depends on an auto-generated file sql/sql_name_variants.h.

This CL makes sure that sql_name_variants.h is generated before
generating C++ file from trace_report.mojom.

Bug: 385158081
Change-Id: Ibd6fc5714302b3642e4b88e3e2487a7e39dced39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6114572
Commit-Queue: Peter Wen <wnwen@chromium.org>
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Auto-Submit: Alex Ilin <alexilin@chromium.org>
Owners-Override: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1399254}
2024-12-20 10:01:09 -08:00
fdda4c07eb [Code Health] Remove stale feature BackForwardCacheWithKeepaliveRequest
Bug: 356624794
Change-Id: I34d060b390afd7e2befe7426d1e10fcfa69089c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102406
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Ming-Ying Chung <mych@chromium.org>
Commit-Queue: Nan Lin <linnan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1399236}
2024-12-20 09:41:03 -08:00
2b04837b64 Revert "Remove target_sdk_version from content shell"
This reverts commit 65839523cc.

Reason for revert: breaks an upstream bot https://crbug.com/385155403

Original change's description:
> Remove target_sdk_version from content shell
>
> This CL also fixes the WebContentsAccessibilityTests that were failing
> with the new SDK version.
>
> Bug: 40137544,355208071,343808767
> Change-Id: I05d482af7a3c02d3032408acd5a0ae7958cc2f31
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5769775
> Reviewed-by: Mark Schillaci <mschillaci@google.com>
> Commit-Queue: Alex Mitra <alexmitra@chromium.org>
> Reviewed-by: Peter Beverloo <peter@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1397838}

Bug: 40137544,355208071,343808767,385155403
Change-Id: I5962d1d611a2064136819c22fa121fa58ec0d422
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108773
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Alex Ilin <alexilin@chromium.org>
Auto-Submit: Alex Ilin <alexilin@chromium.org>
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1399100}
2024-12-20 04:16:43 -08:00
16e43d8e64 Add direct dependency between //content/browser and //sql
Bug: 385158081
Change-Id: Id5355879e586f55897fd0ce606395ef7de174973
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108771
Auto-Submit: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Samar Chehade-Lepleux <samarchehade@google.com>
Commit-Queue: Samar Chehade-Lepleux <samarchehade@google.com>
Cr-Commit-Position: refs/heads/main@{#1399095}
2024-12-20 03:55:41 -08:00
d4edfd03c6 Prefetch: TestPrefetchWatcher::PrefetchUsedInLastNavigation returns bool
Before this CL, TestPrefetchWatcher::PrefetchUsedInLastNavigation
returns std::optional<bool> so that it can return std::nullopt when the
first navigation hasn't happened yet.

However, since std::optional<T>::operator bool is equivalent to
std::optional<T>::has_value(), if we do something like
EXPECT_TRUE(test_prefetch_watcher.PrefetchUsedInLastNavigation()) for
example, it passes even if its value is false (i.e., prefetch was not
used in last navigation).

Although it is avoidable if test writers are aware of this, this CL
changes this to return bool to prevent such mistakes from happening in
the first place.

Bug: n/a
Change-Id: I544f4d63eeaf0914bb72440ce40901a2a5f40a65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6059306
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Taiyo Mizuhashi <taiyo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1398990}
2024-12-19 18:22:27 -08:00
25b184ada0 [AX Mac] implement accessibilityCellForColumn method
Implement accessibilityCellForColumn methods, and hide its
NSAccessibilityCellForColumnAndRowParameterizedAttribute attribute
counterparts under a flag.

Test: `out/.../accessibility_unittests \
   --gtest_filter="*AccessibilityCellForColumn*"`

Include-Ci-Only-Tests: true
Cq-Include-Trybots: luci.chromium.try:mac-fieldtrial-tester

Bug: 363275809
Change-Id: I4bd84a5a6d2add97b71162324497629b64bed475
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6069954
Commit-Queue: Alexander Surkov <asurkov@igalia.com>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Jayson Adams <shrike@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1398984}
2024-12-19 18:13:55 -08:00