This adds the -funwind-tables flag when compiling libunwind. This allows
unwinding past, eg. _Unwind_RaiseException.
The upstream cmake build adds it when it is supported, and generation of
unwind tables is already done for all the libunwind C++ code since
it compiles with exceptions enabled.
Also pass -fexceptions to the C code on Fuchsia only to work around
https://bugs.llvm.org/show_bug.cgi?id=45875.
Bug: 1078588
Change-Id: Id821f143c12e7e1e376eea534be52c6cd8504465
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218273
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774598}
NGBlockBreakToken::HasSeenAllChildren() is currently not used in inline
formatting contexts (so doing it wrong currently doesn't cause any
damage), but this is likely to change.
formatting contexts. Remove that method, and call NextChild() for real
instead, and provide an inline break token when appropriate.
NGBlockChildIterator: :IsAtEnd() would just always return true in inline
Change-Id: I87bf5178588682cfaa8219dce0d90b472d097b1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220047
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774595}
It seems over time, different features added to passwords settings
ended up implementing the check of whether there are saved passwords
resulting in hasSome_, hasStoredPasswords_ and hasPasswords_ (e.g.
crrev.com/c/1047867, crrev.com/2107524). This CL summarizes these in
a single hasSavedPasswords_ property, reflecting the name of the
corresponding array. The same is done for the array of exceptions.
The motivations here are: a) Keep simplifying the PasswordsSection code;
b) Avoid the use of hasStoredPasswords_ in setSavedPasswordsListener,
allowing to extract that code into a new behavior in the next CL.
Bug: None
Change-Id: Ib39c29f3cc5fd90bde3313971eb95d17b3ed9fe1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225905
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774589}
https://crrev.com/770126 introduced a regression in memory usage. I
think this regression was due to storing the whole redirect chain of a
ResourceRequestHead alongside with it. Although this seemed like a
clean idea from the code point of view, this causes heap allocation
for information which we do not really need. In this change I get rid
of it and only store the first and previous urls in the
ResourceRequestHead.
Change-Id: I2ee5c122142d732d1496e6606615d83e028581f4
Bug: 1084972
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214542
Commit-Queue: Antonio Sartori <antoniosartori@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774588}
To make the IdentityManager's constructor easily extendable for
different platforms, use a dedicated struct -
|IdentityManager::InitParameters|.
It helps in passing platform specific fields to IdentityManager,
like |chromeos::AccountManager|.
Bug: 1068240
Change-Id: I48eb10cb6f32c447692a9af045cfcedd66b4052d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212050
Commit-Queue: Anastasiia N <anastasiian@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Kush Sinha <sinhak@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774585}
This is accomplished by registering the FieldTrialsProvider last and
by implementing FieldTrialsProvider::ProvideCurrentSessionData.
This CL also adds a utility function to LogDecoder for decompressing
data and parsing it to a proto.
Bug: 1078795
Change-Id: Ic63afbc8fb3e92d6e98f80a3817bcfc3be1f2e83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208293
Auto-Submit: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Cr-Commit-Position: refs/heads/master@{#774578}
The CL replaces the "These passwords were not commited" message in the
bubble with a more informative one. The CL also changes the text on the
cancel button from "Cancel" to "Discard". The strings are moved to a
.grd file but are still kept as non-translateable, since they are not
final.
Screenshot of new bubble strings:
https://screenshot.googleplex.com/fzW2r5fnawV
Bug: 1060132
Change-Id: Ifc630eec1e2b23ee4d43305e316ce7c01606a390
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228839
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Cr-Commit-Position: refs/heads/master@{#774572}
Bindings is going to update IDL dictionaries to be strict about their
members' existence. After the update, accessing a getter on a missing
dictionary member will crash.
This CL fixes the potential bug in Animatable.animate().
Bug: 839389
Change-Id: I305daff7130a2a26b5a7142f67fe7920910cead3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226483
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774571}
Avoid using custom C++ functions to call from JS part. Add new actions
for all type of user actions which could happen in the UI.
Refactor ScreenHandler to move business logic from UI-purposed file.
Add user actions tracking.
Bug: 1066606
Change-Id: I61fcbc952349418517e267c24f167c681ef2c016
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169931
Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774567}
DirectoryCryptographer is subject to remove and its usages should be
replaced with CryptographerImpl or removed. This CL does it for all
remaining USS tests.
Bug: 1083924
Change-Id: Iedd4f6c039407cce0dfb502a4070ac42f4336c80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226753
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774562}
The distinction between FullscreenManager and ChromeFullscreenManager
got fuzzy over time, and there has not been any other concrete
implementation. This CL merges the two classes into one. This is a
part of the fullscreen manager clean up task that will split the role
of browser controls positioning and HTML5 fullscreen API processing.
Bug: 966272
Change-Id: Ie5cf76d6f1caf14b02b390bf6d3b40f52fe4183b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217679
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774561}
This is a follow up CL to:
https://chromium-review.googlesource.com/c/chromium/src/+/2224417
The previous CL removed a check for whether the current page is the
install URL of an externally installed app that had a manifest with a
start URL different from the install URL but doesn't have a manifest
start_url anymore. This CL puts that check back.
It was removed previously because I didn't notice LookupExternalAppId()
was returning an AppId that I could use to check IsLocallyInstalled().
Bug: 1090182
Change-Id: I7e08f80cc4d64862015774ea0c04670829690bfd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228014
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774556}
Use the set of portable code from zlib that shouldn't have
extra dependencies (e.g. 'base').
Also allow building the tool for other targets (e.g. Linux,
OSX, etc) as that allows easier testing and profiling.
Compilation is disabled for Windows, see crbug.com/1090428.
Bug: 1076580, 1087999
Change-Id: Id633b5aa287cd6b24c72af51a23c73d50617c68b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227312
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Adenilson Cavalcanti <cavalcantii@chromium.org>
Reviewed-by: David Turner <digit@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774555}
This CL introduces MultiStoreExceptionEntry, which is the analogous of
MultiStorePasswordUiEntry (crrev.com/c/2202237) for exceptions. The
common logic between these two classes is moved to a common base class.
Future CLs will use the new class to deduplicate the passwordExceptions
array in PasswordsSection.
The CL also reorders some includes in settings_resources_v3.grdp that
were not in alphabetical order.
Bug: 1049141
Change-Id: Ibf64de15f49cf20c2f4b310f9a86341a41f6f3b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225408
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774554}
This CL has no behavior changes in production.
- Tests which should be fixed are listed in TestExpectations
- overhang-*.html tests have notable changes.
They are progressions. RubyNG allows to overhang on whitespace-only
text nodes.
- Other pixel results in this CL are due to differences between LayoutNG
and the legacy layout.
Bug: 1069817
Change-Id: I4a1b8953f984de2841bb4e964534354286a64fb3
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng_disabled
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228009
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774553}
Implement backward compatibility uninstall of Web Apps via
shadow Bookmark Apps.
On a web app uninstall we also must uninstall the shadow bookmark app.
All uninstall changes for the extensions registry get
propagated to the sync server (syncer::ModelType::APPS) and to all
devices where BMO is disabled.
Design doc: go/chrome-bmo-migration.
This is a re-land of
https://chromium-review.googlesource.com/c/chromium/src/+/2162507
We do only legacy uninstalls in this CL to fix the bug.
Bug: 1020037, 1086909
Change-Id: Ib65edc2762de38f050afedb00ffe06665845431b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228371
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774552}
This CL prepares for the introduction of the new "passwords on device"
WebUI page. It extracts the logic that is common with the existing page
into a new PasswordsListHandler Polymer component. This includes mostly
handling requests for copying a password, viewing its details (Edit
Dialog) and removing it. The new component does not own the list of
saved passwords, those are still retrieved by its embedder. The lists
with different subsets of saved passwords (all, device-only or
device+account) will be injected by the embedder as well.
Bug: 1049141
Change-Id: Iefb9e6bd7d58f43ff4ed57f74983f939b0e1eb40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224860
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774549}
