This CL adds the sr-Latn translations to resource packs for Android
bundle builds. The sr-Latn translations were added in [1].
This CL introduces a small binary size increase from adding a new
locale. The SuperSize diff tool reports an increase or 10.68KB in
resources.arsc.
[1] https://crrev.com/c/2121076
Binary-Size: Size increase is unavoidable (see above).
Bug: 1053811
Change-Id: I5a04ff69ade3818ee8ce6c84dd1760c985c1de1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132600
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Megan Jablonski <megjablon@chromium.org>
Commit-Queue: Trevor Perrier <perrier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761135}
This change:
1) Migrates ExtensionInstallDialogView to OnDialog* methods and removes
the handled_result_ instance var, which is redundant with the
presence of the callback
2) Migrates ExtensionUninstallDialogDelegateView to lambdas
3) Migrates ImportLockDialogView to lambdas with a close callback
4) Migrates PaymentRequestDialogView to OnDialog* methods
5) Migrates PlatformKeysCertificateSelector to a lambda
6) Migrates WebAppUninstallDialogDelegateView to OnDialog* methods
7) Migrates AppModalDialogViewViews to lambdas with a close callback
For each dialog I attempted a manual inspection to figure out whether a
close callback is needed or not.
Bug: 1011446
Change-Id: I038371177d932546afe556f9f0665f841bb95e7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135711
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757957}
This CL adds empty xtb files for sr-Latn and adds sr-Latn to the
translation_expectations.pyl file. On the next TC import the Latin script
for Serbian should be imported into all xtb files.
Bug: 1053811
Change-Id: I271e2e8ae042f085d962eb62ae3d4ad03ecf9190
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121076
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Megan Jablonski <megjablon@chromium.org>
Commit-Queue: Trevor Perrier <perrier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755218}
This fixs a number of cases and enables strict mode in tests. Hopefully
that helps prevent any other access from being added.
The trickier cases are jacoco injects code that accesses the disk, and
LayoutInflater may trigger loading classes, which triggers disk
access.
The addition since first patch is SelectFileDialog may trigger reading
from disk. That file has been updated.
BUG=1059770,1062561
TEST=covered by tests now
Change-Id: Ie8262ae4e018055049115fcefc6a29bf97acbe9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108603
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751465}
This fixs a number of cases and enables strict mode in tests. Hopefully
that helps prevent any other access from being added.
The trickier cases are jacoco injects code that accesses the disk, and
LayoutInflater may trigger loading classes, which triggers disk
access.
BUG=1059770
TEST=covered by tests now
Change-Id: I50f81836f838b023fe09fd5f760cb7484edd8d26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100589
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751028}
This reverts commit 7a13e2645a.
Reason for revert: same as original % tools/clang
Original change's description:
> Revert "IWYU for bind/callback_helpers.h and ptr_util.h"
>
> This reverts commit b8ffaf4cfc.
>
> Reason for revert:
> This broke the build of the blink_gc_plugin, which does not use base/
> (see bug). Please don't commit to tools/clang/ without review.
>
> Original change's description:
> > IWYU for bind/callback_helpers.h and ptr_util.h
> >
> > These missing includes are preventing removal of unused headers from
> > task_runner_util.h and consequently migration from task_runner_util.h to
> > task_runner.h's new PostTaskAndReplyWithResult member method.
> >
> > The following script was run on every file in the codebase, prioritizing
> > .h over matching .cc to best enforce the rule of not include a header
> > included by your .h :
> >
> > def Fix(file_path):
> > content = refactor_lib.ReadFile(file_path)
> >
> > # Assume fwd-decls are correct in first pass.
> > fwd_decls_match = re.compile(r'\n *[^/\n][^/\n][^/\n]*class (NullCallback|DoNothing|ScopedClosureRunner);', re.DOTALL).findall(content)
> > if fwd_decls_match:
> > print 'fwd_decls_match in %s' % (file_path)
> > return False
> >
> > bind_helpers_match = re.compile(
> > # Doesn't begin with a comment.
> > r'\n *[^/\n][^/\n]'
> > # Anything else after a non-comment start (and don't allow this to capture a comment start either)
> > r'[^/\n]*'
> > # Anything before but an open angle-bracket to avoid cases like unique_ptr<Foo> where you don't need the full definition of Foo.
> > r'[^<]'
> > # Only match with base:: prefix; more precise, can manually fix missing includes in //base proper in a follow-up pass if needed.
> > r'base::(NullCallback|DoNothing|DeletePointer)\b[^*]', re.DOTALL).findall(content)
> >
> > callback_helpers_match = re.compile(r'\n *[^/\n][^/\n][^/\n]*[^<]base::(IsBaseCallback|EnableIfIsBaseCallback|AdaptCallbackForRepeating|ScopedClosureRunner)\b[^*]', re.DOTALL).findall(content)
> >
> > ptr_util_match = re.compile(r'\n *[^/\n][^/\n][^/\n]*[^<]base::WrapUnique\b[^*]', re.DOTALL).findall(content)
> >
> > if not bind_helpers_match and not callback_helpers_match and not ptr_util_match:
> > return False
> >
> > updated_content = content
> > if bind_helpers_match:
> > updated_content = refactor_lib.AddInclude(file_path, updated_content, "base/bind_helpers.h")
> > if callback_helpers_match:
> > updated_content = refactor_lib.AddInclude(file_path, updated_content, "base/callback_helpers.h")
> > if ptr_util_match:
> > updated_content = refactor_lib.AddInclude(file_path, updated_content, "base/memory/ptr_util.h")
> >
> > if updated_content == content:
> > return False
> >
> > # Write updated file
> > refactor_lib.WriteFile(file_path, updated_content)
> >
> > return True
> >
> > TBR=danakj@chromium.org
> > (mechanical change for //base API)
> >
> > Bug: 1026641
> > Change-Id: Ic88585c62dd2f74d34c59c708faeddb231aee47f
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087971
> > Reviewed-by: Gabriel Charette <gab@chromium.org>
> > Reviewed-by: danakj <danakj@chromium.org>
> > Commit-Queue: Gabriel Charette <gab@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#747685}
>
> TBR=danakj@chromium.org,gab@chromium.org
>
> Change-Id: I59d6cd69bd898e9f6d10922c67d8c24ba582bf7f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1026641, 1059359
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091356
> Reviewed-by: Hans Wennborg <hans@chromium.org>
> Commit-Queue: Hans Wennborg <hans@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#747804}
TBR=danakj@chromium.org,gab@chromium.org,hans@chromium.org
Change-Id: I721391eba68ea55830dca4f1ac34ff633f714f72
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1026641, 1059359
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090509
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747844}
This reverts commit b8ffaf4cfc.
Reason for revert:
This broke the build of the blink_gc_plugin, which does not use base/
(see bug). Please don't commit to tools/clang/ without review.
Original change's description:
> IWYU for bind/callback_helpers.h and ptr_util.h
>
> These missing includes are preventing removal of unused headers from
> task_runner_util.h and consequently migration from task_runner_util.h to
> task_runner.h's new PostTaskAndReplyWithResult member method.
>
> The following script was run on every file in the codebase, prioritizing
> .h over matching .cc to best enforce the rule of not include a header
> included by your .h :
>
> def Fix(file_path):
> content = refactor_lib.ReadFile(file_path)
>
> # Assume fwd-decls are correct in first pass.
> fwd_decls_match = re.compile(r'\n *[^/\n][^/\n][^/\n]*class (NullCallback|DoNothing|ScopedClosureRunner);', re.DOTALL).findall(content)
> if fwd_decls_match:
> print 'fwd_decls_match in %s' % (file_path)
> return False
>
> bind_helpers_match = re.compile(
> # Doesn't begin with a comment.
> r'\n *[^/\n][^/\n]'
> # Anything else after a non-comment start (and don't allow this to capture a comment start either)
> r'[^/\n]*'
> # Anything before but an open angle-bracket to avoid cases like unique_ptr<Foo> where you don't need the full definition of Foo.
> r'[^<]'
> # Only match with base:: prefix; more precise, can manually fix missing includes in //base proper in a follow-up pass if needed.
> r'base::(NullCallback|DoNothing|DeletePointer)\b[^*]', re.DOTALL).findall(content)
>
> callback_helpers_match = re.compile(r'\n *[^/\n][^/\n][^/\n]*[^<]base::(IsBaseCallback|EnableIfIsBaseCallback|AdaptCallbackForRepeating|ScopedClosureRunner)\b[^*]', re.DOTALL).findall(content)
>
> ptr_util_match = re.compile(r'\n *[^/\n][^/\n][^/\n]*[^<]base::WrapUnique\b[^*]', re.DOTALL).findall(content)
>
> if not bind_helpers_match and not callback_helpers_match and not ptr_util_match:
> return False
>
> updated_content = content
> if bind_helpers_match:
> updated_content = refactor_lib.AddInclude(file_path, updated_content, "base/bind_helpers.h")
> if callback_helpers_match:
> updated_content = refactor_lib.AddInclude(file_path, updated_content, "base/callback_helpers.h")
> if ptr_util_match:
> updated_content = refactor_lib.AddInclude(file_path, updated_content, "base/memory/ptr_util.h")
>
> if updated_content == content:
> return False
>
> # Write updated file
> refactor_lib.WriteFile(file_path, updated_content)
>
> return True
>
> TBR=danakj@chromium.org
> (mechanical change for //base API)
>
> Bug: 1026641
> Change-Id: Ic88585c62dd2f74d34c59c708faeddb231aee47f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087971
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Reviewed-by: danakj <danakj@chromium.org>
> Commit-Queue: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#747685}
TBR=danakj@chromium.org,gab@chromium.org
Change-Id: I59d6cd69bd898e9f6d10922c67d8c24ba582bf7f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1026641, 1059359
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091356
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747804}
These missing includes are preventing removal of unused headers from
task_runner_util.h and consequently migration from task_runner_util.h to
task_runner.h's new PostTaskAndReplyWithResult member method.
The following script was run on every file in the codebase, prioritizing
.h over matching .cc to best enforce the rule of not include a header
included by your .h :
def Fix(file_path):
content = refactor_lib.ReadFile(file_path)
# Assume fwd-decls are correct in first pass.
fwd_decls_match = re.compile(r'\n *[^/\n][^/\n][^/\n]*class (NullCallback|DoNothing|ScopedClosureRunner);', re.DOTALL).findall(content)
if fwd_decls_match:
print 'fwd_decls_match in %s' % (file_path)
return False
bind_helpers_match = re.compile(
# Doesn't begin with a comment.
r'\n *[^/\n][^/\n]'
# Anything else after a non-comment start (and don't allow this to capture a comment start either)
r'[^/\n]*'
# Anything before but an open angle-bracket to avoid cases like unique_ptr<Foo> where you don't need the full definition of Foo.
r'[^<]'
# Only match with base:: prefix; more precise, can manually fix missing includes in //base proper in a follow-up pass if needed.
r'base::(NullCallback|DoNothing|DeletePointer)\b[^*]', re.DOTALL).findall(content)
callback_helpers_match = re.compile(r'\n *[^/\n][^/\n][^/\n]*[^<]base::(IsBaseCallback|EnableIfIsBaseCallback|AdaptCallbackForRepeating|ScopedClosureRunner)\b[^*]', re.DOTALL).findall(content)
ptr_util_match = re.compile(r'\n *[^/\n][^/\n][^/\n]*[^<]base::WrapUnique\b[^*]', re.DOTALL).findall(content)
if not bind_helpers_match and not callback_helpers_match and not ptr_util_match:
return False
updated_content = content
if bind_helpers_match:
updated_content = refactor_lib.AddInclude(file_path, updated_content, "base/bind_helpers.h")
if callback_helpers_match:
updated_content = refactor_lib.AddInclude(file_path, updated_content, "base/callback_helpers.h")
if ptr_util_match:
updated_content = refactor_lib.AddInclude(file_path, updated_content, "base/memory/ptr_util.h")
if updated_content == content:
return False
# Write updated file
refactor_lib.WriteFile(file_path, updated_content)
return True
TBR=danakj@chromium.org
(mechanical change for //base API)
Bug: 1026641
Change-Id: Ic88585c62dd2f74d34c59c708faeddb231aee47f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087971
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747685}
The code in this component is unique to javascript dialogs, and does
not cover all app modals. Further, it has some view code that isn't
specifically for app modal javascript dialogs, but is re-used for tab
modals. Some tab modal code from //chrome will be moved here soon, so
rename from app_modal to javascript_dialogs. Class names reflect whether
their use is specific to the app modal control flow.
Also, rename some classes to better reflect their roles:
. JavaScriptDialogManager (implements content::JavaScriptDialogManager)
=> AppModalDialogManager
. JavaScriptAppModalDialog => AppModalDialogController
. NativeAppModalDialog => AppModalDialogView
etc.
Bug: 1025256
Change-Id: I0a1865ec71897ae6549184bc317ede29cc56438a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031936
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737355}
