Dirk Pranke
2c0d2f0045
Update TEAM in OWNERS for build-related directories.
...
Now that there's a build@chromium.org list, this CL
updates the various TEAM= entries in the OWNERS files
to reflect that.
R=agrieve@chromium.org , thakis@chromium.org , mark@chromium.org
Change-Id: I8c41a604dd89aa20c9b381090701eff699c1d302
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209616
Reviewed-by: Mark Mentovai <mark@chromium.org >
Reviewed-by: Nico Weber <thakis@chromium.org >
Reviewed-by: Andrew Grieve <agrieve@chromium.org >
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org >
Commit-Queue: Dirk Pranke <dpranke@chromium.org >
Cr-Commit-Position: refs/heads/master@{#770658}
2020-05-20 17:39:31 +00:00
Caitlin Fischer
7776cfd416
Fix the markdown links.
...
Bug: 1079253https://chromium-review.googlesource.com/c/chromium/src/+/2188528
Auto-Submit: Caitlin Fischer <caitlinfischer@google.com >
Reviewed-by: Jeremy Roman <jbroman@chromium.org >
Reviewed-by: Andrew Grieve <agrieve@chromium.org >
Commit-Queue: Andrew Grieve <agrieve@chromium.org >
Cr-Commit-Position: refs/heads/master@{#766708}
2020-05-08 03:15:24 +00:00
Caitlin Fischer
210cfaba30
Tweak Java and C++ test-only documentation.
...
Bug: 1079253https://chromium-review.googlesource.com/c/chromium/src/+/2186364
Reviewed-by: Jeremy Roman <jbroman@chromium.org >
Reviewed-by: Andrew Grieve <agrieve@chromium.org >
Commit-Queue: Jeremy Roman <jbroman@chromium.org >
Auto-Submit: Caitlin Fischer <caitlinfischer@google.com >
Cr-Commit-Position: refs/heads/master@{#766552}
2020-05-07 20:04:30 +00:00
Andrew Grieve
ace8fe8521
Java: Remove no-longer-true note about stateless lambdas
...
Bug: 952833
Change-Id: Ic091cb7cc1b0d619cd38f8e80de8201a66166f63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173084
Auto-Submit: Andrew Grieve <agrieve@chromium.org >
Reviewed-by: Peter Conn <peconn@chromium.org >
Commit-Queue: Peter Conn <peconn@chromium.org >
Cr-Commit-Position: refs/heads/master@{#763818}
2020-04-29 14:55:45 +00:00
Yun Liu
f40227d9c8
Fix import order issue for androidx
...
Bug: 948803
Change-Id: I61de64544305af054571c3aa5f535a8b95f611a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542137
Reviewed-by: Nico Weber <thakis@chromium.org >
Reviewed-by: Sam Maier <smaier@chromium.org >
Reviewed-by: Andrew Grieve <agrieve@chromium.org >
Commit-Queue: Yun Liu <yliuyliu@google.com >
Cr-Commit-Position: refs/heads/master@{#647808}
2019-04-04 17:37:46 +00:00
agrieve
16c6fe8960
java.md: Add text about finalizers to style guide
...
Based on java@ discussion:
https://groups.google.com/a/chromium.org/d/topic/java/9WZLCc14oss/discussion
Bug: 149440
Change-Id: Ie36166fe2282af564daafb13fbcb91af1a4ab6c1
Reviewed-on: https://chromium-review.googlesource.com/c/1344889
Reviewed-by: Tommy Nyquist <nyquist@chromium.org >
Reviewed-by: Ted Choc <tedchoc@chromium.org >
Commit-Queue: agrieve <agrieve@chromium.org >
Cr-Commit-Position: refs/heads/master@{#611176}
2018-11-27 17:47:49 +00:00
agrieve
467c108f1e
Java Style Guide: Call out that stateless lambdas are special.
...
Change-Id: I94c4c9fb89e6e33f2f87345218607a1ea772d800
Reviewed-on: https://chromium-review.googlesource.com/1212564
Commit-Queue: agrieve <agrieve@chromium.org >
Reviewed-by: Ted Choc <tedchoc@chromium.org >
Cr-Commit-Position: refs/heads/master@{#589572}
2018-09-07 17:44:08 +00:00
agrieve
50430de07a
Java style guide: Avoid extraneous strings in Exceptions.
...
Change-Id: I34b87a55631eda7a76c5291c95444848c051b6cf
Reviewed-on: https://chromium-review.googlesource.com/1175861
Reviewed-by: Tommy Nyquist <nyquist@chromium.org >
Reviewed-by: Ted Choc <tedchoc@chromium.org >
Commit-Queue: agrieve <agrieve@chromium.org >
Cr-Commit-Position: refs/heads/master@{#583309}
2018-08-15 17:49:16 +00:00
agrieve
398286b617
Java Style Guide: Logging, Support Annotations
...
Plus re-ordered content a bit.
Change-Id: I363ffcb5c2a4cb36afcb980503a12564d9e7199b
Reviewed-on: https://chromium-review.googlesource.com/1162112
Commit-Queue: agrieve <agrieve@chromium.org >
Reviewed-by: Tommy Nyquist <nyquist@chromium.org >
Cr-Commit-Position: refs/heads/master@{#583120}
2018-08-15 01:44:45 +00:00
agrieve
0e6bdf2db2
Add Desugar gotchas to java style guide.
...
Change-Id: Ic00b45ead72fcaa0ec0d90d2188a9447e8bf6e02
Reviewed-on: https://chromium-review.googlesource.com/1160782
Reviewed-by: Tommy Nyquist <nyquist@chromium.org >
Reviewed-by: Peter Wen <wnwen@chromium.org >
Commit-Queue: agrieve <agrieve@chromium.org >
Cr-Commit-Position: refs/heads/master@{#580537}
2018-08-03 14:25:24 +00:00
Samuel Huang
3b10f2dff0
[Styleguide] Fix Java comments on assert.
...
Discussion thread:
https://groups.google.com/a/chromium.org/d/topic/java/CpIn_jDOgRk/discussion
Bug:
Change-Id: I3331d3180d9ee88993c942ef20d045f545ff4cbc
Reviewed-on: https://chromium-review.googlesource.com/671025
Commit-Queue: Samuel Huang <huangs@chromium.org >
Reviewed-by: Tommy Nyquist <nyquist@chromium.org >
Reviewed-by: Andrew Grieve <agrieve@chromium.org >
Cr-Commit-Position: refs/heads/master@{#502606}
2017-09-18 17:43:23 +00:00
dfalcantara
0d07914a74
Remove dfalcantara@ from OWNERS
...
BUG=None
Review-Url: https://codereview.chromium.org/2958333003
Cr-Commit-Position: refs/heads/master@{#483230}
2017-06-29 00:49:26 +00:00
ymzhang
af8c9798ce
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.
...
We are adding COMPONENT/TEAM information into OWNERS file
(third_party/*, etc).
Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping
Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents
BUG=679905
R=agrieve@chromium.org
Review-Url: https://codereview.chromium.org/2734393004
Cr-Commit-Position: refs/heads/master@{#455799}
2017-03-09 18:29:14 +00:00
nyquist
2d192c4cd3
Add importorder to Java styleguide.
...
The styleguide refers to the Android Style Guide unless exceptions are listed.
However, the package import order is not listed as an exception, even though
it does not match the Android Style Guide.
This CL adds a section about the requirements for the Java import order.
It does not refer to how to set this up in Eclipse and Android Studio, since
that is already listed under the tools-section.
BUG=None
Review-Url: https://codereview.chromium.org/2738523002
Cr-Commit-Position: refs/heads/master@{#454965}
2017-03-06 21:36:51 +00:00
nyquist
aae4c7cdac
Organize Java style guide and add a more sections
...
New sections:
- Clang-formatting
- Mailing list
- Tools (IDEs, checkstyle, lint)
- File Headers
- TODOs
- Curly braces
- Exceptions
- Miscellany
BUG=None
Review-Url: https://codereview.chromium.org/2681923003
Cr-Commit-Position: refs/heads/master@{#450790}
2017-02-15 20:41:42 +00:00
nyquist
9d61f9892a
Move Java style guide to source code repository.
...
Up until now, the Java style guide has been living on the
Chromium wiki page at:
https://sites.google.com/a/chromium.org/dev/developers/coding-style/java
Recently, documentation regarding our code base has moved over to the
code repository instead of being in the wiki, so this CL moves the Java
style guide over, next to the C++ style guide.
BUG=None
Review-Url: https://codereview.chromium.org/2685583004
Cr-Commit-Position: refs/heads/master@{#449487}
2017-02-10 00:29:08 +00:00
