No change to content. I noticed that this markdown table is not
rendering correctly in either codesearch or in gitiles markdown. The
problem was introduced by https://crrev.com/c/5265949 because it is
missing the column markers (the '|' characters) on the outermost left
and right edges of the table. Some markdown engines allow omitting these
markers (like the internal markdown engine), but the public codesearch
markdown and the public Gitiles markdown don't allow this.
There is absolutely no change to the meaning of the release block
guidelines. This is purely a formatting change.
Before: https://screenshot.googleplex.com/8S8rmThAyCgFS4n
After: https://screenshot.googleplex.com/7sozUuJfKKYBpWS
Test: Upload to gerrit > open file > click "Open in Gitiles"
Change-Id: Ifddb0e65ed115b63fd13147da465c42a4bc25d37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5760198
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Harry Souders <harrysouders@google.com>
Reviewed-by: Harry Souders <harrysouders@google.com>
Cr-Commit-Position: refs/heads/main@{#1337333}
To reduce the chances of missed merges, update the merge documentation
with a suggestion to use all available data when setting bug priority,
possibly even collecting more data if necessary/possible. Include links
to web-platform compat tools that have proven to be useful in
estimating user impact.
Bug: 353807152
Change-Id: I4dc77486b25319ffb71716a79a12c42d9407b5a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5719135
Auto-Submit: Philip Rogers <pdr@chromium.org>
Commit-Queue: Rick Byers <rbyers@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1331024}
When switching between release branches, one needs to `gclient sync` in
order to be able to build Chromium. This was not documented, and bit me
more than once :) This CL adds that line to remind future me (and
others) of that.
Change-Id: I839b2cc5211c88ba80c6551eac36fb5777dcaa01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4055508
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1075903}
After a change has been merged a bot will generally add the
merge-merged-## label. However, the Merge-Approved-## label must be
manually removed at this point to indicate that there are no further
changes planned for this approval. Add this step to the documentation to
clarify that the one doing the merge should remove the Merge-Approved-##
label.
Change-Id: Id2fcc79ce3d5e2456658c89d19924e6a39bc6666
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3857564
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1039824}
Clarifies the merge process documentation to emphasize that the Rubber
Stamper only bypasses code review, and not OWNERS approval.
Also link to the mandatory code review FAQ instead of a Google-internal
go link (which actually points back at publicly-accessible documentation
anyway).
Change-Id: I0183b07ea86dad75fc8558b6a6e0a2ee5dd0e01d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3858449
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: K. Moon <kmoon@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1039601}
The "More" button in Gerrit is now labeled with three (vertical, but ah
well) dots. Also sheriffbot has one more merge request question these
days.
Change-Id: If6298f071976e7fddba1edaedba8d400e24ddae9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3278713
Reviewed-by: Alex Mineer <amineer@chromium.org>
Commit-Queue: Alex Mineer <amineer@chromium.org>
Cr-Commit-Position: refs/heads/main@{#970872}
Previous documentation maintained the 6W cycle with pointers to
"new" content describing the 4W cycle; since 4W is now the default,
remove the old 6W content and make 4W the default.
Change-Id: Iee5608e88b6bfe7429574bf24e4647292e69dade
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3154733
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Alex Mineer <amineer@chromium.org>
Cr-Commit-Position: refs/heads/main@{#920405}
We've built new tools to make it easier to understand what
merges are acceptable when; update this page to point to those
tools, and instead focus this more around processes and best
practices. Additionally, add instructions for how to process
merges.
Change-Id: I8f4f30eb07889631b7158e52a1844e895c6a36dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3044525
Reviewed-by: Adrian Taylor <adetaylor@chromium.org>
Reviewed-by: Ben Mason <benmason@chromium.org>
Commit-Queue: Alex Mineer <amineer@chromium.org>
Cr-Commit-Position: refs/heads/main@{#915728}
After getting merge approval, it can be hard to find details of how,
exactly, one merges a change into a branch. Since merge requests
automatically link to docs/process/merge_request.md, have a link from
there to the doc with the technical details.
Bug: None
Change-Id: I429064fa06c6b0562d15584c14c04a8347cbafff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2783154
Auto-Submit: Ian Barkley-Yeung <iby@chromium.org>
Reviewed-by: Alex Mineer <amineer@chromium.org>
Commit-Queue: Alex Mineer <amineer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#869642}
The current merge process for Phase 3 (late beta/stable) doesn't cover
cases where it's unclear whether the severity of the issue meets the
requirements for merging. This CL adds a segment to tell the engineer to
consult the TPM/their manager.
Bug: 1015723
Change-Id: Ia8406f47be7e0ed6ce87b6f4b3bf4cc9ecca78ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868213
Reviewed-by: Josafat Garcia <josafat@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707265}
This makes our merge guidelines more permissive for feature work
which is gated behind a flag.
Change-Id: I1b65711006cf04e754570d55c16a12b51ed782f5
Reviewed-on: https://chromium-review.googlesource.com/958035
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Alex Mineer <amineer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543551}
We'll start to store process documentation in MD in the source tree.
Add a "process" folder to the docs/ directory, and add release
blocking guidelines as initial content.
R=dpranke
CC=abdulsyed,cmasso,kerz
Bug:
Change-Id: I3270b5a94da9eb6df79a27361d91d00458aa2a1b
Reviewed-on: https://chromium-review.googlesource.com/529884
Commit-Queue: Alex Mineer <amineer@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479053}
