chromium/src
0
Fork 0
Code Activity
97,143 Commits 3 Branches 23,233 Tags
db5b1fbad334d44a1f29a6e718e34b67430dbe23
Commit Graph

14 Commits

Author SHA1 Message Date
akalin@chromium.org
84ddfcf4b2 Fix official build breakage introduced by 112649 
BUG=107753
TEST=


Review URL: http://codereview.chromium.org/8968008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114775 0039d316-1c4b-4281-b951-d872f2087c98
 2011-12-16 06:01:23 +00:00
akalin@chromium.org
ddb9b33b95 Make CHECK not print messages in official builds 
This cuts down on the number of strings in the executable, as well as
executable code to print them.

On Linux, this saves 208kb on a stripped official build
(chrome executable file went from 64569072 bytes -> 64782064 bytes)

On OS X, this saves 209kb on an official build (Google Chrome Framework went from 51483872 bytes -> 51274984 bytes)

On Windows, this saves 139kb on an official build (chrome.dll went from 28619264 bytes -> 28477440 bytes)

Fix test failure in logging_unittest.cc in official builds.

Add new executable check_example for easy testing of changes to the
CHECK macros.

BUG=101561
TEST=

Review URL: http://codereview.chromium.org/8734021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112649 0039d316-1c4b-4281-b951-d872f2087c98
 2011-12-02 07:31:09 +00:00
nsylvain@chromium.org
20960e074c Add a gyp flag to enable dcheck by default in release without 
having the pass a flag. This will be used on the try bots.

BUG=96753
Review URL: http://codereview.chromium.org/7719007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102017 0039d316-1c4b-4281-b951-d872f2087c98
 2011-09-20 20:59:01 +00:00
jeffbailey@chromium.org
998e6d9163 As of g++-4.5, the first argument to EXPECT_EQ cannot be 
a constant expression.

Credit: Jeffrey Yasskin, Google.
Review URL: http://codereview.chromium.org/6691021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80270 0039d316-1c4b-4281-b951-d872f2087c98
 2011-04-02 21:13:21 +00:00
akalin@chromium.org
7c10f7553b Made logging not look up --enable-dcheck from command line 
Made --enable-dcheck a parameter to InitLogging() and fixed up all
callsites.

BUG=62736
TEST=Manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70920

Review URL: http://codereview.chromium.org/6070006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70977 0039d316-1c4b-4281-b951-d872f2087c98
 2011-01-11 01:03:36 +00:00
akalin@chromium.org
941635a75d Revert 70920 - Made logging not look up --enable-dcheck from command line 
Made --enable-dcheck a parameter to InitLogging() and fixed up all
callsites.

BUG=62736
TEST=Manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782

Review URL: http://codereview.chromium.org/6070006

TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/6099012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70923 0039d316-1c4b-4281-b951-d872f2087c98
 2011-01-10 19:59:52 +00:00
akalin@chromium.org
3ab155c9b0 Made logging not look up --enable-dcheck from command line 
Made --enable-dcheck a parameter to InitLogging() and fixed up all
callsites.

BUG=62736
TEST=Manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782

Review URL: http://codereview.chromium.org/6070006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70920 0039d316-1c4b-4281-b951-d872f2087c98
 2011-01-10 19:30:16 +00:00
akalin@chromium.org
deba0ff321 Fixed bug where CHECKs don't fire if min_log_level > FATAL 
BUG=61510
TEST=New unittests in base_unittests

Review URL: http://codereview.chromium.org/4262001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64883 0039d316-1c4b-4281-b951-d872f2087c98
 2010-11-03 05:30:14 +00:00
akalin@chromium.org
5e9878091b Fixed subtle difference in behavior between DCHECK and DCHECK_EQ et al. 
BUG=58998
TEST=New unit tests

Review URL: http://codereview.chromium.org/4199005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64650 0039d316-1c4b-4281-b951-d872f2087c98
 2010-11-01 19:49:22 +00:00
akalin@chromium.org
521b0c4d56 Made logging macros evaluate its stream arguments lazily. 
Also added logging unittests.

BUG=57383
TEST=logging_unittest.cc

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61127

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61142

Review URL: http://codereview.chromium.org/3575008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61249 0039d316-1c4b-4281-b951-d872f2087c98
 2010-10-01 23:02:36 +00:00
akalin@chromium.org
d926c20f25 Revert 61142 - Made logging macros evaluate its stream arguments lazily. 
Also added logging unittests.

BUG=57383
TEST=logging_unittest.cc

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61127

Review URL: http://codereview.chromium.org/3575008

TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/3527004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61143 0039d316-1c4b-4281-b951-d872f2087c98
 2010-10-01 02:58:24 +00:00
akalin@chromium.org
2c3229eced Made logging macros evaluate its stream arguments lazily. 
Also added logging unittests.

BUG=57383
TEST=logging_unittest.cc

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61127

Review URL: http://codereview.chromium.org/3575008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61142 0039d316-1c4b-4281-b951-d872f2087c98
 2010-10-01 02:26:04 +00:00
akalin@chromium.org
8b78210f6a Revert 61127 - Made logging macros evaluate its stream arguments lazily. 
Also added logging unittests.

BUG=57383
TEST=logging_unittest.cc

Review URL: http://codereview.chromium.org/3575008

TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/3606003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61129 0039d316-1c4b-4281-b951-d872f2087c98
 2010-09-30 22:38:30 +00:00
akalin@chromium.org
f223553525 Made logging macros evaluate its stream arguments lazily. 
Also added logging unittests.

BUG=57383
TEST=logging_unittest.cc

Review URL: http://codereview.chromium.org/3575008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61127 0039d316-1c4b-4281-b951-d872f2087c98
 2010-09-30 22:26:41 +00:00