Chrome does not load ws2_32.dll into the renderer sandbox, so code calling these functions would fail attempting to load the DLL. This CL replaces the calls with direct use of the MSVC byte-swap intrinsics.
BUG=115477,116591
TEST=Chromoting client does not crash on connect on Windows.
Review URL: http://codereview.chromium.org/9614004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125110 0039d316-1c4b-4281-b951-d872f2087c98
TEST=Drag and drop from external sources works on NTP and net-internals.
BUG=115433
Review URL: http://codereview.chromium.org/9596003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125109 0039d316-1c4b-4281-b951-d872f2087c98
In all cases, we can just use plain threads.
BUG=113723
TEST=
Review URL: http://codereview.chromium.org/9602026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125108 0039d316-1c4b-4281-b951-d872f2087c98
1) always leave some padding on the right of the 'header-extras' item (in the case of settings, search), even when you are horizontally scrolling
2) shrink the header at a more reasonable point when the window is getting smaller (when the edge of the page is within 20px, instead of 155px)
3) put the border above the managed prefs banner
4) make all uber frame .pages have a min width (history and extensions should look better now)
5) for managed extensions, make the trash icon invisible rather than hidden so it reserves space and the [ ] Enable checkbox is flush with that of the other installed extensions
BUG=none
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/9584038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125104 0039d316-1c4b-4281-b951-d872f2087c98
Most plugins want to be opaque, and notifying webkit of that will allow it to avoid rendering tiles behind the plugin and doing alpha blending.
BUG=116205
TEST=
Review URL: http://codereview.chromium.org/9580030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125100 0039d316-1c4b-4281-b951-d872f2087c98
Still required:
- A change in chrome-internal (+ deps roll) to include Pepper Flash in the
packages.
- A change to enable Pepper Flash by default on ia32.
- Then changes to remove NPAPI Flash.
Review URL: http://codereview.chromium.org/9554002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125096 0039d316-1c4b-4281-b951-d872f2087c98
InfoBars on Android are implemented in Java and only use InfoBarDelegates,
not actual InfoBars.
We still need stubs for the infobars so we can link the sync unit-tests.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/9567039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125091 0039d316-1c4b-4281-b951-d872f2087c98
BUG=113444
TEST=Test with a hosted app that doesn't span an entire origin.
Review URL: https://chromiumcodereview.appspot.com/9609013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125085 0039d316-1c4b-4281-b951-d872f2087c98
Previously, we had multiple copies of the logic for generating warning text for a dangerous or malicious download. Move all of these into DownloadModel. As an additional benefit, we no longer require UI code to interpret DownloadItem::GetDangerType().
BUG=116551
TEST=Start a dangerous, malicious, and extension download. Check whether the warning text is correct, and any embedded filename is elided if necessary.
Review URL: http://codereview.chromium.org/9569011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125082 0039d316-1c4b-4281-b951-d872f2087c98
BUG=116318
TEST=Verify that extension install bubble shows up instead of NTP after extension install.
Review URL: http://codereview.chromium.org/9595025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125081 0039d316-1c4b-4281-b951-d872f2087c98
BUG=115901
TEST=Scratchpad and GTalk apps should open popup windows with a launcher icon (currently the blown up favicon, that will change in a follow up CL).
Review URL: http://codereview.chromium.org/9590001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125080 0039d316-1c4b-4281-b951-d872f2087c98
Without this, the only way to reload a platform app is to close the window and
open it again, losing devtools context.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9569042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125075 0039d316-1c4b-4281-b951-d872f2087c98
We haven't had a second implementation of the interface since MessageLoopFactory was added in r71548.
Review URL: https://chromiumcodereview.appspot.com/9597016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125064 0039d316-1c4b-4281-b951-d872f2087c98
AsWeakPtr() made it difficult to create an abstract interface of
DocumentsService class, which is a prerequisite for making the
class mockable.
Move all the callback relaying business from GDataFileSystem
to DocumentsService
TEST=Run chrome on debug build, open the file manager, show gdata files
BUG=chromium-os:27338
Review URL: https://chromiumcodereview.appspot.com/9611001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125057 0039d316-1c4b-4281-b951-d872f2087c98
Previously, the tests used hard-coded browser process names, based on the current
platform. Getting the info via an automation hook is a less fragile way of
doing it.
BUG=None
TEST=Verified the process_count tests all pass on my local linux box.
Review URL: https://chromiumcodereview.appspot.com/9553010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125056 0039d316-1c4b-4281-b951-d872f2087c98
BUG=116852
TEST=Launch chromeos aura in compact mode and observe that you can access applications on the new tab page.
Review URL: http://codereview.chromium.org/9602029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125053 0039d316-1c4b-4281-b951-d872f2087c98
Rewrites the logic in AudioRendererAlgorithmBase to be able to output audio
at any point of a sped-up/slowed down window, instead of only outputting audio
in full multiples of windows.
BUG=108239
TEST=media_unittests, manual testing on video test matrix
Review URL: http://codereview.chromium.org/9395057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125052 0039d316-1c4b-4281-b951-d872f2087c98
