This CL disentangles two codependent targets (//ppapi/thunk and
//ppapi/shared_impl) by creating a few helper targets. Fortunately, I
did not have to resort to a circular dependency.
Running `gn check` revealed a number of disallowed header inclusions. I
disentangled the header inclusions as necessary. In some places it was
possible to just delete troublesome includes because they were not being
used, or they only needed a forward declaration.
Before:
//ppapi/shared_impl
//ppapi/thunk
Now:
//ppapi/shared_impl
//ppapi/thunk
//ppapi/shared_impl:common
//ppapi/thunk:headers
//ppapi/shared_impl:headers
Change-Id: I28a8ac7daca1371106dc675c66da930dfe3b15cf
Fixed: 1158997
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3065823
Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#908232}
All uses of IsInMainFrame have converted to IsInPrimaryMainFrame
for MPArch. As one of ensuring that the conversion is correct,
this CL adds a test to ensure IsInPrimaryMainFrame use of
BlinkOptimizationGuideWebContentsObserver::ReadyToCommitNavigation
works correctly on prerendering via the added test.
Bug: 1218946
Change-Id: I741eacde22afcc9cd267dd2517795aeac97003d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3045638
Reviewed-by: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#908230}
This is work in progress to resolve crbug.com/1236238. In order to
pass the integration tests as system, more significant work for
the Windows service is needed:
* decouple the update and the update-internal services
* support SxS services
Bug: 1236238
Change-Id: I941d3a9382b2ce0247c90960e721fb4e8f936352
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3069858
Reviewed-by: S. Ganesh <ganesh@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#908228}
The rubber-stamper can not approve a CL that changes .bat, .sh or .py
files. Request the sheriff on rotation to approve the CL in such case.
The sheriff will have one hour to respond.
Bug: 1221677
Change-Id: I4cd1be4f4c2a8afb42cc776b954e3da31fdffe05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3069076
Reviewed-by: Rakib Hasan <rmhasan@google.com>
Commit-Queue: Weizhong Xia <weizhong@google.com>
Cr-Commit-Position: refs/heads/master@{#908225}
This CL is a true behavior-preserving refactor. It will not affect
performance because HashMap<>::DeprecatedAtOrEmptyValue() has an
identical implementation to HashMap<>::at().
In the near future, we will change the definition of HashMap<>::at() to
CHECK that the map contains the given key.
All occurrences of DeprecatedAtOrEmptyValue will need to be cleaned up.
If the caller cannot know whether the map already contains the given
key, one possible workaround is to use HashMap<>::find() instead.
Bug: 1058527
Change-Id: I5769069dcee38f04a0776d2c771d846736111eac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3066001
Auto-Submit: Dan McArdle <dmcardle@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#908223}
This CL is a true behavior-preserving refactor. It will not affect
performance because HashMap<>::DeprecatedAtOrEmptyValue() has an
identical implementation to HashMap<>::at().
In the near future, we will change the definition of HashMap<>::at() to
CHECK that the map contains the given key.
All occurrences of DeprecatedAtOrEmptyValue will need to be cleaned up.
If the caller cannot know whether the map already contains the given
key, one possible workaround is to use HashMap<>::find() instead.
Bug: 1058527
Change-Id: I0fc7e45d6d58ec7cac905b9022facea6d8166ff1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3067859
Auto-Submit: Dan McArdle <dmcardle@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#908216}
Updates the exception that gets raised when Gold returns a non-zero exit
code to be clearer and let the user know that it's likely just a case of
an image needing to be triaged.
Bug: 1230745
Change-Id: Id6c16ebdefe2485634f563ed56d68b2616627a61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3069501
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#908214}
This CL is a true behavior-preserving refactor. It will not affect
performance because HashMap<>::DeprecatedAtOrEmptyValue() has an
identical implementation to HashMap<>::at().
In the near future, we will change the definition of HashMap<>::at() to
CHECK that the map contains the given key.
All occurrences of DeprecatedAtOrEmptyValue will need to be cleaned up.
If the caller cannot know whether the map already contains the given
key, one possible workaround is to use HashMap<>::find() instead.
Bug: 1058527
Change-Id: Ib78f1a6416fb1693b42816d76827a0beb14d078a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3067839
Auto-Submit: Dan McArdle <dmcardle@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#908212}
This CL is a true behavior-preserving refactor. It will not affect
performance because HashMap<>::DeprecatedAtOrEmptyValue() has an
identical implementation to HashMap<>::at().
In the near future, we will change the definition of HashMap<>::at() to
CHECK that the map contains the given key.
All occurrences of DeprecatedAtOrEmptyValue will need to be cleaned up.
If the caller cannot know whether the map already contains the given
key, one possible workaround is to use HashMap<>::find() instead.
Bug: 1058527
Change-Id: I6e0e8e209092c84ef30d3e7377918806a7efe4fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3067504
Auto-Submit: Dan McArdle <dmcardle@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#908211}
This CL is a true behavior-preserving refactor. It will not affect
performance because HashMap<>::DeprecatedAtOrEmptyValue() has an
identical implementation to HashMap<>::at().
In the near future, we will change the definition of HashMap<>::at() to
CHECK that the map contains the given key.
All occurrences of DeprecatedAtOrEmptyValue will need to be cleaned up.
If the caller cannot know whether the map already contains the given
key, one possible workaround is to use HashMap<>::find() instead.
Bug: 1058527
Change-Id: I9665af14a632c47483a36fc5243e47cd1b631156
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3066000
Auto-Submit: Dan McArdle <dmcardle@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#908210}
This CL is a true behavior-preserving refactor. It will not affect
performance because HashMap<>::DeprecatedAtOrEmptyValue() has an
identical implementation to HashMap<>::at().
In the near future, we will change the definition of HashMap<>::at() to
CHECK that the map contains the given key.
All occurrences of DeprecatedAtOrEmptyValue will need to be cleaned up.
If the caller cannot know whether the map already contains the given
key, one possible workaround is to use HashMap<>::find() instead.
Bug: 1058527
Change-Id: Ia158edaf26f1297322c0deca5a9c479060ebc89c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3066004
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#908209}
This CL is a true behavior-preserving refactor. It will not affect
performance because HashMap<>::DeprecatedAtOrEmptyValue() has an
identical implementation to HashMap<>::at().
In the near future, we will change the definition of HashMap<>::at() to
CHECK that the map contains the given key.
All occurrences of DeprecatedAtOrEmptyValue will need to be cleaned up.
If the caller cannot know whether the map already contains the given
key, one possible workaround is to use HashMap<>::find() instead.
Bug: 1058527
Change-Id: I3d237bf1ef4196b7d1922ab5db241b291bcaa498
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3067878
Auto-Submit: Dan McArdle <dmcardle@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#908208}
This CL is a true behavior-preserving refactor. It will not affect
performance because HashMap<>::DeprecatedAtOrEmptyValue() has an
identical implementation to HashMap<>::at().
In the near future, we will change the definition of HashMap<>::at() to
CHECK that the map contains the given key.
All occurrences of DeprecatedAtOrEmptyValue will need to be cleaned up.
If the caller cannot know whether the map already contains the given
key, one possible workaround is to use HashMap<>::find() instead.
Bug: 1058527
Change-Id: Ia2245df6744ba108729b979d1cceccbebffae79c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3063926
Auto-Submit: Dan McArdle <dmcardle@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#908207}
This CL is a true behavior-preserving refactor. It will not affect
performance because HashMap<>::DeprecatedAtOrEmptyValue() has an
identical implementation to HashMap<>::at().
In the near future, we will change the definition of HashMap<>::at() to
CHECK that the map contains the given key.
All occurrences of DeprecatedAtOrEmptyValue will need to be cleaned up.
If the caller cannot know whether the map already contains the given
key, one possible workaround is to use HashMap<>::find() instead.
Bug: 1058527
Change-Id: I5e6fdada325bf0406593bdaa9dbbb27ac8a2ef65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3067879
Auto-Submit: Dan McArdle <dmcardle@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#908205}
This CL is a true behavior-preserving refactor. It will not affect
performance because HashMap<>::DeprecatedAtOrEmptyValue() has an
identical implementation to HashMap<>::at().
In the near future, we will change the definition of HashMap<>::at() to
CHECK that the map contains the given key.
All occurrences of DeprecatedAtOrEmptyValue will need to be cleaned up.
If the caller cannot know whether the map already contains the given
key, one possible workaround is to use HashMap<>::find() instead.
Bug: 1058527
Change-Id: I0a80cc216b581b8ae6a4f4c425b8613501d72d83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3067880
Auto-Submit: Dan McArdle <dmcardle@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#908204}
Before this change the following:-
```
import "path/for/enum.mojom"
const enum.mojom.Enum foo = enum.mojom.Enum.kWhatever
```
would fail with a LookupError in GetCppPodType when filling the
module-forward.h template.
With this change, enum consts are now output in the main module.h
and pull in the full imported mojom that defined the enum.
This use of const enums is already tested by
mojo/public/tools/mojom/const_unittest.py but was not used anywhere
in cpp-generating code.
Bug: 1210301,1011660
Change-Id: I428ab67264353ac5544c0a9ad35eb432bd5aeb54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3046531
Commit-Queue: Alex Gough <ajgo@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#908203}
This CL is a true behavior-preserving refactor. It will not affect
performance because HashMap<>::DeprecatedAtOrEmptyValue() has an
identical implementation to HashMap<>::at().
In the near future, we will change the definition of HashMap<>::at() to
CHECK that the map contains the given key.
All occurrences of DeprecatedAtOrEmptyValue will need to be cleaned up.
If the caller cannot know whether the map already contains the given
key, one possible workaround is to use HashMap<>::find() instead.
Bug: 1058527
Change-Id: I4465a79ca091c05b32a18fb0ad3b050d1b99ceb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3067506
Auto-Submit: Dan McArdle <dmcardle@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Reviewed-by: Steve Anton <steveanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#908202}
This CL is a true behavior-preserving refactor. It will not affect
performance because HashMap<>::DeprecatedAtOrEmptyValue() has an
identical implementation to HashMap<>::at().
In the near future, we will change the definition of HashMap<>::at() to
CHECK that the map contains the given key.
All occurrences of DeprecatedAtOrEmptyValue will need to be cleaned up.
If the caller cannot know whether the map already contains the given
key, one possible workaround is to use HashMap<>::find() instead.
Bug: 1058527
Change-Id: I0f592f2b48a70548c1e9488f6a32b4069fd99749
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3067861
Auto-Submit: Dan McArdle <dmcardle@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#908201}
This CL is a true behavior-preserving refactor. It will not affect
performance because HashMap<>::DeprecatedAtOrEmptyValue() has an
identical implementation to HashMap<>::at().
In the near future, we will change the definition of HashMap<>::at() to
CHECK that the map contains the given key.
All occurrences of DeprecatedAtOrEmptyValue will need to be cleaned up.
If the caller cannot know whether the map already contains the given
key, one possible workaround is to use HashMap<>::find() instead.
Bug: 1058527
Change-Id: If085b85aba8fda12904b6705b8859797882fa89b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3064942
Auto-Submit: Dan McArdle <dmcardle@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#908200}
Currently when the test fails it emits spurious errors. Waiting will
prevent this and make test failures easier to diagnose.
Orthogonally, we should ensure annotation can be entered robustly from
this state, but that can't be fixed here. It only occurs because the
test is able to find and "click" the annotation button before load
completes.
Bug: b/195058773
Test: All/MediaAppIntegrationTest.LoadsInkForImageAnnotation/_Default
Change-Id: I2309fba9eed623eb57803c8beb1c18412ab66a0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3066706
Reviewed-by: Patti <patricialor@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#908199}
This CL is a true behavior-preserving refactor. It will not affect
performance because HashMap<>::DeprecatedAtOrEmptyValue() has an
identical implementation to HashMap<>::at().
In the near future, we will change the definition of HashMap<>::at() to
CHECK that the map contains the given key.
All occurrences of DeprecatedAtOrEmptyValue will need to be cleaned up.
If the caller cannot know whether the map already contains the given
key, one possible workaround is to use HashMap<>::find() instead.
Bug: 1058527
Change-Id: I1b570f05dd2b1636e7ea635b7f1851f3ce49bdc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3067881
Auto-Submit: Dan McArdle <dmcardle@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#908197}
This CL is a true behavior-preserving refactor. It will not affect
performance because HashMap<>::DeprecatedAtOrEmptyValue() has an
identical implementation to HashMap<>::at().
In the near future, we will change the definition of HashMap<>::at() to
CHECK that the map contains the given key.
All occurrences of DeprecatedAtOrEmptyValue will need to be cleaned up.
If the caller cannot know whether the map already contains the given
key, one possible workaround is to use HashMap<>::find() instead.
Bug: 1058527
Change-Id: Ifb0657d3ac55fd5eaf962b6148405cf5f99fb874
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3063925
Auto-Submit: Dan McArdle <dmcardle@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#908196}
This makes the lacros test_runner.py aware of a new environment
variable, ASH_WRAPPER. When in the environment, the test runner will
prepend the ash command with whatever is in the environment variable.
This is similar to BROWSER_WRAPPER, which allows for attaching to the
browser process during tests.
Change-Id: Ieb0cfe3c12668da3756d0e8e8abd487951bfde4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2995026
Commit-Queue: Jim Shargo <jshargo@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#908195}
Warn on upload for any occurences of DeprecatedAtOrEmptyValue. The regex
is not particularly refined, but it is just a warning and I hope to get
rid of it in the near future.
This is step 2 of the refactor plan. See https://crbug.com/1058527#c9.
Change-Id: I307826c1a5ee44ab179f38dddfa804a14d802fbe
Bug: 1058527
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3067499
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#908193}
This CL is a true behavior-preserving refactor. It will not affect
performance because HashMap<>::DeprecatedAtOrEmptyValue() has an
identical implementation to HashMap<>::at().
In the near future, we will change the definition of HashMap<>::at() to
CHECK that the map contains the given key.
All occurrences of DeprecatedAtOrEmptyValue will need to be cleaned up.
If the caller cannot know whether the map already contains the given
key, one possible workaround is to use HashMap<>::find() instead.
Bug: 1058527
Change-Id: I249f8ff3351525a0ef6dd16e8a665c1d899b6c51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3067838
Auto-Submit: Dan McArdle <dmcardle@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#908192}
If the "Same Origin" Enterprise Policy restriction is set, ensures that
the "Switch to Tab" buttons only appear on valid capture targets. When
a tab is navigated and the origin changes, the InfoBar is recreated if
the button should be added or removed.
Additionally, observes the currently captured tab to terminate a capture
if it is navigated away from the same origin as the capturer.
Bug: 1182221
Change-Id: I4ad5de77cdd37c77f8833f50c7d8548c4dac02e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3061825
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#908190}
This CL performs the following cleanups to the
content::CookieStoreManager class.
1) Mark immutable members as const.
2) Add thread safety annotations for non-thread-safe members.
3) Add sequence checks to methods flagged by the compiler.
4) Replace DISALLOW_COPY_AND_ASSIGNMENT() with the modern equivalent.
5) Rename CreateService*() with BindReceiver(). We now prefer to use
Service to refer to the modules in //**/services.
Change-Id: I163d926b55dc80df4bde5cca8b32b056afd7a9a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3064414
Commit-Queue: Victor Costan <pwnall@chromium.org>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Auto-Submit: Victor Costan <pwnall@chromium.org>
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#908189}
Updates the flag expiry after the launch was delayed. Set to M97 because
M95 was skipped, and to leave 1 milestone as buffer.
AX-Relnotes: n/a.
Bug: none
Test: none
Change-Id: I9f2b00484665c0a3b41c73ea49d067085f57e906
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3069641
Auto-Submit: Anastasia Helfinstein <anastasi@google.com>
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#908185}
