0
Commit Graph

7 Commits

Author SHA1 Message Date
Tom Anderson
ac918bb6a8 Display diff in uberblame visualization
Uberblame now looks like this:
https://bugs.chromium.org/p/chromium/issues/detail?id=773350#c9

BUG=773350
R=dpranke

Change-Id: I43b75fbedac5a9350a5c227882743b8a9bd33282
Reviewed-on: https://chromium-review.googlesource.com/1014621
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551188}
2018-04-17 00:37:34 +00:00
Tom Anderson
500216114c Uberblame: Include context lines in diff
This is in preparation for displaying the diff in the Uberblame visualization.
About 3 lines of context is nice when viewing diffs.

Some extra logic is now necessary to handle the context.

BUG=773350
TBR=dpranke

Change-Id: If202deb3d9fd85ee6f9376739205a15f542b8005
Reviewed-on: https://chromium-review.googlesource.com/1014349
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551184}
2018-04-17 00:30:21 +00:00
Tom Anderson
b3d7e647dd Add more options to uberblame
* Adds --tokenize-by-character
  * This is useful for eg. the blink refactor where fooBar got changed to
    foo_bar.
* Adds --tokenize-whitespace
* Adds --skip-visualization
  * Added this because it was useful for testing.
* Ran yapf
* Small refactor.

BUG=773350
R=dpranke

Change-Id: I7596f670ce640ed6bd367dee995628edc13dd6f2
Reviewed-on: https://chromium-review.googlesource.com/1010798
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550634}
2018-04-13 16:23:42 +00:00
Tom Anderson
65410155e3 Uberblame: Display commit metadata in the visualization
BUG=773350
R=dpranke@chromium.org

Change-Id: Ic95199a275e33808b3e3f895f884561955bc6746
Reviewed-on: https://chromium-review.googlesource.com/720198
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509210}
2017-10-17 01:53:19 +00:00
Tom Anderson
1e71692610 Uberblame: separate git log data with null bytes instead of newlines
This is in preparation for parsing the commit message (which may
contain lone newlines) in the git log.

BUG=773350
R=dpranke@chromium.org

Change-Id: Ia3cd60bc48601034c753c0e6bc6de6b176f8006b
Reviewed-on: https://chromium-review.googlesource.com/710747
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508383}
2017-10-12 19:43:49 +00:00
Tom Anderson
a671dad1b8 Uberblame: Use outline instead of box shadow in the blame view
Before, there were too many borders separating the same commit.  This
CL uses CSS outlines instead of box shadows in order to wrap the
border around the perimeter of the text.  See [1] for an explanation
of what's changed.

[1] https://bugs.chromium.org/p/chromium/issues/detail?id=773350#c3

R=dpranke@chromium.org
BUG=773350

Change-Id: I54c186020647a9a773a4f0b6d80d5c71a94d126b
Reviewed-on: https://chromium-review.googlesource.com/709994
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507738}
2017-10-10 19:19:47 +00:00
Tom Anderson
c3ed89607d Implement initial prototype of UberBlame
Design document:
https://docs.google.com/a/google.com/document/d/1WBJBKgfK7MRWW_HDCHaDsA_MSqPgCPITLv68lukFzOk/edit?usp=sharing

Change-Id: I116c1770009e22a1fcc9a782977d93bbb73d1fd7
Reviewed-on: https://chromium-review.googlesource.com/658837
Reviewed-by: Aaron Gable <agable@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507435}
2017-10-09 19:01:46 +00:00