0
Commit Graph

185851 Commits

Author SHA1 Message Date
e1085ae831 Fix Win64 build error.
R=dalecurtis@chromium.org
TBR=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/70873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234707 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-13 01:58:41 +00:00
2f90b3cfd8 [Translate] Apply language synonyms to the target language
Expose ConvertLangCodeForTranslation and use it when converting the UX language
for all platforms (the performance hit should be negligible and this way
it is more legible than adding a #ifdef Android)

Fix a few unrelated typos on comments while at it.

BUG=311624

Review URL: https://codereview.chromium.org/68823004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234706 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-13 01:55:09 +00:00
39dce5fd18 Re-enable Shim_TestAssignSrcAfterCrash.
This flakiness was fixed right before it was disabled, at r233997.
Last test failure at the build was at r233991.

BUG=316939
Test=None, enabling test.

Review URL: https://codereview.chromium.org/67403005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234705 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-13 01:54:47 +00:00
4aad450c1d [Mac] Fix title text re-expanding after tab media indicator shuts off.
TabController needs to be notified to re-compute visibility and layout whenever a media indicator animation ends, to account for the case where the MediaIndicatorView should be hidden.  A simple callback scheme has been added, rather than using NSView::setNeedsLayout, because TabController/TabView employ their own custom layout mechanism.

BUG=317843

Review URL: https://codereview.chromium.org/69143003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234704 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-13 01:48:55 +00:00
71d87e1609 Fix linux_chromeos_clang compile for app_shell
http://crrev.com/234634 changed aura::RootWindow so it isn't an aura::Window anymore.

BUG=None
TEST=compiles
R=derat@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/61303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234703 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-13 01:47:21 +00:00
94124a943a Try a different arbitrary SkGlyphCache cap (64 -> 256)
We're hitting a lot of crashes in skia::CreateCanvas that may be due to GDI
handle exhaustion.  This picks a different arbitrary limit for the number
of entries in this cache to try to see if the crashes are correlated. Changing
this cap from 2048->64 was perf neutral on the bots, so 64->256 is also
expected to be neutral.

TBR=reed
NOTRY=true
BUG=275046,314387

Review URL: https://codereview.chromium.org/71043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234702 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-13 01:41:17 +00:00
feae55133f canPlayType could return maybe/probably for VP9 in android
VP9 support was added to android in Kitkat. Changing canPlayType to return
probably/maybe if running on kitkat or higher.

Review URL: https://codereview.chromium.org/66863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234701 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-13 01:40:51 +00:00
57ac99b92a Try to fix flaky test TemplateURLTest.ReplacePageClassification
BUG=316385

Review URL: https://codereview.chromium.org/70163003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234698 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-13 01:30:17 +00:00
8853b68929 Does not override default animation when closing a docked window
BUG=317204

Review URL: https://codereview.chromium.org/68513003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234697 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-13 01:29:52 +00:00
a962f84d3b [Telemetry]: Add HTML5 Capabilities and Canvas tests to Peacekeeper benchmark suite.
Review URL: https://codereview.chromium.org/68203007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234696 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-13 01:29:30 +00:00
ea1aab8f24 Remove safe-browsing false-positive tracking.
This code originally tracked false positives in BloomFilter.
PrefixSet doesn't have false positives in the same way, so the number
is misleading.

BUG=64988

Review URL: https://codereview.chromium.org/60013005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234695 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-13 01:19:57 +00:00
74dae795e1 Add new flag for Notification Center features that are not ready yet.
We are planning to use it during the next month while polishing UI for notifications and trying various experiments.

BUG=none

Review URL: https://codereview.chromium.org/69623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234694 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-13 01:11:26 +00:00
7936898a17 Renamed CanPruneAllButVisible and PruneAllButVisible in the Navigation Controller to CanPruneAllButLastCommitted and PruneAllButLastCommitted, respectively.
Review URL: https://codereview.chromium.org/69013004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234693 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-13 01:11:01 +00:00
b350d2995c A number of paint optimizations to improve overall paint times.
Here's the run down:
. Removes unnecessary SchedulePaint() in
  DesktopRootWindowHostWin::SetOpacity. SchedulePaint isn't necessary
  here as opacity is handled by the layer.
. Textfield::SetHorizontal/VerticalMargins should only invoke
  PreferredSizeChanged() if margins actually changed. Otherwise we
  invalidated all the way up the view hierarchy. This means the next
  call to Layout() at the root is going to layout and repaint
  everything.
. Adds ImageView::SetImageByResourceID. Adding this allows us to do
  nothing if the image has changed.
. StatusBubbleView was unnecessarily calling SchedulePaint in some
  situtations. In particular it should only SchedulePaint() if the
  text actually changes.
. Changes a number of places in LocationBar to only SchedulePaint() if
  something actually changed. These methods can all be invoked rather
  frequently.

BUG=313494
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/60683003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234692 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-13 01:10:19 +00:00
678a827246 Update .DEPS.git
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234690 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-13 01:02:12 +00:00
5ae98e4d2a Roll Skia DEPS to 12260
Review URL: https://codereview.chromium.org/68343015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234689 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-13 01:01:18 +00:00
fe3739b40a Fix BaseBubbleController default behavior.
Since BaseBubbleController does not have a designated initializer, all
initializers must set |shouldCloseOnResignKey_| to YES.

BUG=317459
R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/68733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234688 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-13 01:00:16 +00:00
a038ebcc3d ash: Rename LauncherModelObserver to ShelfModelObserver.
- move launcher_model_observer.h from launcher/ to shelf/
- rename to shelf_model_observer.h

BUG=248353
TEST=None, no functional changes
R=harrym@chromium.org,jamescook@chromium.org

Review URL: https://codereview.chromium.org/68243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234686 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-13 00:59:19 +00:00
f7367d42b9 Propagates the search result of start page to the app-list search box.
BUG=313899
R=xiyuan@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/55433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234685 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-13 00:58:03 +00:00
816939d13c Pages from other devices open in current tab.
* Opening a foreign session or recently closed now takes over the tab 
(nuking its navigation history)
* Opening a chrome-to-mobile page now loads in the current tab.

BUG=257102

Review URL: https://codereview.chromium.org/36473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234684 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-13 00:57:39 +00:00
39f3c14f65 Don't lock the cursor when dragging or resizing a window with touch
The user is already able to simultaneously move the 
mouse cursor while touching the screen (e.g., 
while touch-scrolling web contents,reordering 
tabs with touch, etc.), so touch-dragging or resizing 
a window should be no exception. Do not lock the 
cursor when initiating a touch drag/resize of a 
browser window so that a physical mousemove will 
show the cursor.

BUG=316654
TEST=WorkspaceWindowResizerTest.MouseMoveWithTouchDrag

Review URL: https://codereview.chromium.org/67403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234683 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-13 00:45:47 +00:00
123ddd3a69 Activate Views TabbedPane tabs on mouse pressed.
SelectTab in OnMousePressed and for ET_GESTURE_TAP_DOWN.
Eliminate the intermediate TAB_PRESSED state enum.
(Inactive/Active/Hovered cover the available states)

BUG=252919
TEST=View TabbedPane tabs change on mouse down. This UI is used in the website settings bubble (via the page icon), and the collected cookies dialog (from the aforementioned bubble) on Windows and ChromeOS.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/66603013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234682 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-13 00:45:15 +00:00
85033389ec Mojo: RemotePtr<S> + bindings changes for Peer attribute.
This adds an end-to-end test of the system w/ generated code as part of the CL. The generated code can be deleted once we have a GYP rule for generating code.

Review URL: https://codereview.chromium.org/66353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234681 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-13 00:44:48 +00:00
df69fbb9f8 Media Galleries: Fix a formatting error in the html doc.
TBR=vandebo@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/64913009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234680 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-13 00:44:27 +00:00
2cdc4dbca4 Update .DEPS.git
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234676 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-13 00:25:07 +00:00
ccb309795b MediaCodecBridge: remove CodecInfo.mIsSecureDecoderSupported since it's unused & crashy.
BUG=314868
R=wjia@chromium.org, xhwang@chromium.org

Review URL: https://codereview.chromium.org/68923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234675 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-13 00:25:07 +00:00
faf682e7de Roll ANGLE
BUG=
TEST=tree
TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/48623011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234674 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-13 00:24:55 +00:00
14c3571a07 Move ExtensionFunction to the extensions component.
TBR=sky@chromium.org
BUG=162530

Review URL: https://codereview.chromium.org/64273006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234673 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-13 00:18:44 +00:00
ab6eb56741 CT: Adding SCT verification functionality: A CTLogVerifier instance can verify SCTs signed by a single log.
BUG=309578

Review URL: https://codereview.chromium.org/55953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234672 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-13 00:18:11 +00:00
d85fb73104 QUIC - Made AckFrameInfo a struct.
Thanks Ryan for catching this.

R=rch@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/54463011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234671 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-13 00:17:41 +00:00
6e12d70bcd QUIC - added googlevideo.com to the list of cannonical hostnames to
share the server config for 0-RTT for youtube videos.

R=jar@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/48893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234670 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-13 00:17:17 +00:00
ae4a77fa5c Give mojo_shell a TransportSecurityPersister.
This required moving TransportSecurityPersister into net.

BUG=310293
R=akalin@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/59693008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234667 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-13 00:09:46 +00:00
c91aff388d Update .DEPS.git
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234666 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-12 23:53:08 +00:00
32b3a4fce7 Revert r234519 "Roll swarming_client @ debee21c1a."
The roll caused failure on linux and OSX.

R=vadimsh@chromium.org
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/70383004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234665 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-12 23:52:09 +00:00
03a2e4b067 Add regression test for 301510
BUG=301510
R=ananta@chromium.org

Review URL: https://codereview.chromium.org/62203013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234664 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-12 23:48:34 +00:00
a73024640a [Files.app] Fix the icon of audio player
BUG=318472
TEST=manually tested
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/70843004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234663 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-12 23:48:06 +00:00
2807d3aa37 Add 10dp between app search result options.
R=xiyuan@chromium.org
BUG=312459

Review URL: https://codereview.chromium.org/69293011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234662 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-12 23:43:34 +00:00
dc735c0aac Omnibox: In Reorder Mode, SearchProvider Doesn't Need to Remove Stale Results
BUG=309465
R=msw@chromium.org, pkasting@chromium.org

Review URL: https://codereview.chromium.org/66503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234661 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-12 23:23:41 +00:00
b74a5653a8 Reduce delay when showing feedback.
Move the toDataURL operation of the canvas containing the screenshot to after we show the feedback page. This will significantly increase the response time from when a user requests feedback to the time that the feedback window is shown.

R=xiyuan@chromium.org
BUG=308414

Review URL: https://codereview.chromium.org/61153007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234660 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-12 23:20:39 +00:00
e915ef3bd2 Pepper: Tighten GetLiveModule in PluginRegistry.
On PepperPluginInstanceImpl::Delete(), we send a synchronous DidDestroy message
to the plugin.  The plugin can exit() in response to this message.

While the renderer is waiting for a response (and holding a reference to
PepperPluginInstanceImpl on the stack), another plugin for the page could
create an instance of a plugin using the same path as the deleted instance.

This can cause a PluginModule to be reused on the host for a plugin which is no
longer live. In this case, sending DidCreate will fail.

Alternatively, the lifetime of PluginModule could be cleaned up, but there are
many uses of PepperPluginInstanceImpl::module() throughout the codebase. I'm
happy to look at seeing if that can be cleaned up in another change.

BUG=
R=dmichael@chromium.org, teravest@google.com

Review URL: https://codereview.chromium.org/69363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234659 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-12 22:56:08 +00:00
a25fbe84c1 Update .DEPS.git
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234658 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-12 22:46:09 +00:00
34fd3002ec NaCl: Update revision in DEPS, r12352 -> r12372
This pulls in the following Native Client changes:

r12353: (mseaborn) PNaCl: Remove unused dynamic linking code from bitcode/crtbegin.c
r12354: (mseaborn) PNaCl driver scripts: Rename ALLOW_CXX_EXCEPTIONS internal variable
r12355: (khim) Don't overwrite toolchains if they were downloaded manually
r12356: (thestig) Update ARM trusted root image to include libcap2 and remove libbz2.
r12357: (jfb) Allow run.py to figure out the pexe architecture from the environment (PNACL_RUN_ARCH), or from the current architecture.
r12358: (mcgrathr) Update binutils in tools/REVISIONS
r12359: (mseaborn) Add OWNERS files for src/untrusted/{irt,nacl,pthread}
r12360: (halyavin) Update redirector.h to match redirect_table.txt
r12361: (sehr) Move ncval_annotate test to use ncval_new
r12362: (mseaborn) pnacl-driver: Remove TODO that appears to be done
r12363: (mcgrathr) Adjust nacl_text_pad_text to handle new-style layout
r12364: (mseaborn) PNaCl: Add support for SJLJ-based (setjmp/longjmp) C++ exception handling
r12365: (mcgrathr) Re-enable Linux Clang trybot
r12366: (kschimpf) Update pnacl llvm revisions.
r12367: (mcgrathr) Update binutils in tools/REVISIONS
r12368: (mark) Disable Breakpad during NaCl DEP qualification test on Mac x86_64.
r12369: (jfb) PNaCl: Update Clang revision in pnacl/COMPONENT_REVISIONS
r12370: (mseaborn) pnacl-translate: Remove some parsing code related to dynamic linking support
r12371: (jfb) Add pnaclmm.a to support gccmm's __atomic_* functions.
r12372: (jvoung) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS

BUG=none
TEST=browser_tests and nacl_integration

Review URL: https://codereview.chromium.org/64743005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234657 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-12 22:45:11 +00:00
2d584a90fa Set TargetMachine for libs too
In VS2013, remoting_host_event_logger.lib fails with:

FAILED: E:\b\depot_tools\python_bin\python.exe gyp-win-tool link-wrapper environment.x86 lib.exe /nologo /ignore:4221 /OUT:obj\remoting\remoting_host_event_logger.lib @obj\remoting\remoting_host_event_logger.lib.rsp
LINK : warning LNK4068: /MACHINE not specified; defaulting to X64

obj\remoting\host\remoting_host_event_logger.host_event_logger_win.obj : fatalerror LNK1112: module machine type 'X86' conflicts with target machine type 'x64'

This is because if unspecified, lib.exe chooses the target architecture
based on the first input file. In this lib, the first file (there's only
2) happens to be a .res compiled from a .rc, which doesn't have an
architecture. Because we use the amd64 toolchain, lib decides to guess
that it should use x64. This fails to lib because the other .cc input is
x86.

After adding support for setting the architecture for libs in gyp here
https://codereview.chromium.org/68133006/ this sets it explicitly on our
libs too.

R=cpu@chromium.org
BUG=309197

Review URL: https://codereview.chromium.org/61893020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234656 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-12 22:44:39 +00:00
a3bf6f7ce0 sync: don't allow NULL profile in ProfileSyncService and friends
BUG=130176

TBR=mpcomplete@chromium.org

Review URL: https://codereview.chromium.org/59793008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234655 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-12 22:44:15 +00:00
c39e464508 Update .DEPS.git
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234654 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-12 22:44:09 +00:00
7a6f4564cc Blink roll 161815:161846
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=161816:161846&mode=html

TBR=yhirano

Review URL: https://codereview.chromium.org/70733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234653 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-12 22:43:41 +00:00
bc5bb33c7c base: Avoid purging more discardable memory than necessary.
In situations when discardable memory usage is above the limit,
instead of purging the amount of memory that we would try to
reclaim under moderate memory pressure, purge only what is
necessary to stay below the limit.

This simplifies the code and makes it easier to understand how
memory is purged as a result of reaching the memory limit.

BUG=237681
TEST=base_unittests --gtest_filter=DiscardableMemoryProviderPermutationTests/DiscardableMemoryProviderPermutationTest.LRUDiscardedAmount/*

Review URL: https://codereview.chromium.org/59083011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234652 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-12 22:43:23 +00:00
337602e45f Change the app list folder management back button to a smaller size one(24x24).
BUG=318626
R=xiyuan@chromium.org
TBR=oshima

Review URL: https://codereview.chromium.org/68113010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234651 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-12 22:34:33 +00:00
a1c4871677 [sync] Fix behavior of "Use default settings" / "Advanced" links
This CL fixes the behavior seen while switching between the "Use default
settings" / "Advanced" modes of the sync setup dialog.

BUG=316547
TEST=Switch between the "Use default settings" and "Advanced" modes. OK button must receive focus.
R=rogerta@chromium.org

Review URL: https://codereview.chromium.org/69723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234650 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-12 22:18:30 +00:00
5bda847a21 [Telemetry] Make unhandled exception output more useful.
This should help tremendously in diagnosing flake on the bots.

Default format:
---------------------------
Traceback (most recent call last):
  File "tools/perf/run_benchmark", line 23, in <module>
    sys.exit(test_runner.Main())
  File "tools/perf/../telemetry/telemetry/test_runner.py", line 290, in Main
    return command.Run(options, args)
  File "tools/perf/../telemetry/telemetry/test_runner.py", line 198, in Run
    return min(255, self._test().Run(copy.copy(options)))
  File "tools/perf/../telemetry/telemetry/test.py", line 53, in Run
    results = page_runner.Run(test, ps, expectations, options)
  File "tools/perf/../telemetry/telemetry/page/page_runner.py", line 330, in Run
    possible_browser, results, state)
  File "tools/perf/../telemetry/telemetry/page/page_runner.py", line 213, in _PrepareAndRunPage
    credentials_path, page.archive_path)
  File "tools/perf/../telemetry/telemetry/page/page_runner.py", line 54, in StartBrowser
    test.DidStartBrowser(self.browser)
  File "/work/chromium/src/tools/perf/measurements/page_cycler.py", line 71, in DidStartBrowser
    self._memory_metric = memory.MemoryMetric(browser)
  File "/work/chromium/src/tools/perf/metrics/memory.py", line 32, in __init__
    self._start_commit_charge = self._browser.memory_stats['SystemCommitCharge']
  File "tools/perf/../telemetry/telemetry/core/browser.py", line 166, in memory_stats
    result = self._GetStatsCommon(self._platform_backend.GetMemoryStats)
  File "tools/perf/../telemetry/telemetry/core/browser.py", line 99, in _GetStatsCommon
    for child_pid in self._platform_backend.GetChildPids(browser_pid):
  File "tools/perf/../telemetry/telemetry/core/platform/posix_platform_backend.py", line 44, in GetChildPids
    return proc_util.GetChildPids(processes, pid)
  File "tools/perf/../telemetry/telemetry/core/platform/proc_util.py", line 86, in GetChildPids
    for foo, curr_pid, curr_ppid, state in processes:
ValueError: need more than 3 values to unpack
---------------------------

New format:
---------------------------
Traceback (most recent call last):
  <module> at tools/perf/run_benchmark:23
    sys.exit(test_runner.Main())
  Main at tools/telemetry/telemetry/test_runner.py:303
    return command.Run(options, args)
  Run at tools/telemetry/telemetry/test_runner.py:211
    return min(255, self._test().Run(copy.copy(options)))
  Run at tools/telemetry/telemetry/test.py:53
    results = page_runner.Run(test, ps, expectations, options)
  Run at tools/telemetry/telemetry/page/page_runner.py:330
    possible_browser, results, state)
  _PrepareAndRunPage at tools/telemetry/telemetry/page/page_runner.py:213
    credentials_path, page.archive_path)
  StartBrowser at tools/telemetry/telemetry/page/page_runner.py:54
    test.DidStartBrowser(self.browser)
  DidStartBrowser at tools/perf/measurements/page_cycler.py:71
    self._memory_metric = memory.MemoryMetric(browser)
  __init__ at tools/perf/metrics/memory.py:32
    self._start_commit_charge = self._browser.memory_stats['SystemCommitCharge']
  memory_stats at tools/telemetry/telemetry/core/browser.py:166
    result = self._GetStatsCommon(self._platform_backend.GetMemoryStats)
  _GetStatsCommon at tools/telemetry/telemetry/core/browser.py:99
    for child_pid in self._platform_backend.GetChildPids(browser_pid):
  GetChildPids at tools/telemetry/telemetry/core/platform/posix_platform_backend.py:44
    return proc_util.GetChildPids(processes, pid)
  GetChildPids at tools/telemetry/telemetry/core/platform/proc_util.py:86
    for foo, curr_pid, curr_ppid, state in processes:

Locals:
  child_dict : defaultdict(<type 'list'>, {})
  pid        : 5510
  processes  : [['1', '0', 'Ss'], ['15', '1', 'Ss'], ['16', '1', 'Ss'], ['17 ... 99', 'R+'], ['78347', '78344', 'Ss'], ['78349', '78347', 'S']] (truncated)

ValueError: need more than 3 values to unpack
---------------------------

BUG=

Review URL: https://codereview.chromium.org/64553004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234648 0039d316-1c4b-4281-b951-d872f2087c98
2013-11-12 22:06:48 +00:00