Since we cannot depend on the gRPC corpus anymore, it's a good idea to
start using FuzzTest so that we ensure the generated strings are valid
JSON.
Here, we're using a particular domain that'll both create valid and
invalid JSON. This actually mimics the old corpus, because at every
fuzzer start, we are feeding the string mutator with a valid JSON.
This helps go deeper with a simple string mutator, while still testing
for invalid cases.
Bug: 399449169
Change-Id: I2e81d87323728b933a28fd84de95cb86a63281e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6308902
Commit-Queue: Paul Semel <paulsemel@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1428401}
This changes instances of `b ? "true" : "false"` to use
`base::ToString(b)` instead, for consistency.
This change applies to the following directories:
services
This CL was uploaded by git cl split.
Bug: 335797528
Change-Id: I7aa2e12f6c9b21ac7495a195451f167679794043
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6327404
Commit-Queue: Colin Blundell <blundell@chromium.org>
Auto-Submit: Devon Loehr <dloehr@google.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1428396}
3c11c5bae...a33cc7c5e
Using wpt-import in Chromium 0196b934a3.
With Chromium commits locally applied on WPT:
e73515f68c "blink: Add fuzzy matching for object-view-box ref test."
a90b64f5bf "Scheduling APIs: Fix yield subframe tests"
Note to gardeners: This CL imports external tests and adds expectations
for those tests; if this CL is large and causes a few new failures,
please fix the failures by adding new lines to TestExpectations rather
than reverting. See:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md
Directory owners for changes in this CL:
domenic@chromium.org, wjmaclean@chromium.org:
external/wpt/html/browsers/origin/origin-keyed-agent-clusters
hongchan@chromium.org, mjwilson@chromium.org:
external/wpt/webaudio
kojii@chromium.org:
external/wpt/css/css-writing-modes
vogelheim@chromium.org:
external/wpt/trusted-types
NOAUTOREVERT=true
No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Change-Id: I6446266de7f690debe57c7087d8e4a3a3f52906b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6324291
Reviewed-by: Weizhong Xia <weizhong@google.com>
Commit-Queue: Jonathan Lee <jonathanjlee@google.com>
Reviewed-by: Jonathan Lee <jonathanjlee@google.com>
Cr-Commit-Position: refs/heads/main@{#1428395}
EdgeToEdgeManager is not available in #onPreCreate. Since
#setStatusBarColor is called when EdgeToEdgeEverywhere is disabled,
EdgeToEdgeSystemBarColorHelper is not needed by the
StatusBarColorController to #setStatusBarColor.
Bug: 399763658
Change-Id: Ife39f67e61c9ab167c4b04d59427f9d9f4ae364a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6323483
Reviewed-by: Charles Hager <clhager@google.com>
Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
Commit-Queue: Joel Tan-Aristy <jtanaristy@google.com>
Cr-Commit-Position: refs/heads/main@{#1428394}
Downloads from the Chrome Webstore may go through several redirects.
We should check that the original URL is associated with the CWS, not
the final download URL.
Bug: b:399447642
Change-Id: Ifea2c007fb187a7cd4da8fd288e4f02c9a9f3474
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6313464
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1428392}
On since M133. Had one regression, and can easily merge with conflict
if we need to do something about it (provided potential mitigation).
Bug: 384765587
Change-Id: Ifc9fefc1a9177e6af2746d15af784d7d858e0df8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102353
Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1428390}
...even if kSeparateProfilesForManagedAccounts is disabled.
This doesn't really make a difference, but is more consistent (and the
pre-existing profile won't show up as "uninitialized" in
chrome://profile-internals).
Bug: 331783685
Change-Id: I909ae576904e01c1b182e477c7bba1dfa5ab048f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6326292
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1428389}
This CL:
- Adds a web platform test for registration sending back a challenge:
registration-sends-challenge.https.html.
- Remove derefs of session_identifier_ for registration (when it is not
populated). This applied to error handling code paths kSigningError
and kInvalidChallenge.
Bug: 353767385
Change-Id: I3143b60c64b9b6d34dea2cb117ca1f674c5d3314
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6328159
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: thefrog <thefrog@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1428388}
This CL populates `GapGeometry` with offsets of intersection points
within a grid. It begins by adding two vectors of GapIntersectionLists,
representing lists of intersection points for each track direction
(columns and rows). `BuildGapIntersectionPoints()` is added to the grid
layout algorithm, populating intersection points for each gap row-wise
and column-wise.
Subsequent changes will mark the "blocked" status of each intersection
point based on the presence of spanning items.
Bug: 357648037
Change-Id: I234b4ea63d011815e600344722334fc153b3cf79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6313080
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Commit-Queue: Sam Davis Omekara <samomekarajr@microsoft.com>
Reviewed-by: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1428385}
This is a reland of commit 5b8272d344
Changes since original (PS1):
Initialize `Capabilities.quit_gracefully` before using (MSAN failure
log: https://paste.googleplex.com/4895326018994176).
Original change's description:
> [chromedriver] Allow clients to stop browser process gracefully
>
> Add a Chrome-specific capability `quitGracefully` that forces
> chromedriver to attempt to stop the browser with `Browser.close` or
> SIGTERM. wptrunner will enable this capability when used with the `rr`
> debugger (`rr record chrome ...`), which needs time to dump the
> recording. The runner doesn't want to manage `--user-data-dir` or
> `--log-net-log` itself, so the existing code path for graceful quit
> is insufficient.
>
> SIGKILL remains the default behavior so that quitting remains fast for
> clients that don't opt-in.
>
> Bug: 339644807
> Change-Id: I8b4286bb188f36d0c786e78bf6257c516c91f865
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6269180
> Commit-Queue: Jonathan Lee <jonathanjlee@google.com>
> Reviewed-by: Maksim Sadym <sadym@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1427507}
Bug: 339644807
Cq-Include-Trybots: luci.chromium.try:linux-webkit-asan-rel
Cq-Include-Trybots: luci.chromium.try:linux-webkit-msan-rel
Change-Id: Iff6dea47c3d2e3c33844e7117fa61d817d9a56f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6322538
Commit-Queue: Jonathan Lee <jonathanjlee@google.com>
Reviewed-by: Maksim Sadym <sadym@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1428384}
This CL adds a new ENUM to allow for dynamically loading dialogs. Naming for `PrivacySandboxDialogV3` has been generalized as part of this CL.
One pager: go/ps-clank-dialog-redesign
Bug: 392943234
Change-Id: I88753f74a9ca34d4781af85afdd756c0e2c87cff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6299071
Reviewed-by: Abe Boujane <boujane@google.com>
Commit-Queue: Alvin Lam <alvingo@google.com>
Reviewed-by: Jacob Stanley <jacobstanley@google.com>
Cr-Commit-Position: refs/heads/main@{#1428377}
This CL adds a variant of
AcceleratedStaticBitmapImage::CreateFromCanvasSharedImage() that takes
in gfx::ColorSpace instead of SkColorSpace. This change is a bit more
subtle than others as callsites that currently pass null for the
SkColorSpace (which implicitly means SRGB) will now change to explicitly
pass an SRGB gfx::ColorSpace, which will then get converted internally
to an explicit SRGB SkColorSpace. So rather than do all the conversions
in one CL I'll do them iteratively to analyze each and make sure that
this nuance is unproblematic. This CL makes the change for a test.
Bug: 371227617
Change-Id: I3f6058a6933bfba71e376eec2fdb153d22372dad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6327379
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Saifuddin Hitawala <hitawala@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1428374}
This CL changes the timeout of OnShowSharePicker to 60 seconds to allow
enough time for messages to open a given file before it is deleted.
It appears that files shared are scheduled to be deleted as soon as the
share service notifies that it has finished sharing the items. Extending
the timeout should allow ample time for the file to load in messages.
Tested manually by running chrome on mac and sharing
https://g-issues.chromium.org/370252260#attachment59729494
to messages. Image appears in messages when message app is open and
when message app is closed.
Once this change is merged, a bug will be filed with the apple team
to do a more thorough search/investigation for a proper fix (if
needed).
Bug: 370252260
Change-Id: I4b75a57fc152038056604b19e4328bcda57f4c4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6324035
Commit-Queue: May Siem <msiem@chromium.org>
Reviewed-by: Dibyajyoti Pal <dibyapal@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1428368}
Before this change `chrome.windows.create({ focused: false })`
unconditionally activates the last active chromium window (even if
chromium was not the last active program). This was to address a
limitation of active_browser->window()->Activate(). But the consequence
of that is if a user is focused on another program it would switch
focus to chromium unconditionally.
After this change we add a condition that the chromium browser must be
active for us to activate the last active window. This means that we no
longer interrupt the user if focus is in another program.
Fixed: 398173033
Change-Id: Ia3198b371bd2419c1d9f8628f74ac64804275c0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6320633
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Keren Zhu <kerenzhu@chromium.org>
Commit-Queue: Justin Lulejian <jlulejian@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1428367}
Previously only the actual jdeps graph was used, and it was missing
additional deps that are only in GN. This CL also parses the GN target
dep from project.json.
The script now requires passing `-C` or `--out-dir` for the output
directory in which to generate project.json.
Skip testonly targets and targets with 'test' in their name by default.
Pass --include-testonly to add them back.
Add some targets that the annotator regularly misses (e.g. annotations,
errorprone, profiling) as these are not blockers for other targets to be
annotated.
Allow verbose output to show more information about each target and
which other targets they depend on.
Improve transitive dep detection to account for up to 2^5 = 32 deep
dep-chains. i.e. A1 depends on A2 ... depends on A32 should all be
resolved in the transitive dep graph correctly.
Takes less than 2 minutes with --no-cache, and 15 seconds with a full
cache (i.e. /tmp files and existing project.json file).
R=hnakashima@chromium.org
Bug: 389129271
Change-Id: I565c682e2e5b3bf96f1a76e47c0449479b9e1796
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6329736
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1428366}
Now that `target_platform` has been added to mobile_config.gni, adjust
the rest of the files under //build/config:
- build/config/apple and build/config/ios: Make GN and scripts aware of
the tvOS platform.
- build/config/clang: Check `target_platform` to decide which
libclang_rt version to use.
- build/config/rust: Check `target_platform` to pick a tvOS Rust ABI
target as documented in
https://doc.rust-lang.org/nightly/rustc/platform-support/apple-tvos.html
Co-authored with Gyuyoung Kim <gyuyoung@igalia.com>
Bug: 391990604
Change-Id: I6ecd57c1a40c884c4cb44efdeaa030f855e11959
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6321990
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Raphael Kubo da Costa <kubo@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1428354}
