Renames the "user ID" and "instance name" fields to "instance
group" and "instance ID", respectively, per discussion on the bug.
A follow-up will change the types of the instance group and ID fields to
be optional UnguessableTokens instead of free-form strings.
TBR=jam@chromium.org
Bug: 895591
Change-Id: I0c4d75f5e12a468dad251f238813bc79c497830a
Reviewed-on: https://chromium-review.googlesource.com/c/1318836
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605849}
This CL hooks the Clang code coverage wrapper into the build
toolchains, and specifically, a new build flag:
coverage_instrumentation_input_file is added to allow turning on/off
the wrapper and pass the list-files-to-instrument around.
Bug: 898695
Change-Id: I405ccbfc1796afa44534794d711f2953fac78f6d
Reviewed-on: https://chromium-review.googlesource.com/c/1309999
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604858}
The page had gotten badly out of date. This CL rewrites most
of it to reflect current policy and practice and stops pointing
to viewvc for other links ;)
Change-Id: I62cc952a6f56954af723f4d57b2fadfd84227bda
Reviewed-on: https://chromium-review.googlesource.com/c/1298650
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604750}
We've had a number of surprised/disappointed reporters lately, so
although there is no policy change, repeat the language describing
the policy closer to where it is referenced.
Change-Id: I300bc3e05b5055c66253a4ab8d31d9e82e40dc1e
Reviewed-on: https://chromium-review.googlesource.com/c/1312982
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604667}
This CL implements the Clang code coverage compiler wrapper, which can
be used to instrument a subset of source files, and the main use case
is to enable generating code coverage reports at per-cl level during
try jobs.
This CL only focuses on the wrapper itself, how to hook this wrapper
into the build system will be addressed in a separate CL.
Bug: 898695
Change-Id: Idb21640b5566ce78089059b3d0116390b488a383
Reviewed-on: https://chromium-review.googlesource.com/c/1301969
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604381}
Before crrev.com/c/1277654 when we created text results for ref tests
most of which don't need text baselines, we let reftest's text baseline
be optional, so that most reftests can ignore the text results, while
a few of them for which the text result is significant can still check
the text results.
After crrev.com/1277654, reftests no longer produce text results thus
don't need text baseline, unless a test explicitly produces text result.
In this case, we can just let the test determine if the text baseline
is needed, instead of run_web_tests.py checking existance of the
text baselines.
About existing reftests producing text results but without text
baselines:
1. for tests that don't actually need text results, modify them so that
they no longer produce text results. This includes some tests
previously calling testRunner.dumpAsTextWithPixelResults() just
to dump pixel results.
2. for tests that produce meaningful text results, create text
baselines.
3. for tests that don't produce text results intentionally, but the
text results are created because of some console messages, etc.
also create text baselines. There are several cases:
a) the message shows the purpose of the test, e.g. intentionally
testing with some invalid values. New text baselines are created
in this CL.
b) the message shows some problem of the test that doesn't need to
fix for now, e.g. the test is using some deprecating API. New
baselines are created in this CL.
c) the message indicates some fatal bug in the test, e.g. using
undefined variable, invalid JavaScript grammar, etc. The bugs are
fixed in this CL.
Bug: 703899
Change-Id: I82a6b25c61d1fb794840fdaa0da248909a690592
Reviewed-on: https://chromium-review.googlesource.com/c/1298120
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604116}
SHERIFFS: PLEASE DO NOT REVERT THIS CL BECAUSE OF A SMALL AMOUNT OF LAYOUT
TEST FLAKINESS. If a few layout tests begin to show flakiness after this CL
lands, please add them to TestExpectations and email me (masonfreed@) to
investigate. Though I tried to identify all potentially flaky tests, a few
may have slipped through.
With this CL, the --enable-display-compositor-pixel-dump flag becomes the default
for content_shell. With this flag in place, layout test pixel dumps are performed
from the browser side, instead of from the renderer side. Note that to avoid a
significant amount of layout test flakiness, another change was also made to
not add the --run-all-compositor-stages-before-draw flag by default. There is
a bug (crbug.com/894613) tracking that problem separately.
With the flip of this switch, several modifications had to be made to the
TestExpectations file. First, there are a number of tests that change their
appearance slightly when being captured from the browser, and these tests need
to be rebaselined. These are summarized below, and will be rebaselined as a
separate CL, once this one lands and has had time to stabilize.
These bugs track the items added to TestExpectations:
- crbug.com/887140: HDR support
- crbug.com/881040: Media controls now contain an overflow menu.
- crbug.com/667551: A bunch of tests are listed under this bug, and just
require rebaselining to fix non-material single-pixel
antialiasing failures.
- crbug.com/891427: These either start failing, or become flaky, when the
--enable-display-compositor-pixel-dump flag is enabled.
They need to be debugged prior to re-enabling.
- crbug.com/895556: These tests double their background size when the flag
is enabled. They need to be fixed or rebaselined.
Bug: 667551, 891427, 881040, 887140, 894613, 895556
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I46946e6377f659c9dedc0dfaa20e7658e8cc519d
Reviewed-on: https://chromium-review.googlesource.com/c/1213864
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603127}
Question on tasks blocking forever contains answer that applies to the general
case. This CL adds a new question that answer the general case:
How to make a blocking call without affecting other tasks?
The question:
How to make a blocking call that may never return without affecting other tasks?
references the general case and confirms that it also works in that case.
Change-Id: I2237853301b946c661fcdc623188e26877633404
Reviewed-on: https://chromium-review.googlesource.com/c/1300033
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603109}
select_to_speak_extension_tests compiles and links all of chrome, so
folding into browser_tests will save work on the bots. It will also
give coverage for SingleProcessMash and other projects that run
browser_tests with optional flags.
Bug: 892179
Change-Id: I8dfce56a8b522194dfbb0d24de7cb8f5cdd45b01
Reviewed-on: https://chromium-review.googlesource.com/c/1300073
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602964}
chromevox_tests compiles and links all of chrome, so folding into
browser_tests will save work on the bots. It will also give coverage
for SingleProcessMash and other projects that run browser_tests with
optional flags.
Rename the tests to start with ChromeVox to make them easier to run
with --gtest_filter (thanks to dtseng for a CL that did the rename).
Fix ChromeVoxEditingTest.RichTextSelectByLine so it isn't sensitive
to exact font widths and remove chromevox_tests fontconfig override.
Bug: 892179, 898213
Test: browser_tests
Change-Id: Ia23c8f4c237677d299bbe774cf3191654974a56b
Reviewed-on: https://chromium-review.googlesource.com/c/1294811
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602543}
Now for tests that don't call any dumpAsXXX methods, they by default
generate pixel results only, and run_web_tests.py just check their
pixel results against the corresponding pixel baselines only.
Provide testRunner.dumpAsLayout() and dumpAsLayoutWithPixelResults()
for tests that do need to dump the layout tree.
We still dump layout tree when running such tests in content_shell
--run-web-tests command line (instead of running from run_web_tests.py
in protocol mode).
Changes to layout tests and their expectations:
- Use testRunner.dumpAsLayoutWithPixelResults() or dumpAsLayout()
in some tests that still requires the layout dump:
- editing/ tests need layout dump to show the caret position.
- two printing/ tests need layout dump to show how the bug is
fixed.
In the future, we may just get rid of layout dumps if it's
feasible.
- Remove testRunner.dumpAsTextWithPixelResults() from some tests
which used the function just to suppress layout output. They didn't
actually want text output but we hadn't had a way to dump image only
until we had the ImageFirst feature.
- Previous platform-specific -expected.txt for tests under previous
ImageFirst directories are removed and the common baselines are
created because the baselines are no longer platform-specific without
the layout dump.
Extra -expected.txt baselines are not deleted in this CL. Will
follow-up in https://chromium-review.googlesource.com/c/chromium/src/+/1286894.
Bug: 703899
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ifcf7fea90684e133b4222909ee508469d0c985e0
Reviewed-on: https://chromium-review.googlesource.com/c/1277654
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602161}
Update the documentation to run brltty on linux as well. This is sometimes hard to [re]discover.
Change-Id: Ia6cfefa2af9465762fc31c8077fec7310edca083
Reviewed-on: https://chromium-review.googlesource.com/c/1294512
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601811}
It's been defaulted to true for a while now on Linux and Windows,
so rely on the default setting instead.
Bug: none
Change-Id: Id24297dff08b28ee5e28f6cb6267018a4a1443e1
Reviewed-on: https://chromium-review.googlesource.com/c/1294298
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601777}
Wayland does not come with mus. Thus, update the doc respectively.
What is more, add a note about minigbm usage with Ozone/Wayland.
Change-Id: I66194efccfef75d4496a2f74a7d8c3ec9fe53ee2
Reviewed-on: https://chromium-review.googlesource.com/c/1282066
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600683}
This is a reland of 8aeb9cc962
Original change's description:
> [TaskScheduler]: Add section to faq: when to annotate with ScopedBlockingCall.
>
> Developpers are often wondering whether or not ScopedBlockingCall is redundant.
>
> Change-Id: Ic7936ef805f43f7fc02d0ad3020c31d8364b099d
> Reviewed-on: https://chromium-review.googlesource.com/c/1271878
> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599626}
Change-Id: I0850821994e3b4a1b0c3bb238725bc28867d18f5
Reviewed-on: https://chromium-review.googlesource.com/c/1280281
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599952}
apk_size_regressions.md: Make use of size trybot.
html_report_faq.md: Link to README.md
README.md: Add resource_sizes.py and size trybot
README.md: Document all "Overhead:" symbols.
README.md: Mention Bloaty McBloatface
Change-Id: I4cab3b7cd4c711931e9cae102e2354408cfbdd02
Reviewed-on: https://chromium-review.googlesource.com/c/1278721
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599719}
- Remove UpdatePackageLists* since this functionality was already performed by
BuildSysroot*.
- Remove the "Revision" key from sysroots.json since the "Sha1Sum" key is enough
to uniquely identify each sysroot.
- Move packagelist.* into generated_package_lists/*. There were at least 2
occasions where folks tried to manually update these files.
R=thestig
BUG=None
Change-Id: Id7f8ea9ade6b2f445997f445412ec2120b3f7770
Reviewed-on: https://chromium-review.googlesource.com/c/1268942
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598043}
It seems the target to build is no longer telemetry_perf_tests but
performance_test_suite.
TBR=thakis
Bug: none
Change-Id: Ib15b98921faf1fed5c0451ffb06d9ba884f2874e
Reviewed-on: https://chromium-review.googlesource.com/c/1269868
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597858}
This is a reland of 9d5ef42ab6
Original change's description:
> Remove perf_expectations
>
> This is a modified reland of [1] with most of the changes to sizes.py reverted.
> Those changes are still used by the perf dashboard so must be kept around for
> the time being.
>
> [1] 5f552b3996
>
> R=dpranke
> Bug: 572393
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng;luci.chromium.try:win_archive;luci.chromium.try:win_x64_archive;master.tryserver.chromium.android:android_archive_rel_ng
>
> Change-Id: I459387d50f4a328192110c7b75983523a14f787d
> Reviewed-on: https://chromium-review.googlesource.com/c/1255303
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#597614}
R=dpranke
Bug: 572393
Cq-Include-Trybots: luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng;luci.chromium.try:win_archive;luci.chromium.try:win_x64_archive;master.tryserver.chromium.android:android_archive_rel_ng;master.luci.chromium.try:android_cronet
Change-Id: I19d2e305ff842b61aa518b2a3f4d63a393126981
Reviewed-on: https://chromium-review.googlesource.com/c/1269104
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597738}
This reverts commit 9d5ef42ab6.
Reason for revert: See crbug.com/893254; looks like a typo in the script.
Original change's description:
> Remove perf_expectations
>
> This is a modified reland of [1] with most of the changes to sizes.py reverted.
> Those changes are still used by the perf dashboard so must be kept around for
> the time being.
>
> [1] 5f552b3996
>
> R=dpranke
> Bug: 572393
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng;luci.chromium.try:win_archive;luci.chromium.try:win_x64_archive;master.tryserver.chromium.android:android_archive_rel_ng
>
> Change-Id: I459387d50f4a328192110c7b75983523a14f787d
> Reviewed-on: https://chromium-review.googlesource.com/c/1255303
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#597614}
TBR=thakis@chromium.org,dpranke@chromium.org,thomasanderson@chromium.org
Change-Id: Ife13ece23ed3513225003bd18fbe27b0bbf16afc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 572393
Cq-Include-Trybots: luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng;luci.chromium.try:win_archive;luci.chromium.try:win_x64_archive;master.tryserver.chromium.android:android_archive_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/c/1268904
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597633}
This is a modified reland of [1] with most of the changes to sizes.py reverted.
Those changes are still used by the perf dashboard so must be kept around for
the time being.
[1] 5f552b3996
R=dpranke
Bug: 572393
Cq-Include-Trybots: luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng;luci.chromium.try:win_archive;luci.chromium.try:win_x64_archive;master.tryserver.chromium.android:android_archive_rel_ng
Change-Id: I459387d50f4a328192110c7b75983523a14f787d
Reviewed-on: https://chromium-review.googlesource.com/c/1255303
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597614}
Including a reminder for sheriffs to download attachment and unzip zip files, and how to
deal with Chrome OS issues.
Change-Id: I286b2a3f25a19d43f11ebc92c7bcda6e489322c8
Reviewed-on: https://chromium-review.googlesource.com/c/1266057
Commit-Queue: Andrew Whalley <awhalley@google.com>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597372}
