This is a follow-up CL to crrev.com/c/3504190 , which added a large
amount of documentation for Android accessibility. This CL is meant to
fix typos, formatting, confusing wording, etc.
AX-Relnotes: N/A
Bug: N/A
Change-Id: I3e4c162c9483362e9dafa4ed4fc7e35c3f5dd230
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3508331
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Commit-Queue: Mark Schillaci <mschillaci@google.com>
Cr-Commit-Position: refs/heads/main@{#978489}
This CL adds a significant amount of documentation to the accessibility
docs for Android. The CL expands on the existing file:
docs/accessibility/browser/android.md
AX-Relnotes: N/A
Bug: N/A
Change-Id: Icb1ef626f8fdb737bb2beef2061d8cf397ffc1cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3504190
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Commit-Queue: Mark Schillaci <mschillaci@google.com>
Cr-Commit-Position: refs/heads/main@{#977864}
This is an automatically generated changelist based on group memberships and affiliations, with some transition delay.
To approve this change, CR+1/2 this change and submit. To reject this change, CR -1 this change, and the bot will abandon the change.
To report an issue, file a bug in the Infra>Security component.
Change-Id: Ie8c2ba481ff3314680cc5143b7aadd7e4aad5501
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3501502
Auto-Submit: Owners Cleanup <swarming-tasks@owners-cleanup-prod.google.com.iam.gserviceaccount.com>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#977145}
This is a production version of the FYI builder android-12-x64-fyi-rel
with the following differences:
1. The trybot is migrated to orchestrator (pool already allocated).
2. chrome_public_test_apk is marked as ci_only and experimental.
The FYI builder's mb & test configs are removed, and LUCI config is kept
so that the build links in the related bugs are accessible.
Bug: 1225851
Change-Id: I59be4a8f32caebe9449373296d1257b42139079a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3496937
Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/main@{#977015}
It can be tricky for security sheriffs to reproduce bugs that are
specific to Android, especially for those of us who don't do Android
Chrome development as part of our daily work. This adds some pointers to
our sheriffing docs.
Change-Id: I0e74ee94814dca821c650e19f7aaf468a4ee2260
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3501096
Reviewed-by: Adrian Taylor <adetaylor@chromium.org>
Commit-Queue: Chris Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/main@{#976882}
WebUI::DeprecatedMessageCallback2 is taking base::Value::ConstListView,
with changed plans around base::Value refactoring it should be
const base::Value::List& instead.
This CL adds new MessageCallback and corresponding
RegisterMessageCallback() unblocking actual refactoring of callers.
This CL also includes an examples of how the refactoring will look like.
Bug: 1300095
Change-Id: Ibaf0b075b4fd60f99f393535cebce154965f4bce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3483819
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Mohamad Ahmadi <mahmadi@chromium.org>
Commit-Queue: Mohamad Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#975287}
Xcode 13.1 or higher is required to build Chrome on iOS (required
for the catalyst environment). Bump the version in the documentation
and the version check in the code.
JDK is no longer used for the build, remove it from the list of
required software.
Bug: none
Change-Id: If4ddf544b70e2c032ac3e4af95b40a02865e3b9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3487908
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mike Pinkerton <pinkerton@chromium.org>
Commit-Queue: Mike Pinkerton <pinkerton@chromium.org>
Cr-Commit-Position: refs/heads/main@{#974670}
Currently, to prevent need of setting up user prefs in every test that
want to interact with quick_unlock, there's an EnabledForTesting API
that sets a global test flag to override all checks. But there are more
than one purposes an auth method can be used for, and also more than one
quick_unlock auth methods. Making the APIs and underlying mechanisms
more complicate can give tests more fine-grained control of what they
expect to be enabled in the test, and might help us capture some bugs in
code that accessed wrong set of purposes for auth methods. Put these
test apis into a TestApi class.
Bug: b:214871750
Test: CQ
Test: all modified unit tests, browser tests
Change-Id: I7d67fd8de77c35ab4bc36feec93b4c03bc48eacf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3412557
Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Jon Mann <jonmann@chromium.org>
Commit-Queue: Howard Yang <hcyang@google.com>
Cr-Commit-Position: refs/heads/main@{#973440}
I suspect we actually never want this type of quote. However,
correcting them everywhere seems a lot of useless work. In the case of
code snippet however, it seems important to have it right.
Bug: 1294776
Change-Id: I71d63c902a959a3bede5aeb48bc2500a232097f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3443425
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Auto-Submit: Arthur Milchior <arthurmilchior@google.com>
Commit-Queue: Arthur Milchior <arthurmilchior@google.com>
Cr-Commit-Position: refs/heads/main@{#971228}
The "More" button in Gerrit is now labeled with three (vertical, but ah
well) dots. Also sheriffbot has one more merge request question these
days.
Change-Id: If6298f071976e7fddba1edaedba8d400e24ddae9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3278713
Reviewed-by: Alex Mineer <amineer@chromium.org>
Commit-Queue: Alex Mineer <amineer@chromium.org>
Cr-Commit-Position: refs/heads/main@{#970872}
Legacy SwiftShader GL is deprecated, so remove it from existing
documentation, so that only SwANGLE related documentation remains.
Bug: chromium:1060139
Change-Id: I1a59d7b4a57f80cbe627df0a77430450296df607
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3452836
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@google.com>
Cr-Commit-Position: refs/heads/main@{#969936}
* -v now shows emulator logs for "start" command
* "start" now runs "install" if obviously necessary (config.ini not present)
* "list" command added, which makes it clear what --avd-config options
exist.
Bug: 1276006
Change-Id: Idc37641d9a665f7460e2eabe5348aea1e262d247
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3438186
Reviewed-by: Haiyang Pan <hypan@google.com>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#969283}
This CL renames the DummyUiActivity class to BlankUiTestActivity.
Per Google's documentation and style guidelines, the words "dummy" and
"dumb down" should be avoided. For this reason we are replacing the
DummyUiActivity with the more appropriately named BlankUiTestActivity.
We also make the following renames:
DummyUiActivityTestRule -> BlankUiTestActivityTestRule
DummySettingsForTest -> PlaceholderSettingsForTest
This CL also makes updates to comments and method names where needed
to match these changes.
Bug: 1295312
Change-Id: Ib712a292e0dcee32a97e9d7c487af2fb920f5084
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3445111
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Mark Schillaci <mschillaci@google.com>
Cr-Commit-Position: refs/heads/main@{#969056}
If the Windows SDK was installed without the option to add the ARM64
components, package_from_installed.py will fail unless the --noarm
parameter is used. This CL adds a note in docs/win_cross.md pointing
to this.
Change-Id: I00e46366101857d2cb5e68b40220202e5e66a362
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3448950
Reviewed-by: Joanmarie Diggs <jdiggs@igalia.com>
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Cr-Commit-Position: refs/heads/main@{#968869}
