chromium/src
0
Fork 0
Code Activity
885,206 Commits 3 Branches 23,233 Tags
fe097a691bc8e3c8d3d331e015a720a394b48d30
Commit Graph

8 Commits

Author SHA1 Message Date
Alexander Timin
e3ec419d4f [content] Add RenderFrameHostImpl::GetPageUkmSourceId. 
Replace WebContentsImpl::GetUkmSourceIdForLastCommittedSource with a
RenderFrameHost-based method.

- RenderFrameHost-based method works correctly for non-current frames,
  unlike WebContentsImpl-based method.
- GetPageUkmSourceId (page load == main-frame committed cross-document
  navigation) should be more intuitive than
  GetUkmSourceIdForLastCommittedSource.

BUG=1061899
R=alexmos@chromium.org,rkaplow@chromium.org
TBR=alexmos@chromium.org
CC=​​​​bmcquade@chromium.org,csharrison@chromium.org

Change-Id: I66d1520fbcb8ea4b59d7d0c3cbcbdbfa16516789
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132393
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760530}
 2020-04-20 16:39:40 +00:00
Charlie Harrison
ef958bff87 Move ukm_source to //services/metrics/public 
This is in preparation to add a struct UkmSource::Metadata, which would need to be used
in //services.

TBR=sky@chromium.org

Bug: 873316
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I0d33f6ece24b9176ff86310ef2e7347453b5ccfa
Reviewed-on: https://chromium-review.googlesource.com/1179992
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584441}
 2018-08-20 14:49:02 +00:00
Steven Holte
380413484b Add UKM SourceID getter to WebContentsImpl. 
Bug: 797586
Change-Id: I357e5b945886e51043d662973c9a1960f9b46929
Reviewed-on: https://chromium-review.googlesource.com/1086413
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569799}
 2018-06-22 22:00:57 +00:00
Gyuyoung Kim
f4e2e65212 Replace base::MakeUnique with std::make_unique in content/ 
base/memory/ptr_util.h includes are changed with <memory> as well.

Bug: 755727
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ieb3fecb7841ff58dd8ddfee1c164ff522176da57
Reviewed-on: https://chromium-review.googlesource.com/807827
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522129}
 2017-12-06 17:47:08 +00:00
Steven Holte
a027016501 Partial reland of UKM test conversion. 
This relands 290a793995 which was
reverted by 16af3fb66b, except
that it omits the changes to test that flaked.

TBR=asvitkine

Bug: 761524
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I6d68e0a7cab7307544c4ddda5df3d153bc3d69a4
Reviewed-on: https://chromium-review.googlesource.com/802415
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520832}
 2017-12-01 03:23:06 +00:00
Scott Graham
16af3fb66b Revert "Convert UKM tests to express expectations over specific entries." 
This reverts commit 290a793995.

Reason for revert: Appears to be flaking on Windows, filed https://bugs.chromium.org/p/chromium/issues/detail?id=790806 for followup.

Original change's description:
> Convert UKM tests to express expectations over specific entries.
> 
> As part of the switch to using shared SourceIds, we will start
> associating the same URL with multiple SourceIds, and this will
> break all tests that currently use GetSourceForUrl and similar.
> 
> This avoids that by converting existing tests to use a new test
> recorder API which lets test express expectations over the entries
> they are recording.
> 
> Bug: 761524
> TBR=bmcquade
> 
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
> Change-Id: I43f0e09e026fa1373869ea5530427f88f6317a7a
> Reviewed-on: https://chromium-review.googlesource.com/774120
> Commit-Queue: Steven Holte <holte@chromium.org>
> Reviewed-by: Raymes Khoury <raymes@chromium.org>
> Reviewed-by: Erik Chen <erikchen@chromium.org>
> Reviewed-by: Peter Williamson <petewil@chromium.org>
> Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Mathieu Perreault <mathp@chromium.org>
> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
> Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: vmpstr <vmpstr@chromium.org>
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#520398}

TBR=avi@chromium.org,raymes@chromium.org,dalecurtis@chromium.org,vmpstr@chromium.org,petewil@chromium.org,vasilii@chromium.org,mathp@chromium.org,asvitkine@chromium.org,erikchen@chromium.org,hajimehoshi@chromium.org,mlamouri@chromium.org,tdresser@chromium.org,holte@chromium.org,bmcquade@chromium.org

Change-Id: I1b57d01ba3ff23637d3069e4e280f923fbc6f255
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 761524
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/802357
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520760}
 2017-12-01 00:08:31 +00:00
Steven Holte
290a793995 Convert UKM tests to express expectations over specific entries. 
As part of the switch to using shared SourceIds, we will start
associating the same URL with multiple SourceIds, and this will
break all tests that currently use GetSourceForUrl and similar.

This avoids that by converting existing tests to use a new test
recorder API which lets test express expectations over the entries
they are recording.

Bug: 761524
TBR=bmcquade

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I43f0e09e026fa1373869ea5530427f88f6317a7a
Reviewed-on: https://chromium-review.googlesource.com/774120
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Peter Williamson <petewil@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520398}
 2017-11-30 02:47:50 +00:00
Raymes Khoury
978652cd62 Add UKM to record actions associated with the Pepper Broker 
Records when the Pepper broker process channel is opened by a plugin.

Bug: 756138
Change-Id: Ibc480af41cb0f0b004d167dcefae325e7920b7ad
Reviewed-on: https://chromium-review.googlesource.com/778743
Commit-Queue: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519228}
 2017-11-27 06:28:37 +00:00