01f166fbc8
This code is identical to that extracted to a helper method in [1] modulo one small difference: the helper method DCHECKs that the SIF has an equivalent BufferFormat. This CL changes GpuChannelSII to reuse the helper. Inspection of [2] indicates that the DCHECK mentioned above was likely inadvertently omitted from this impl when it was originally introduced, as its body was taken from the code introduced to shared_image_interface_in_process.cc in [3]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/6088091 [2] https://chromium-review.googlesource.com/c/chromium/src/+/5523596 [3] https://chromium-review.googlesource.com/c/chromium/src/+/5191211 Bug: 379996128 Change-Id: I3a1984132f590ba5d2ff7bec6736f9de7a281ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6097432 Reviewed-by: vikas soni <vikassoni@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/main@{#1396926}
v8
@ d7786a7763
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.