This is mainly for the following code path
ChromeClient::InvalidateRect()
-> WebViewImpl::InvalidateRect()
-> WebViewClient::DidInvalidateRect()
-> WebViewPlugin::WebViewHelper::DidInvalidateRect()
-> WebPluginContainerImpl::InvalidateRect()
-> LayoutObject::InvalidatePaintRectangle()
to remove the rectangle parameter because in most cases we do full
paint invalidation. Rename some functions to InvalidateContainer() to
make it clear the meaning (i.e. not to invalidate the content of the
view/frame).
Also remove LocalFrameView::Invalidate() and InvalidateRect() which
were parallel implementation of the above code path for frame views,
but were no longer used or were used incorrectly (e.g. the usage from
WebViewImpl::ThemeChanged() which should fully invalidate all frames).
Also remove RemoteFrameView::InvalidateRect() which was dead code.
This removes two callers of LayoutObject::InvalidatePaintRectangle().
If we can remove all callers of it, we can remove the partial paint
invalidation code (especially the callbacks in DisplayItemClient).
Change-Id: Iea79e6000a888feb2074de8fd8b7d53aa4d84165
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2843205
Reviewed-by: K. Moon <kmoon@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#875343}
06000e9865