064192c2f9
Rather than converting from Unix timestamp to UTC string in Python and then back again in C++, this CL passes a Unix timestamp integer between the build timestamp generator in Python, and the GetBuildTime() function in base. This avoids any chance for formatting or locale messing with the value, and also allows the GetBuildTime() function to be converted to a constexpr function. This CL should not have any functionality change, as the only code that should be accessing BUILD_DATE is the code in base. BUG=1407664 Change-Id: I6ca83a4b03c24e78962cb6a86e9975a90f75da33 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4336202 Reviewed-by: Peter Boström <pbos@chromium.org> Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/main@{#1118187}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.