09d8b92a7e
This reverts commit b5e047c776.
Reason for revert:
LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8719120644971767441
Sample failed build: https://ci.chromium.org/b/8719120644971767441
If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6393815&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8719120644971767441&type=BUG
Original change's description:
> Enable unsafe libc calls in Chromium's unsafe buffer paths file.
>
> One-line change to ease revert if some untestable downstream build
> breaks with an `error: ... is unsafe` warning.
>
> Bug: 390223051
> Change-Id: I5852938e12745d8f859d207d55f679f8e56ab137
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6393815
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Mega-CQ: Tom Sepez <tsepez@chromium.org>
> Commit-Queue: Tom Sepez <tsepez@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1439688}
>
Bug: 390223051
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I289079a905c2436b9db8385e10e14a8ed5e5d564
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6410571
Commit-Queue: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>
Bot-Commit: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>
Owners-Override: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1439705}
About
//build contains:
- Core GN templates and configuration
- Core Python build scripts
Since this directory is DEPS'ed in by some other repositories (webrtc, pdfium,
v8, etc), it should be kept as self-contained as possible by not referring
to files outside of it. Some exceptions exist (//testing, select
//third_party subdirectories), but new dependencies tend to break these other
projects, and so should be avoided.
Changes to //build should be landed in the Chromium repo. They will then be
replicated to the stand-alone build repo
by the gsubtreed tool.
Note: You can find all directories already available through gsubtreed in the
list of all chromium repos.
Contents
//build/config- Common templates via.gnifiles.//build/toolchain- GN toolchain definitions.Other .py files- Some are used by GN/Ninja. Some by gclient hooks, some are just random utilities.
Files referenced by //.gn:
//build/BUILDCONFIG.gn- Included by allBUILD.gnfiles.//build/secondary- An overlay forBUILD.gnfiles. Enables addingBUILD.gnto directories that live in sub-repositories.//build_overrides- Refer to //build_overrides/README.md.