
This reverts commit3170dc6cf2
. Reason for revert: Not all of the args passed in or file names, so the breaking up into multiple invocations needs to be done at a higher level. Original change's description: > Reland "Fix Windows path limits in eslint.py" > > This reverts commit0201b449e3
. > > Reason for revert: The bug in the original version is now fixed. I > tested by patching in this change to verify that the type errors are > resolved by the fix. I also tested with 3565347 and 3564185 patched in > to avoid separate errors - then I was able to get this command to > run to completion: > > git cl presubmit --files=*.js > > Original change's description: > > Revert "Fix Windows path limits in eslint.py" > > > > This reverts commitcf4af5c6cc
. > > > > Reason for revert: causes all JS presubmits to fail due to type > > confusion detected by a check subsequently landed in > > https://crrev.com/c/3566436 > > > > Bug: 1312819 > > > > Original change's description: > > > Fix Windows path limits in eslint.py > > > > > > When running "git cl presubmit --all" the eslint.py script may be called > > > with ~1,100 or more arguments. This leads to a command line that is too > > > long for Windows to handle. This change invokes eslint multiple times to > > > avoid hitting the limit. > > > > > > This change was initially blocked by a buggy presubmit which was fixed > > > in crrev.com/c/3553927. > > > > > > This change can be (and has been) tested with this command (using the > > > recently added --files option): > > > > > > git cl presubmit --files=*.js --force > > > > > > For much faster results return early from PanProjectChecks in > > > depot_tools/presubmit_canned_checks.py. > > > > > > See crrev.com/c/3554633 for another example of fixing this issue. > > > > > > Bug: 1309977 > > > Change-Id: If97d9a7e5258f2783d6cd9a01a6a8b3095a1ae54 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3554791 > > > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > > > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> > > > Cr-Commit-Position: refs/heads/main@{#988257} > > > > Bug: 1309977 > > Change-Id: I51a1091be1f5a394c3f66a971df21d3c6b091e94 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3565505 > > Auto-Submit: Trent Apted <tapted@chromium.org> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Reviewed-by: Eliot Courtney <edcourtney@chromium.org> > > Commit-Queue: Eliot Courtney <edcourtney@chromium.org> > > Owners-Override: Eliot Courtney <edcourtney@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#988363} > > Bug: 1312819 > Bug: 1309977 > Change-Id: Ie64c2e2d914fd7e5ea67dceab9ad73ed0c06f4d2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3569195 > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> > Cr-Commit-Position: refs/heads/main@{#988604} Bug: 1312819 Bug: 1309977 Change-Id: I072a2115aa9dc922a155e89a618cb11d4498a1ac No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3571163 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Eliot Courtney <edcourtney@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/main@{#988977}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.