0f58e5ed22
The most popular arm64 builds (Trichrome) are shipping with is_high_end_android. The Monochrome arm64 builds are shipped for old devices, and we expect these to gradually become less popular. This change sets is_high_end_android to true for arm64 builds by default. This would make local benchmarking slightly less error prone because there would be a little less to remember to set in GN args when making a build for the most popular official configuration. Known effects: 1. Seemingly all official arm64 builders now explicitly set is_high_end_android. Hence no effect for them. 2. Non-official arm64 builders will change to become high-end, even the ones that end up running on old devices (example: android-arm64-rel). In this patch we make sure that is_high_end_android is ignored for non-official builds (disabled RELR relocations for non-official). Hence, no effect here as well. 3. Official builds of Monochrome made by devs would fail to run on Android pre-P (because RELR support is lacking). This leads to mysterious crashes during something-dlopen in the Android dynamic linker. Hopefully nobody does this before we remove support for Android O. Bug: 1515925 Change-Id: I695c98852bb410894144452211aa06cc32ffb141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5169071 Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/main@{#1247286}
v8
@ 6fd1030038
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.