
This reverts commit59616a84f2
. Reason for revert: Still causes same bot failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20CFI/28345/overview Original change's description: > Reland "Reland "[PDF Ink Signatures] Switch DrawRenderTransform test case to call Draw()"" > > This is a reland of commitd46dcdd094
> > Also do fuzzy matching for MSAN, like ASAN and TSAN. > > Original change's description: > > Reland "[PDF Ink Signatures] Switch DrawRenderTransform test case to call Draw()" > > > > This is a reland of commit9d82486a93
> > > > This reland changes the pixel comparators. Where possible, the tests use > > cc::ExactPixelComparator(). For build configs where the rendering is not > > pixel perfect, use cc::FuzzyPixelComparator, configured as a > > "FuzzyPixelOffByTwoComparator". > > > > Original change's description: > > > [PDF Ink Signatures] Switch DrawRenderTransform test case to call Draw() > > > > > > Remove the code that checks the transformed Draw() would have used, and > > > instead check the output from Draw(). Add a FuzzyMatchesPngFile() test > > > utility to check against new expectation PNGs in //pdf/test/data/ink. > > > The existing exact-pixel MatchesPngFile() function mostly works, but not > > > for ASAN/TSAN. > > > > > > Bug: 351990827 > > > Change-Id: Ie11244bcfe91a413f102b8a3bbc34d4c199f789c > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5871447 > > > Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> > > > Reviewed-by: Alan Screen <awscreen@chromium.org> > > > Commit-Queue: Lei Zhang <thestig@chromium.org> > > > Cr-Commit-Position: refs/heads/main@{#1357215} > > > > Bug: 351990827 > > Change-Id: Ibe0fa6b02cf163b690131711d0d360bf4ec35c48 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5874106 > > Commit-Queue: Lei Zhang <thestig@chromium.org> > > Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> > > Reviewed-by: Alan Screen <awscreen@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1358916} > > Bug: 351990827 > Change-Id: I1c354c16692c3d6916217f7c6a0904fae343577d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5883508 > Reviewed-by: Alan Screen <awscreen@chromium.org> > Commit-Queue: Lei Zhang <thestig@chromium.org> > Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1359403} Bug: 351990827 Change-Id: I00166435bef1408226c8b2c63f74e5f10e6f77f8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5889353 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Auto-Submit: Yoichi Osato <yoichio@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Yoichi Osato <yoichio@chromium.org> Owners-Override: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/main@{#1359698}
//pdf
contains the PDF plugin, its Blink-based replacement, as well as PDF
utility functions that leverage PDFium. It can use low-level components that
live below the content layer, as well as other foundational code like
//printing
. It should not use //content
or anything in //components
that
lives above the content layer. Code that lives above the content layer should
live in //components/pdf
, or in the embedder. All the code here should run in
sandboxed child processes.
TODO(crbug.com/40186598): Remove existing //content
dependencies.