1cb5a0980c
In case the secret portal sends back an error, one of two things may happen: 1. We receive the DBus response first 2. The file descriptor signals EOF We always want the first case to occur for metrics logging, but sometimes (0.02% of the time according to [1]) the second case occurs and an empty secret is logged to UMA. This CL fixes the issue by starting to read from the file descriptor only after getting a response from DBus. Fixing this also exposed a bug in the testing environment: the fix is to inject the test portal name into dbus_xdg::Request. It was incorrectly working before because SecretPortalKeyProvider was reading the secret first, bypassing the DBus signal code. [1] https://docs.google.com/document/d/1ccFfyNaFtLNp6KypY5mjANtFcIOYPdSPBu8fLRmzsD0/edit?usp=sharing R=thestig Bug: 40086962 Change-Id: I341a9f5dcf8d237a33dd1fa88601b46d9a08f993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6142794 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/main@{#1405604}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.