1ec1f49fa7
Service binding without `Context.BIND_NOT_FOREGROUND` ends up boosting the process's cpu priority and put the process to the foreground cpu cgroup. The not perceptible binding is used to represent "Invisible tabs used in the foreground session". ChildProcessLauncherHelperImpl.setPriority() adds the not perceptible binding when the renderer process becomes visible and BindingManager.onTrimMemory() removes the not perceptible bindings of all renderer processes when the browser goes background. Invisible processes do not need cpu priority and rather too many invisible processes in the foreground cpu cgroup ends up leaving smaller cpu quota to other visible processes. This change does not invalidate cpu priority boosting from other service bindings. For example, "background tabs used in the foreground session" with foreground service worker will have the not perceptible binding and the visible binding then the latter boosts the cpu priority. This change does not affect WebView because WebView does not use the not perceptible binding due to ChildProcessCreationParamsImpl.getIgnoreVisibilityForImportance() This change is guarded by BackgroundNotPerceptibleBinding feature flag. Bug: 406091734 Change-Id: I7c4a54538e4cdfa51e9c126b801632da3f1189df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6390075 Reviewed-by: Bo Liu <boliu@chromium.org> Reviewed-by: Francois Pierre Doray <fdoray@chromium.org> Commit-Queue: Shin Kawamura <kawasin@google.com> Cr-Commit-Position: refs/heads/main@{#1438541}
v8
@ 806e635a39
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.