
This reverts commitd46dcdd094
. Reason for revert: suspect causing PdfInkModuleStrokeTest.DrawRenderTransform failure on Linux MSan Tests and Linux ChromiumOS MSan Tests pdf_unittests failed because of: PdfInkModuleStrokeTest.DrawRenderTransform First build failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/46353/overview https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20MSan%20Tests/50742/overview Original change's description: > Reland "[PDF Ink Signatures] Switch DrawRenderTransform test case to call Draw()" > > This is a reland of commit9d82486a93
> > This reland changes the pixel comparators. Where possible, the tests use > cc::ExactPixelComparator(). For build configs where the rendering is not > pixel perfect, use cc::FuzzyPixelComparator, configured as a > "FuzzyPixelOffByTwoComparator". > > Original change's description: > > [PDF Ink Signatures] Switch DrawRenderTransform test case to call Draw() > > > > Remove the code that checks the transformed Draw() would have used, and > > instead check the output from Draw(). Add a FuzzyMatchesPngFile() test > > utility to check against new expectation PNGs in //pdf/test/data/ink. > > The existing exact-pixel MatchesPngFile() function mostly works, but not > > for ASAN/TSAN. > > > > Bug: 351990827 > > Change-Id: Ie11244bcfe91a413f102b8a3bbc34d4c199f789c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5871447 > > Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> > > Reviewed-by: Alan Screen <awscreen@chromium.org> > > Commit-Queue: Lei Zhang <thestig@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1357215} > > Bug: 351990827 > Change-Id: Ibe0fa6b02cf163b690131711d0d360bf4ec35c48 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5874106 > Commit-Queue: Lei Zhang <thestig@chromium.org> > Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> > Reviewed-by: Alan Screen <awscreen@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1358916} Bug: 351990827 Change-Id: I041a3974fc8443ec2f9db4d0086c6db629ca74c8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5881145 Commit-Queue: Takashi Sakamoto <tasak@google.com> Owners-Override: Takashi Sakamoto <tasak@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1359119}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.