2e8d92c71b
A corrupted Pickle (or one generated by a fuzzer) can give a size for a container that is larger than the available memory. Previously, net::PickleTraits would attempt to pre-allocate memory for contiguous containers even if the requested size was impossibly big. This caused issues when running with memory checkers or limited memory. Add a method to base::PickleIterator that gives the number of bytes left to read in the Pickle. Use this method in net::PickleTraits to check if the size given for the container is plausible. If it is not, give up deserializing before allocating any memory. BUG=400852654,399562754,382394774 Change-Id: I4d843e710e9a6b7d85368cfad4e3b16dfa896143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6332612 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/main@{#1429367}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.