30c110be15
The enable_if_t condition introduced in https://crrev.com/c/2379840 relies on std::is_copy_constructible for dispatching to move/copy overloads of RunOnceCallbackImpl; however, std::is_copy_constructible always returns true for std::vector<MoveOnly> (and subsequently for std::tuple<std::vector<MoveOnly>>) which ultimately leads to compilation failures when the incorrect overload is selected. This CL ensures a clearer separation between the move- and copy- use cases by means of splitting the API into two different functions. Bug: None Change-Id: Ie194713e740958db1413c44c4f179cee5edc83e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5010398 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Andrew Rayskiy <greengrape@google.com> Owners-Override: Daniel Cheng <dcheng@chromium.org> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1224856}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.