3a803b7e85
In some cases where External Navigation is blocked it makes sense to prompt the user to ask if they would like to leave Chrome. The most common case for this is login forms that take more than 5s to complete using an XHR or similar. Other cases like bookmarks that redirect to an app or similar, which we don't want to have automatically leave Chrome, can also ask the user if they would like to leave Chrome. These cases should be extremely rare, so the Message should very rarely be shown, but in cases where it does get shown it gives the user an escape hatch for what would otherwise be a broken experience. In this reland I fix the issue where returning early to show the message was bypassing other checks we needed to perform before launching an app. Refactoring was done to move the call to show the message to just before we go to actually launch an app. Bug: 1320502 Change-Id: I00783c3a8e645c411258a9c09b5bf03599237fa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3738859 Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/main@{#1020640}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.