
In doing so, this fixes a UBSan regression by replacing a memcpy with a copy_from. See https://crrev.com/c/5445709/comment/06ebb040_ac11ce65/ I stopped short of spanifying StreamParserBuffer because that class currently treats (null, 0) and (non-null, 0) as different. It is unclear to me whether this is really a class that takes optional<span<const uint8_t>> or if this is a mistake and it should be checking for empty spans. Bug: 40284755, 40248746 Change-Id: I235fe2b4519afdc3d1c6eebdfb4431cc49ca0423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5452412 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Florent Castelli <orphis@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by: Kenneth MacKay <kmackay@chromium.org> Reviewed-by: Mark Foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/main@{#1295527}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.