41d66e7828
The vfs lock/unlock implementation for fuchsia was missing some
corner cases that caused it to not quite behave like the native
filesystem implementations.
Previously, vfs_wrapper_fuchsia attempted to do purely exclusive locks
and track the current lock level on the instance of VfsFile. That
simplification collided with tests (and likely production code) that
expected to be able to use a shared lock. Tests that expected to be able
to use a shared lock failed because the lock was denied when requested
by the second requester.
This CL adds support for SQLITE_LOCK_SHARED lock levels. In
order to do that, the lock level is moved outside of individual VfsFile
instances and additional logic is added to disallow promoting a shared
lock to exclusive if there are other current holders of the lock. Logic
is also added to prevent unlocking if there are other readers still
holding shared locks.
Bug: 1288488
Change-Id: I8ffd813f9acade85ae709cbcddeb4708eddda07e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3387490
Reviewed-by: Fabrice de Gans <fdegans@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Bryant Chandler <bryantchandler@chromium.org>
Cr-Commit-Position: refs/heads/main@{#971849}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.