425d0d37a5
Add a new pref that specifically records when the user performs an explicit sign in from the bookmark bubble. This is a Signin pref which means it is a per-account pref. `SelectTypeAndMigrateLocalDataItemsWhenActive` no longer selects the data type for account storage, but resets it to its default value in case it had been disabled before. This is done so that if the default value is determined through a pref (e.g. for bookmarks or extensions), the pref can be unset through disabling the flag again, and the explicit opt-in does not persist. For bookmarks, this flag is `switches::kSyncEnableBookmarksInTransportMode`. Since the code paths that lead to this function all go through the sign in promo, the default value for all types should be set to true. Those users that had previously explicitly opted out will go back to relying on the default value. Scenarios: - User was explicitly opted in before -> stay explicitly opted in - User was explicitly opted in before -> opted in through default value - User had not previously made a choice -> opted in through default value Bug: 399327164 Change-Id: I930b3968c5a1fa2d2a03b10ffe2b80cb8f84e87b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6308817 Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Amelie Schneider <amelies@google.com> Cr-Commit-Position: refs/heads/main@{#1428307}
v8
@ b389260183
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.