45287901c9
Increase PDFiumEngineInkDrawTest coverage by changing the StrokeData test case to draw the second stroke with the highlighter brush instead of the pen brush. The existing test only used pen brushes, and missed a regression involving highlighter brushes. This independently tests to make sure PDFiumEngine's PDFium API usage works as expected, separate from PDFium's own testing and fix in CLs [1] and [2]. As part of this: - Rename constants and variables to be more descriptive. - Draw the highlighter stroke in a different color for more variety. - Update some comments so the cause and effect is clearer. [1] https://pdfium-review.googlesource.com/126270 [2] https://pdfium-review.googlesource.com/126390 Bug: 378464305 Change-Id: I7fa5d52f6c9b675d982427860dce8503082d8168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6040196 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Alan Screen <awscreen@chromium.org> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1386416}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.