cffd2d75d3
RubberStamper is documented at https://www.chromium.org/developers/how-tos/drover but not very discoverable there. R=yulanlin Change-Id: I4ac318fa36e3d9c11bb66000ca4828f2e9e025fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2737759 Auto-Submit: Joe Mason <joenotcharles@chromium.org> Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#860885}
24 lines
997 B
Markdown
24 lines
997 B
Markdown
# Mandatory Code-Review and OWNERS
|
|
|
|
Beginning in Q1 2021, committers@ of Chromium will no longer be able
|
|
to circumvent code review and OWNERS approval on CLs.
|
|
|
|
Currently, these are circumventable by self-code-review and because the
|
|
enforcement is done by presumit, although rarely done by external
|
|
contributors. In Q1, Gerrit will disallow both bypasses. As part of the
|
|
transition, an audit service will automatically file bugs for CLs that
|
|
land with only self-approval, launching in Q4 2020. Within Google, where
|
|
these bypasses are more common, Googlers can find Google-specific
|
|
information in the internal announcements and landing site.
|
|
|
|
Periodic updates and FAQs will be sent to chromium-dev@chromium.org
|
|
and updated on this page.
|
|
|
|
## FAQS
|
|
|
|
Q: Do I need a reviewer to merge CL's to another branch, even though they were
|
|
already reviewed on main?
|
|
|
|
A: Yes, but within 7 days of the original change you can add the Rubber-Stamper
|
|
bot (rubber-stamper@appspot.gserviceaccount.com) as the reviewer.
|