51ba18064e
Reason for revert in CL:6101793: VoiceOver not reading autofill, crbug.com/379143333 Fixed autofill case by only implementing the new role for content. We keep NSAccessibilityStaticTextRole for options in UI. Eventually, we hope that Apple will provide new role for options. Original commit message: A previous attempt at fixing https://crbug.com/1221690 (truncated option text) was to expose different text, rather than exposing the name. However, it's important to expose the accessible name because a lot more goes into it than just appending descendant text together. For example, whitespace is added where appropriate. Therefore, the previous fix caused new bugs such as https://crbug.com/40773609. The original problem occurs because VoiceOver does not expect a descendant subtree for AXStaticText, and ends up using the subtree's text but concatenates it to the length of the AXValue. To fix this issue while retaining the accessible name, we can either: 1. Truncate the subtree for options. The problem with this is that options can have important, even interactive, descendants. 2. Use a different role than the officially recommended role. It seems that NSAccessibilityMenuItemRole is reasonable. It does cause VoiceOver to announce each option as a menu item, but it seems that the options basically are similar to menu items. Idea #2 seems to have the fewest downsides. Therefore, this CL undoes the original problematic fix from CL:2976454 and instead implements idea #2. In the meantime we have contacted James Craig from Apple for a recommendation. They are going to look into a fix in VoiceOver and get back to us when there is a new recommendation. For the short term, James said it makes sense to go with solution #2 (this CL). Bug: 40773609 Change-Id: Ibd8ab9939cbad5ba77bfe35ac8289be84b1fec9e Fixed: 379289359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6104178 Reviewed-by: Jacques Newman <janewman@microsoft.com> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/main@{#1403047}
v8
@ 41dacffe43
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.