
We aren't ready to complete the refactoring yet until configs are moved source side. So removing for now. Bug: 1028719 Change-Id: I046709c142cb0dfa480840040b44ce695cdcb09d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2195641 Reviewed-by: Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Gregory Guterman <guterman@google.com> Cr-Commit-Position: refs/heads/master@{#768020}
218 lines
6.3 KiB
Python
Executable File
218 lines
6.3 KiB
Python
Executable File
#!/usr/bin/python
|
|
# Copyright 2020 The Chromium Authors. All rights reserved.
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
"""Tests for mb_validate.py."""
|
|
|
|
from __future__ import print_function
|
|
from __future__ import absolute_import
|
|
|
|
import sys
|
|
import ast
|
|
import os
|
|
import unittest
|
|
|
|
sys.path.insert(0, os.path.join(
|
|
os.path.dirname(os.path.abspath(__file__)), '..'))
|
|
|
|
from mb import mb
|
|
from mb import mb_unittest
|
|
from mb.lib import validation
|
|
|
|
TEST_UNREFERENCED_MIXIN_CONFIG = """\
|
|
{
|
|
'public_artifact_builders': {},
|
|
'configs': {
|
|
'rel_bot_1': ['rel'],
|
|
'rel_bot_2': ['rel'],
|
|
},
|
|
'masters': {
|
|
'fake_master_a': {
|
|
'fake_builder_a': 'rel_bot_1',
|
|
'fake_builder_b': 'rel_bot_2',
|
|
},
|
|
},
|
|
'mixins': {
|
|
'unreferenced_mixin': {
|
|
'gn_args': 'proprietary_codecs=true',
|
|
},
|
|
'rel': {
|
|
'gn_args': 'is_debug=false',
|
|
},
|
|
},
|
|
}
|
|
"""
|
|
|
|
TEST_UNKNOWNMIXIN_CONFIG = """\
|
|
{
|
|
'public_artifact_builders': {},
|
|
'configs': {
|
|
'rel_bot_1': ['rel'],
|
|
'rel_bot_2': ['rel', 'unknown_mixin'],
|
|
},
|
|
'masters': {
|
|
'fake_master_a': {
|
|
'fake_builder_a': 'rel_bot_1',
|
|
'fake_builder_b': 'rel_bot_2',
|
|
},
|
|
},
|
|
'mixins': {
|
|
'rel': {
|
|
'gn_args': 'is_debug=false',
|
|
},
|
|
},
|
|
}
|
|
"""
|
|
|
|
TEST_UNKNOWN_NESTED_MIXIN_CONFIG = """\
|
|
{
|
|
'public_artifact_builders': {},
|
|
'configs': {
|
|
'rel_bot_1': ['rel', 'nested_mixin'],
|
|
'rel_bot_2': ['rel'],
|
|
},
|
|
'masters': {
|
|
'fake_master_a': {
|
|
'fake_builder_a': 'rel_bot_1',
|
|
'fake_builder_b': 'rel_bot_2',
|
|
},
|
|
},
|
|
'mixins': {
|
|
'nested_mixin': {
|
|
'mixins': {
|
|
'unknown_mixin': {
|
|
'gn_args': 'proprietary_codecs=true',
|
|
},
|
|
},
|
|
},
|
|
'rel': {
|
|
'gn_args': 'is_debug=false',
|
|
},
|
|
},
|
|
}
|
|
"""
|
|
|
|
|
|
class UnitTest(unittest.TestCase):
|
|
def test_GetAllConfigs(self):
|
|
configs = ast.literal_eval(mb_unittest.TEST_CONFIG)
|
|
all_configs = validation.GetAllConfigs(configs['masters'])
|
|
self.assertEqual(all_configs['rel_bot'], 'fake_master')
|
|
self.assertEqual(all_configs['debug_goma'], 'fake_master')
|
|
|
|
def test_CheckAllConfigsAndMixinsReferenced_ok(self):
|
|
configs = ast.literal_eval(mb_unittest.TEST_CONFIG)
|
|
errs = []
|
|
all_configs = validation.GetAllConfigs(configs['masters'])
|
|
config_configs = configs['configs']
|
|
mixins = configs['mixins']
|
|
|
|
validation.CheckAllConfigsAndMixinsReferenced(errs, all_configs,
|
|
config_configs, mixins)
|
|
|
|
self.assertEqual(errs, [])
|
|
|
|
def test_CheckAllConfigsAndMixinsReferenced_unreferenced(self):
|
|
configs = ast.literal_eval(TEST_UNREFERENCED_MIXIN_CONFIG)
|
|
errs = []
|
|
all_configs = validation.GetAllConfigs(configs['masters'])
|
|
config_configs = configs['configs']
|
|
mixins = configs['mixins']
|
|
|
|
validation.CheckAllConfigsAndMixinsReferenced(errs, all_configs,
|
|
config_configs, mixins)
|
|
|
|
self.assertIn('Unreferenced mixin "unreferenced_mixin".', errs)
|
|
|
|
def test_CheckAllConfigsAndMixinsReferenced_unknown(self):
|
|
configs = ast.literal_eval(TEST_UNKNOWNMIXIN_CONFIG)
|
|
errs = []
|
|
all_configs = validation.GetAllConfigs(configs['masters'])
|
|
config_configs = configs['configs']
|
|
mixins = configs['mixins']
|
|
|
|
validation.CheckAllConfigsAndMixinsReferenced(errs, all_configs,
|
|
config_configs, mixins)
|
|
self.assertIn(
|
|
'Unknown mixin "unknown_mixin" '
|
|
'referenced by config "rel_bot_2".', errs)
|
|
|
|
def test_CheckAllConfigsAndMixinsReferenced_unknown_nested(self):
|
|
configs = ast.literal_eval(TEST_UNKNOWN_NESTED_MIXIN_CONFIG)
|
|
errs = []
|
|
all_configs = validation.GetAllConfigs(configs['masters'])
|
|
config_configs = configs['configs']
|
|
mixins = configs['mixins']
|
|
|
|
validation.CheckAllConfigsAndMixinsReferenced(errs, all_configs,
|
|
config_configs, mixins)
|
|
|
|
self.assertIn(
|
|
'Unknown mixin "unknown_mixin" '
|
|
'referenced by mixin "nested_mixin".', errs)
|
|
|
|
def test_CheckAllConfigsAndMixinsReferenced_unused(self):
|
|
configs = ast.literal_eval(TEST_UNKNOWN_NESTED_MIXIN_CONFIG)
|
|
errs = []
|
|
all_configs = validation.GetAllConfigs(configs['masters'])
|
|
config_configs = configs['configs']
|
|
mixins = configs['mixins']
|
|
|
|
validation.CheckAllConfigsAndMixinsReferenced(errs, all_configs,
|
|
config_configs, mixins)
|
|
|
|
self.assertIn(
|
|
'Unknown mixin "unknown_mixin" '
|
|
'referenced by mixin "nested_mixin".', errs)
|
|
|
|
def test_EnsureNoProprietaryMixins(self):
|
|
bad_configs = ast.literal_eval(mb_unittest.TEST_BAD_CONFIG)
|
|
errs = []
|
|
default_config = 'fake_config_file'
|
|
config_file = 'fake_config_file'
|
|
masters = bad_configs['masters']
|
|
mixins = bad_configs['mixins']
|
|
config_configs = bad_configs['configs']
|
|
|
|
validation.EnsureNoProprietaryMixins(errs, default_config, config_file,
|
|
masters, config_configs, mixins)
|
|
|
|
self.assertIn(
|
|
'Public artifact builder "a" '
|
|
'can not contain the "chrome_with_codecs" mixin.', errs)
|
|
self.assertIn(
|
|
'Public artifact builder "b" '
|
|
'can not contain the "chrome_with_codecs" mixin.', errs)
|
|
self.assertEqual(len(errs), 2)
|
|
|
|
def test_CheckDuplicateConfigs_ok(self):
|
|
configs = ast.literal_eval(mb_unittest.TEST_CONFIG)
|
|
config_configs = configs['configs']
|
|
mixins = configs['mixins']
|
|
grouping = configs['masters']
|
|
errs = []
|
|
|
|
validation.CheckDuplicateConfigs(errs, config_configs, mixins, grouping,
|
|
mb.FlattenConfig)
|
|
self.assertEqual(errs, [])
|
|
|
|
@unittest.skip('bla')
|
|
def test_CheckDuplicateConfigs_dups(self):
|
|
configs = ast.literal_eval(mb_unittest.TEST_DUP_CONFIG)
|
|
config_configs = configs['configs']
|
|
mixins = configs['mixins']
|
|
grouping = configs['masters']
|
|
errs = []
|
|
|
|
validation.CheckDuplicateConfigs(errs, config_configs, mixins, grouping,
|
|
mb.FlattenConfig)
|
|
self.assertIn(
|
|
'Duplicate configs detected. When evaluated fully, the '
|
|
'following configs are all equivalent: \'some_config\', '
|
|
'\'some_other_config\'. Please consolidate these configs '
|
|
'into only one unique name per configuration value.', errs)
|
|
|
|
|
|
if __name__ == '__main__':
|
|
unittest.main()
|