
Currently, the Thumbnail class gets instantiated with a page size in points, represented by gfx::Size, which uses integer values. The production caller gets float values from PDFium and truncates them when instantiating Thumbnails. Switch the class to take a gfx::SizeF instead, so callers can pass the page size in without truncating. This may make thumbnail size calculations slightly more accurate. It also reduces decision making that has to happen if more PDF code starts using gfx::SizeF for page sizes. The size value can pass straight in, without the need to make a decision on whether to floor or round the size value. Add some new test cases to show how the code behaves with fractional page sizes. Change-Id: Iff8da05c58daaf0a7f1df485ff2e98d2da1784fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6287607 Reviewed-by: Alan Screen <awscreen@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/main@{#1423228}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.