
This CL updates `channel_data_` to use spans instead of `float *`. To do this safely, we must enforce that `set_frames()` is called before `SetChannelData()`, to ensure `frames()` matches the size of the spans passed. Otherwise, we could have different results whether we use range based iterators on channels, or index into the spans based off of the frame count. This CL also adds convenience functions to allow range based for-loops and setting all data channels for a wrapper AudioBus at once. Bug: 373960632 Change-Id: Ibcbe46c5f08467cd8b44e4f694e534072fbf8e53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102957 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Mark Foltz <mfoltz@chromium.org> Owners-Override: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by: Hongchan Choi <hongchan@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1398980}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.