7ad9365ab4
This new implementation seems simpler and doesn't tickle the same msan
bugs that the original changelist got reverted for. In this solution
::Check##name##Impl returns two strings on failure (likely inlined
anyways) instead of a single pointer and the caller can construct the
check-failure object.
Original change's description:
> Revert "Push non-official CHECK_op failures into lambda"
>
> This reverts commit a5911aa482.
>
> Reason for revert: This breaks some tests on Linux MSAN. Please see crbug.com/384553537 for more details.
>
> Original change's description:
> > Push non-official CHECK_op failures into lambda
> >
> > This seems to generate significantly better code in the hot spot of a
> > fuzzer (~800 ms instead of ~1200 ms). If we're lucky it also translates
> > some to real-world performance of developer and official-DCHECK builds.
> > This is believed to be because most of the code for the failure path
> > can get out-of-lined by the compiler now.
> >
> > This also intends to out-of-line the "foo < bar" string from in the hot
> > spot of a CHECK_op macro which hopefully means less parameter passing.
> >
> > Bug: 40241607, 382071730
> > Change-Id: I9a4bbef3e3a77280056e158fb215647656a8c00f
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6095761
> > Reviewed-by: Peter Kasting <pkasting@chromium.org>
> > Commit-Queue: Peter Boström <pbos@chromium.org>
> > Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
> > Cr-Commit-Position: refs/heads/main@{#1396998}
>
> Bug: 384553537, 40241607, 382071730
> Change-Id: Ibd85c1dbea710fc7585d08ac86fcf9ad7af1ba47
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6097359
> Owners-Override: Taiyo Mizuhashi <taiyo@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Reviewed-by: thefrog <thefrog@chromium.org>
> Commit-Queue: thefrog <thefrog@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1398076}
Bug: 384553537, 40241607, 382071730
Change-Id: Ie5663afbabda3eccbd01656617bd889169e8cd8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6124647
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Owners-Override: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401663}
v8
@ 41dacffe43
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.