PLEASE DO NOT REVERT FOR TAST FAILURES --
The fix in CL:5516014 is in a different repo so has to land separately.
This is a reland of commit d6d489a38d
Reason for revert:
Sample build with failed test: https://ci.chromium.org/b/8749012979391630193
Affected test(s):
[ninja://:blink_web_tests/http/tests/inspector-protocol/accessibility/accessibility-ignoredNodes.js](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2F:blink_web_tests%2Fhttp%2Ftests%2Finspector-protocol%2Faccessibility%2Faccessibility-ignoredNodes.js?q=VHash%3Ad656188f56ce4659)
[ninja://:blink_web_tests/virtual/plz-dedicated-worker-disabled/http/tests/inspector-protocol/accessibility/accessibility-ignoredNodes.js]
(https://ci.chromium.org/ui/test/chromium/ninja:%2F%2F:blink_web_tests%2Fvirtual%2Fplz-dedicated-worker-disabled%2Fhttp%2Ftests%2Finspector-protocol%2Faccessibility%2Faccessibility-ignoredNodes.js?q=VHash%3Ad656188f56ce4659)
These are fixed in the latest patchset (original code in patchset 1).
Fix was to not attempt to compute accessible name for menu list popup.
Also broke https://ci.chromium.org/ui/p/chrome/builders/ci/chromeos-betty-pi-arc-chrome/31806/overview:
arc.Print.container_p
inputs.PhysicalKeyboardKoreanTyping
These are fixed by https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/5516014,
which is in a different repro so must land separately.
Fix was to change tests to look for menulistoption role instead of listboxoptionrole.
Original change's description:
> [A11y] Remove AXMenuList* special classes/cases, support <optgroup>
>
> Currently Blink uses specialized AXMenuList/AXMenuListPopup/
> AXMenuListOption classes to override building of a <select size=1>
> subtree, and only allow <option> children. This is only used on
> some platforms. Other platforms use the ordinary AXNodeObject
> code. This removes the AXMenuList* subclasses (as well as
> AXMockObject, which is no longer necessary for the popup).
> The AXNodeObject implementation is used for <select> on all platforms.
>
> There are many reasons to do this:
> 1. Remove ~1300 lines of code, much of it scattered as special cases
> inside otherwise generic code.
> 2. Less brittle -- the special classes/case, including special tree
> building, were often a source of instability.
> 3. Because the subtree is now built using our general
> LayoutTreeBuilderTraversal code, can support arbitrary descendants
> thus unblocking a11y for the experimental stylable select.
> 4. Because of #3, can now support optgroup correctly for both types
> of <select>. The optgroup was previously supported in
> listbox selects only, and even there it was incorrect -- it was
> exposed as as a sibling of the options. Blink now exposes optgroup
> correctly for both types of selects, with the correct structure
> (the optgroup is a parent rather than a sibling). This now matches
> how Firefox exposes optgroup.
>
> Future changes can possibly deprecated the menuListValueChangedEvent,
> as well as roles menuListPopup (replace with generic container or
> listBox) and menuListOption (replace with listBoxOption).
>
> Bug: 40799465,40791317,41490722,40799465,40720672,40146374,41373952,41339236,41490165,338201026
> Change-Id: Ib0e551b6a26b5d976aa6aa0949d87f8959a217f5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5467030
> Reviewed-by: Jacques Newman <janewman@microsoft.com>
> Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1295735}
Bug: 40799465,40791317,41490722,40799465,40720672,40146374,41373952,41339236,41490165,338201026
Change-Id: I1b49004ad726456baf564d1d5e940174fe590c6e
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5513503
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Jacques Newman <janewman@microsoft.com>
Reviewed-by: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1297838}
5904929f88