
The Ads Blocked dialog currently does not have an option to dismiss the dialog by clicking a button on the dialog.
This CL accounts for the following updates to the Ads Blocked dialog layout:
- Replace "Learn more" with "Cancel" as the negative button, that will dismiss the dialog on click
- Include the "Learn more" link in the dialog message (description)
Screenshot of the current layout: https://screenshot.googleplex.com/8Ln7449TbnovSpx.png
Screenshot of the updated layout: https://screenshot.googleplex.com/64MNDBkTKfYUsCd.png
Bug: 1233696
Change-Id: I14afec5582eb5d6a587d7ba67e465775d6d0a5bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3152675
Commit-Queue: Aishwarya Rajesh <aishwaryarj@google.com>
Reviewed-by: Alex Turner <alexmt@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#922167}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.