89d5b648aa
There is only a single global Manager, but it is constructed with pointers to things like PrefService. In tests, this ends up being problematic since the PrefService is owned by BrowserProcessImpl, which is destroyed between test runs. Instead, add a layer of indirection with a Delegate interface to provide the PrefService to the Manager. The default delegate implementation is stateless and simply returns a pointer to the PrefService on demand, Also move SetTpcdMetadataGrants() over to the delegate implementation as a single point for injecting various //chrome dependencies, and remove the now-unneeded null checks in tpcd::metadata::Manager. Bug: 348573593 Change-Id: I1ee04029c191504d0bbb1cf5e30580038c7f6c96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5666460 Reviewed-by: Jonathan Njeunje <njeunje@chromium.org> Reviewed-by: Christian Dullweber <dullweber@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Samar Chehade-Lepleux <samarchehade@google.com> Cr-Commit-Position: refs/heads/main@{#1321982}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.