
A user can simultaneously apply different modes of input (such as mouse + keyboard, or mouse + touchscreen) to cause a change in tool state in the middle of a drawing stroke. Modify PdfInkModule so that the current drawing brush can not be changed while there is an in-progress drawing stroke. Any changes to drawing tool state is captured and applied after an in-progress stroke is finished, making the changes only applicable to subsequent strokes. This includes delaying an update to the cursor image, so that it consistently matches the PdfInkBrush state. Bug: 381908888 Change-Id: Icbeb342b9c3d7e614be6ee044c7355a3041c4a44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6103003 Reviewed-by: Lei Zhang <thestig@chromium.org> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Reviewed-by: Andy Phan <andyphan@chromium.org> Commit-Queue: Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/main@{#1405717}
//pdf
contains the PDF plugin, its Blink-based replacement, as well as PDF
utility functions that leverage PDFium. It can use low-level components that
live below the content layer, as well as other foundational code like
//printing
. It should not use //content
or anything in //components
that
lives above the content layer. Code that lives above the content layer should
live in //components/pdf
, or in the embedder. All the code here should run in
sandboxed child processes.
TODO(crbug.com/40186598): Remove existing //content
dependencies.