a0d0567512
When recording IDNA2008 metrics, if a hostname passed in has a trailing dot, there could be a mismatch between the label count derived from the canonicalized eTLD+1 and the vector of unicode hostname labels, causing an integer underflow and a crash when erasing elements from the vector. This change aligns the two by changing the base::StringSplit() call to use `base::SPLIT_WANT_ALL` to keep an empty "trailing label" in these cases. Bug: 1362507 Change-Id: I16a15f041c03c3e3038b1c8fb9c68c1d7cea303b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3891980 Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Auto-Submit: Chris Thompson <cthomp@chromium.org> Commit-Queue: Chris Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/main@{#1046510}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.