
A single continuous user stroke might not stay on one page, but could leave and reenter the page. Any portion of the stroke outside the page boundaries does not get drawn in a resulting PDF. This can result in different segments of a stroke, should the pen reenter at a different point than where it left the page. Note that a stroke that leaves the initial page and enters another page does not stroke there, as handled by https://crrev.com/1318194. Update the InkModule data structures to support a single user stroke in progress being made up of one or more stroke segments. Each segment is treated as a separate stroke once stroking finishes. Marking each segment's stroke with an ID comes in follow-up CL https://crrev.com/c/5594202, which can enforce the segments being treated as a single object for undo/redo purposes. Bug: 335524380 Change-Id: I3d2af83026926a3c2c89bbd583a34a4baa3713fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5549003 Commit-Queue: Alan Screen <awscreen@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1319402}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.